From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4115EC3F68F for ; Fri, 31 Jan 2020 20:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1271520707 for ; Fri, 31 Jan 2020 20:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AC/s3Jlh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbgAaUbd (ORCPT ); Fri, 31 Jan 2020 15:31:33 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54830 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbgAaUbd (ORCPT ); Fri, 31 Jan 2020 15:31:33 -0500 Received: by mail-wm1-f65.google.com with SMTP id g1so9374488wmh.4; Fri, 31 Jan 2020 12:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rXOjIgLKMcS/rpvOcjjPy6Ti8Ik2MqTM5puLhDaf+2M=; b=AC/s3JlhTammh7DuDj+dq5D4FIz2PyNfWUpQSzudQIEQEj0L/zV/UnSbyd+pqnQgq3 cNOfpuBJimYlJwyDz07T3ZccRR1+wvcFD1hfx7CMxH0cHRR2ZRs1ieiLBNddkJoatJL7 HfmGDwAgRaotmSopgrdtk0OwAxa3WHc77wNnyf7BOneWj/iAUnbHc6sC1CsTdrEs0P/G W47WQ7U3LxjVOgqdq1eNgPdnn6qC5Au95Fn7PfzIf6GrsTYdESGAO0kfJd+p0JNa0dIN sSEzkpst+UKeCmLaO23s+EXcjR7RvUweynFyyjJsw8si/Qwopa9zZWnhcf2FgBzhNvQh DfwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rXOjIgLKMcS/rpvOcjjPy6Ti8Ik2MqTM5puLhDaf+2M=; b=D3kXyhOGmVtNY1ME+WWWXPttGdRlYNp/iSurjGdjfs6b8FqdRQYj8ziEjpaELuDMpm LZcR10DaKCM0fUMgeolM87rIY0gsfUpLs1pJx8pIvQSgXXq8N4fNdbn8GCw1ndJb6U7v uYXKJUZ+LDML5wFqv+hk9itwAnIbzpsQgmBRS+lm8nXU5WbNysoCkcWQXKaXUSnCAu1m Cn7GZWze+p+ZI8ZnNwUuuNoZSKxoyjPxHOuOE/97jmDANiUGPT1ZwBSTdehXjz4H4sg8 b/lWNtin0tjnMV8wLUjG+P0GzB6ZGBZgaUiEj6I0lfhAZKs8pi+/txJAfocc38lPGEum unlw== X-Gm-Message-State: APjAAAVUHipIb5Gsupqhxjszc/vYgmc/WkYYS10480ZkNWd+QYCcU/XQ bK5dfojgibWc1hyFoB2vdJw= X-Google-Smtp-Source: APXvYqzgqNaT0xwI2rZs4vQxGOlXPQIGM3VlVv3wDKFwF2l3FOVK1slW8HIJhIvAh/YlgH0d3T0GYw== X-Received: by 2002:a1c:dcd5:: with SMTP id t204mr13850420wmg.34.1580502689536; Fri, 31 Jan 2020 12:31:29 -0800 (PST) Received: from localhost (p2E5BEF3F.dip0.t-ipconnect.de. [46.91.239.63]) by smtp.gmail.com with ESMTPSA id w7sm11549502wmi.9.2020.01.31.12.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2020 12:31:26 -0800 (PST) Date: Fri, 31 Jan 2020 21:31:25 +0100 From: Thierry Reding To: Hans Verkuil Cc: Sowjanya Komatineni , jonathanh@nvidia.com, frankc@nvidia.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 0/5] Add Tegra driver for video capture Message-ID: <20200131203125.GB3444092@ulmo> References: <1580235801-4129-1-git-send-email-skomatineni@nvidia.com> <20200130154246.GA2904678@ulmo> <8654e6fd-c403-6e68-e5cf-09297b5d8b5d@xs4all.nl> <20200131170351.GA3444092@ulmo> <173dfa3f-a87f-c5dd-1966-558d6edafc3d@xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OwLcNYc0lM97+oe1" Content-Disposition: inline In-Reply-To: <173dfa3f-a87f-c5dd-1966-558d6edafc3d@xs4all.nl> User-Agent: Mutt/1.13.1 (2019-12-14) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org --OwLcNYc0lM97+oe1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 31, 2020 at 06:37:10PM +0100, Hans Verkuil wrote: > On 1/31/20 6:03 PM, Thierry Reding wrote: > > On Fri, Jan 31, 2020 at 03:29:52PM +0100, Hans Verkuil wrote: > >> On 1/30/20 4:42 PM, Thierry Reding wrote: > >>> On Thu, Jan 30, 2020 at 03:41:50PM +0100, Hans Verkuil wrote: > >>>> Hi Sowjanya, > >>>> > >>>> On 1/28/20 7:23 PM, Sowjanya Komatineni wrote: > >>>>> This series adds Tegra210 VI and CSI driver for built-in test patte= rn > >>>>> generator (TPG) capture. > >>>>> > >>>>> Tegra210 supports max 6 channels on VI and 6 ports on CSI where each > >>>>> CSI port is one-to-one mapped to VI channel for video capture. > >>>>> > >>>>> This series has TPG support only where it creates hard media links > >>>>> between CSI subdevice and VI video device without device graphs. > >>>>> > >>>>> v4l2-compliance results are available below the patch diff. > >>>>> > >>>>> [v0]: Includes, > >>>>> - Adds CSI TPG clock to Tegra210 clock driver > >>>>> - Host1x video driver with VI and CSI clients. > >>>>> - Support for Tegra210 only. > >>>>> - VI CSI TPG support with hard media links in driver. > >>>>> - Video formats supported by Tegra210 VI > >>>>> - CSI TPG supported video formats > >>>> > >>>> I'm trying to compile this patch series using the media_tree master > >>>> branch (https://git.linuxtv.org//media_tree.git), but it fails: > >>>> > >>>> drivers/staging/media/tegra/tegra-channel.c: In function =E2=80=98te= gra_channel_queue_setup=E2=80=99: > >>>> drivers/staging/media/tegra/tegra-channel.c:71:15: warning: unused v= ariable =E2=80=98count=E2=80=99 [-Wunused-variable] > >>>> 71 | unsigned int count =3D *nbuffers; > >>>> | ^~~~~ > >>>> drivers/staging/media/tegra/tegra-channel.c: In function =E2=80=98te= gra_channel_init=E2=80=99: > >>>> drivers/staging/media/tegra/tegra-channel.c:518:55: error: =E2=80=98= struct host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >>>> 518 | struct tegra_camera *cam =3D dev_get_drvdata(vi->client.hos= t); > >>>> | ^ > >>>> make[4]: *** [scripts/Makefile.build:265: drivers/staging/media/tegr= a/tegra-channel.o] Error 1 > >>>> make[4]: *** Waiting for unfinished jobs.... > >>>> drivers/staging/media/tegra/tegra-vi.c: In function =E2=80=98tegra_v= i_tpg_graph_init=E2=80=99: > >>>> drivers/staging/media/tegra/tegra-vi.c:157:55: error: =E2=80=98struc= t host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >>>> 157 | struct tegra_camera *cam =3D dev_get_drvdata(vi->client.hos= t); > >>>> | ^ > >>>> drivers/staging/media/tegra/tegra-vi.c: In function =E2=80=98tegra_v= i_init=E2=80=99: > >>>> drivers/staging/media/tegra/tegra-csi.c: In function =E2=80=98tegra_= csi_init=E2=80=99: > >>>> drivers/staging/media/tegra/tegra-vi.c:213:51: error: =E2=80=98struc= t host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >>>> 213 | struct tegra_camera *cam =3D dev_get_drvdata(client->host); > >>>> | ^~ > >>>> drivers/staging/media/tegra/tegra-csi.c:259:51: error: =E2=80=98stru= ct host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >>>> 259 | struct tegra_camera *cam =3D dev_get_drvdata(client->host); > >>>> | ^~ > >>>> drivers/staging/media/tegra/tegra-vi.c: In function =E2=80=98tegra_v= i_exit=E2=80=99: > >>>> drivers/staging/media/tegra/tegra-vi.c:246:51: error: =E2=80=98struc= t host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >>>> 246 | struct tegra_camera *cam =3D dev_get_drvdata(client->host); > >>>> | ^~ > >>>> drivers/staging/media/tegra/tegra-csi.c: In function =E2=80=98tegra_= csi_exit=E2=80=99: > >>>> drivers/staging/media/tegra/tegra-csi.c:286:51: error: =E2=80=98stru= ct host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >>>> 286 | struct tegra_camera *cam =3D dev_get_drvdata(client->host); > >>>> | ^~ > >>>> > >>>> And indeed, struct host1x_client as defined in include/linux/host1x.= h doesn't > >>>> have a 'host' field. > >>>> > >>>> Does this series depend on another patch that's not yet in mainline? > >>> > >>> Sowjanya's been working on top of linux-next, so, yes, this patch > >>> depends on a change that's been merged into the DRM tree for v5.6-rc1. > >>> > >>> Thierry > >>> > >> > >> Is there a specific linux-next tag that works? I tried next-20200131 b= ut that > >> failed to boot. Same problem with the mainline repo since the host1x p= atches > >> were merged yesterday. It compiles fine, but the boot just stops. Or a= m I > >> missing some kernel config that is now important to have? > >=20 > > linux-next and mainline are currently regressing on Tegra210 (and some > > Tegra124) boards. I just sent out a series that fixes the regression for > > me: > >=20 > > http://patchwork.ozlabs.org/project/linux-tegra/list/?series=3D156215 > >=20 > > Please test if this works for you. If so, I'll send this to Dave as soon > > as possible. >=20 > I'll try it on Tuesday as I don't have access to the Jetson TX1 until the= n. It > looks promising since I think that the last message I saw was a PM messag= e. Great. My local testing on Jetson Nano confirms that this fixes boot on top of linux-next and I've also run it through our internal test farm with success. I'll push this to my drm/tegra/for-next branch, so it should show up in linux-next on Monday. Thierry --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl40jpoACgkQ3SOs138+ s6GsKw/9GmS3lkoUnVWigejDV9uq911ocqLUjYnzIP3fGxFJ1thUuG+omcIgI0mi xwC2iw2wtxPMW65pQa2+rFSkHq3ExeaiYH310qkVZGesyvIbU+TIX/+fHflgG36J Bnyv4MTo1YpciOhwMh/bdfCJJarnPC50SD1yWoEBwYqe+jtZVVMAa6RfNuHebn7+ i4rad8NkoOqBmsPpvw5q3Bod0QJRnWI56CVxC6aamZdfsnBcUDFIheueybK17kAm 7biKjP/MERe1upvsLHXud/r6H4Gx6UqENVSB24x6XMUdk4T7GlC546kUI/7B0YSh cTpmQmDtkWV7j7QWM/sGkvP2nlYZlKYG4onM8ihIpab1D+r1AWgaJTkYkknG+7Te tfdHcvsoTCwTtWkyN1xwcgXznmOJuv0aHAB5bCJ1cr/D617z/AjRabNBZsAMQMV9 oLBMkkS0R7g9j3QQI/LmKXk29FGmr/yCprp1LpGSX8akiiLyCUHNbz2EmMgN9wm7 LewBOUmgVicCwRSh0pByvSFbh5brvOoWyniOf8vLsWf3R4jULYRj5bFrynhYHHjJ hk4wOacB0TysyZ8Ggr+rAT0aVzBvCrAxXvwA6eVShPpkNhHHOC8QoqNuO3hs2jaV FiHXB0xTUsMcMnOnvCfNkmQE692LOt7PUvb5AzBYHSZzyyOZGIQ= =i3Ml -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1--