From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11D4C33CAC for ; Mon, 3 Feb 2020 14:14:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FD322166E for ; Mon, 3 Feb 2020 14:14:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pWk8qMTD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728222AbgBCOOy (ORCPT ); Mon, 3 Feb 2020 09:14:54 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:57630 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727715AbgBCOOx (ORCPT ); Mon, 3 Feb 2020 09:14:53 -0500 Received: from pendragon.ideasonboard.com (64.177-245-81.adsl-dyn.isp.belgacom.be [81.245.177.64]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 57A0111FE; Mon, 3 Feb 2020 15:14:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1580739292; bh=zvvTfrQvlgQEUpFsSU5HLQAWdaAYVnrSrCFzT2y/4yc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pWk8qMTD81zmR2/8Oxo14Sss0SbVOlmnOMvhChjgpKMboRxaEHnlwTLpOSaDfnRNN Ada8ewwf1yHDypcExAPHsLBpxcna9sKvxWCL6y5lRNi6Eb/Z/5O1T2wks3JCQdvZmI KOBj7ODXZJE/pKeuAS7Xpp9oka/9WgTVDpKKbxjg= Date: Mon, 3 Feb 2020 16:14:38 +0200 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org Subject: Re: [PATCH 02/11] gadget: uvc: rename VFL_TYPE_GRABBER to _VIDEO Message-ID: <20200203141438.GB4722@pendragon.ideasonboard.com> References: <20200203114119.1177490-1-hverkuil-cisco@xs4all.nl> <20200203114119.1177490-3-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200203114119.1177490-3-hverkuil-cisco@xs4all.nl> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Hans, Thank you for the patch. On Mon, Feb 03, 2020 at 12:41:10PM +0100, Hans Verkuil wrote: > 'GRABBER' is a weird name, all other types map to the /dev > device names. Rename to 'VIDEO' to be consistent with the > other types. > > Signed-off-by: Hans Verkuil > Cc: Laurent Pinchart Reviewed-by: Laurent Pinchart > --- > drivers/usb/gadget/function/f_uvc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c > index fb0a892687c0..0b9712616455 100644 > --- a/drivers/usb/gadget/function/f_uvc.c > +++ b/drivers/usb/gadget/function/f_uvc.c > @@ -428,7 +428,7 @@ uvc_register_video(struct uvc_device *uvc) > > video_set_drvdata(&uvc->vdev, uvc); > > - ret = video_register_device(&uvc->vdev, VFL_TYPE_GRABBER, -1); > + ret = video_register_device(&uvc->vdev, VFL_TYPE_VIDEO, -1); > if (ret < 0) > return ret; > -- Regards, Laurent Pinchart