From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: [RFC PATCH 4/9] mcam-core: drop VB2_USERPTR
Date: Fri, 21 Feb 2020 09:45:26 +0100 [thread overview]
Message-ID: <20200221084531.576156-5-hverkuil-cisco@xs4all.nl> (raw)
In-Reply-To: <20200221084531.576156-1-hverkuil-cisco@xs4all.nl>
The combination of VB2_USERPTR and dma-contig makes no sense for
this device, drop it.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
drivers/media/platform/marvell-ccic/mcam-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
index 803baf97f06e..4450307ae654 100644
--- a/drivers/media/platform/marvell-ccic/mcam-core.c
+++ b/drivers/media/platform/marvell-ccic/mcam-core.c
@@ -1300,7 +1300,7 @@ static int mcam_setup_vb2(struct mcam_camera *cam)
vq->drv_priv = cam;
vq->lock = &cam->s_mutex;
vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
- vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF | VB2_READ;
+ vq->io_modes = VB2_MMAP | VB2_DMABUF | VB2_READ;
vq->buf_struct_size = sizeof(struct mcam_vb_buffer);
vq->dev = cam->dev;
INIT_LIST_HEAD(&cam->buffers);
--
2.25.0
next prev parent reply other threads:[~2020-02-21 8:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 8:45 [RFC PATCH 0/9] Drop VB2_USERPTR + dma-contig combo Hans Verkuil
2020-02-21 8:45 ` [RFC PATCH 1/9] mtk-vcodec: drop VB2_USERPTR Hans Verkuil
2020-02-21 8:45 ` [RFC PATCH 2/9] solo6x10: " Hans Verkuil
2020-02-21 8:45 ` [RFC PATCH 3/9] m2m-deinterlace: " Hans Verkuil
2020-02-21 8:45 ` Hans Verkuil [this message]
2020-02-21 8:45 ` [RFC PATCH 5/9] sh_veu: " Hans Verkuil
2020-02-21 8:45 ` [RFC PATCH 6/9] mx2_emmaprp: " Hans Verkuil
2020-02-21 8:45 ` [RFC PATCH 7/9] davinci: " Hans Verkuil
2020-02-21 8:45 ` [RFC PATCH 8/9] exynos/s3c/s5p: " Hans Verkuil
2020-02-21 8:53 ` Tomasz Figa
2020-02-21 11:54 ` Hans Verkuil
2020-02-21 13:11 ` Marek Szyprowski
2020-02-21 13:34 ` Tomasz Figa
2020-02-21 8:45 ` [RFC PATCH 9/9] omap3isp/rcar_fdp1/vsp1/xilinx: " Hans Verkuil
2020-02-21 9:01 ` Kieran Bingham
2020-02-21 14:31 ` Laurent Pinchart
2020-02-21 19:46 ` Sakari Ailus
2020-02-22 10:43 ` Laurent Pinchart
2020-02-22 13:13 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221084531.576156-5-hverkuil-cisco@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).