From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Tomasz Figa <tfiga@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pawel Osciak <posciak@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCHv2 00/12] Implement V4L2_BUF_FLAG_NO_CACHE_* flags
Date: Wed, 26 Feb 2020 20:20:04 +0900 [thread overview]
Message-ID: <20200226112004.GH122464@google.com> (raw)
In-Reply-To: <35d43107-3c1c-3bf8-20e5-6569605643c3@xs4all.nl>
On (20/02/19 09:53), Hans Verkuil wrote:
[..]
> This is starting to look pretty good. I think you can drop the RFC
> for the next time you post this.
OK!
> One thing I would like to see as well is test code in v4l2-compliance,
> specifically for testing the various flags and capabilities. I.e.,
> if V4L2_BUF_CAP_SUPPORTS_CACHE_HINTS, then it should test that it can
> set the cache flags and the NON_CONSISTENT flag. If it is not set,
> then those flags should be cleared when attempting to set them.
>
> Also code in v4l2-ctl and common/v4l2-info.cpp to support the new
> flags, both reporting them, but also setting them.
I do have two trivial patches - "sync videobuf kernel header"
and "add new capability to common/v4l2-info.cpp".
But v4l2-ctl and v4l2-compliance will require much more time,
I think. So I, hopefully, will do it sometime later.
-ss
prev parent reply other threads:[~2020-02-26 11:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 2:56 [RFC][PATCHv2 00/12] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Sergey Senozhatsky
2020-02-04 2:56 ` [RFC][PATCHv2 01/12] videobuf2: add cache management members Sergey Senozhatsky
2020-02-19 8:05 ` Hans Verkuil
2020-02-19 8:16 ` Sergey Senozhatsky
2020-02-19 8:27 ` Hans Verkuil
2020-02-04 2:56 ` [RFC][PATCHv2 02/12] videobuf2: handle V4L2 buffer cache flags Sergey Senozhatsky
2020-02-05 8:13 ` Sergey Senozhatsky
2020-02-19 8:07 ` Hans Verkuil
2020-02-19 8:13 ` Sergey Senozhatsky
2020-02-19 8:25 ` Hans Verkuil
2020-02-19 8:46 ` Hans Verkuil
2020-02-04 2:56 ` [RFC][PATCHv2 03/12] videobuf2: add V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-02-13 7:08 ` Tomasz Figa
2020-02-19 8:19 ` Hans Verkuil
2020-02-19 8:56 ` Hans Verkuil
2020-02-25 7:45 ` Sergey Senozhatsky
2020-02-04 2:56 ` [RFC][PATCHv2 04/12] videobuf2: add queue memory consistency parameter Sergey Senozhatsky
2020-02-04 2:56 ` [RFC][PATCHv2 05/12] videobuf2: handle V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-02-19 8:25 ` Hans Verkuil
2020-02-19 8:59 ` Sergey Senozhatsky
2020-02-19 9:04 ` Hans Verkuil
2020-02-19 8:48 ` Hans Verkuil
2020-02-19 9:05 ` Sergey Senozhatsky
2020-02-19 9:11 ` Hans Verkuil
2020-02-04 2:56 ` [RFC][PATCHv2 06/12] videobuf2: factor out planes prepare/finish functions Sergey Senozhatsky
2020-02-04 2:56 ` [RFC][PATCHv2 07/12] videobuf2: do not sync caches when we are allowed not to Sergey Senozhatsky
2020-02-04 2:56 ` [RFC][PATCHv2 08/12] videobuf2: check ->synced flag in prepare() and finish() Sergey Senozhatsky
2020-02-04 2:56 ` [RFC][PATCHv2 09/12] videobuf2: let user-space know if driver supports cache hints Sergey Senozhatsky
2020-02-19 8:33 ` Hans Verkuil
2020-02-19 8:45 ` Sergey Senozhatsky
2020-02-19 8:56 ` Hans Verkuil
2020-02-04 2:56 ` [RFC][PATCHv2 10/12] videobuf2: add begin/end cpu_access callbacks to dma-contig Sergey Senozhatsky
2020-02-04 2:56 ` [RFC][PATCHv2 11/12] videobuf2: add begin/end cpu_access callbacks to dma-sg Sergey Senozhatsky
2020-02-19 8:35 ` Hans Verkuil
2020-02-19 8:42 ` Sergey Senozhatsky
2020-02-04 2:56 ` [RFC][PATCHv2 12/12] videobuf2: don't test db_attach in dma-contig prepare and finish Sergey Senozhatsky
2020-02-19 8:53 ` [RFC][PATCHv2 00/12] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Hans Verkuil
2020-02-26 11:20 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226112004.GH122464@google.com \
--to=senozhatsky@chromium.org \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=posciak@chromium.org \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).