From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sean Young <sean@mess.org>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v4l-utils] Fix build failure on s390x
Date: Wed, 26 Feb 2020 17:46:58 +0200 [thread overview]
Message-ID: <20200226154657.GM5023@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20200216091839.31183-1-sean@mess.org>
Hi Sean,
On Sun, Feb 16, 2020 at 09:18:39AM +0000, Sean Young wrote:
> See: https://bugzilla.redhat.com/show_bug.cgi?id=1800228
>
> /usr/bin/ld: .libs/libdvbv5_la-dvb-fe.o:(.bss+0x8): multiple definition of `delivery_system_name'; .libs/libdvbv5_la-dvb-v5.o:/builddir/build/BUILD/v4l-utils-1.18.0/lib/libdvbv5/dvb-v5.h:29: first defined here
> /usr/bin/ld: .libs/libdvbv5_la-dvb-fe.o:(.bss+0xa8): multiple definition of `dvb_v5_name'; .libs/libdvbv5_la-dvb-v5.o:/builddir/build/BUILD/v4l-utils-1.18.0/lib/libdvbv5/dvb-v5.h:28: first defined here
> /usr/bin/ld: .libs/libdvbv5_la-dvb-fe.o:(.rodata+0x3ec): multiple definition of `fe_bandwidth_name'; .libs/libdvbv5_la-dvb-v5.o:/builddir/build/BUILD/v4l-utils-1.18.0/lib/libdvbv5/dvb-v5.h:20: first defined here
>
> delivery_system_name etc are being defined both in lib/libdvbv5/dvb-v5.c and
> lib/libdvbv5/dvb-v5.h.
>
> Signed-off-by: Sean Young <sean@mess.org>
> ---
> lib/libdvbv5/gen_dvb_structs.pl | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/libdvbv5/gen_dvb_structs.pl b/lib/libdvbv5/gen_dvb_structs.pl
> index 7e1d645c..d15d1fc3 100755
> --- a/lib/libdvbv5/gen_dvb_structs.pl
> +++ b/lib/libdvbv5/gen_dvb_structs.pl
> @@ -419,6 +419,9 @@ sub output_arrays($$$$$)
> }
> printf OUT " %s[%i]", $name, $size;
> } else {
> + if ($decl) {
> + printf OUT "extern ";
> + }
> printf OUT "const %s%s[%i]", $type, $name, $size + 1;
> }
>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
prev parent reply other threads:[~2020-02-26 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 9:18 [PATCH v4l-utils] Fix build failure on s390x Sean Young
2020-02-26 15:46 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226154657.GM5023@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).