From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5643DC4BA13 for ; Wed, 26 Feb 2020 15:49:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 361C820637 for ; Wed, 26 Feb 2020 15:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728377AbgBZPtU (ORCPT ); Wed, 26 Feb 2020 10:49:20 -0500 Received: from retiisi.org.uk ([95.216.213.190]:46210 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728244AbgBZPtU (ORCPT ); Wed, 26 Feb 2020 10:49:20 -0500 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 24F67634C87; Wed, 26 Feb 2020 17:48:07 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1j6yut-0002Ki-NW; Wed, 26 Feb 2020 17:48:07 +0200 Date: Wed, 26 Feb 2020 17:48:07 +0200 From: Sakari Ailus To: Eugen Hristev Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: v4l2-core: fix entity initialization in device_register_subdev Message-ID: <20200226154807.GN5023@valkosipuli.retiisi.org.uk> References: <20200226152816.31557-1-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226152816.31557-1-eugen.hristev@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Feb 26, 2020 at 05:28:16PM +0200, Eugen Hristev wrote: > The entity variable was being initialized in the wrong place, before the > parameters have been checked. > To solve this, completely removed the entity variable and replaced it > with the initialization value : &sd->entity. > This will avoid dereferencing 'sd' pointer before it's being checked if > it's NULL. > > Fixes: 61f5db549dde ("[media] v4l: Make v4l2_subdev inherit from media_entity") > Signed-off-by: Eugen Hristev Thanks! Acked-by: Sakari Ailus -- Sakari Ailus