From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Andrey Konovalov <andrey.konovalov@linaro.org>
Cc: mchehab@kernel.org, sakari.ailus@iki.fi,
linux-media@vger.kernel.org, peter.griffin@linaro.org
Subject: Re: [PATCH 2/3] media: i2c: imx290: fix the order of the args in SET_RUNTIME_PM_OPS()
Date: Tue, 3 Mar 2020 15:09:46 +0530 [thread overview]
Message-ID: <20200303093946.GB16981@mani> (raw)
In-Reply-To: <20200226215913.10631-3-andrey.konovalov@linaro.org>
On Thu, Feb 27, 2020 at 12:59:12AM +0300, Andrey Konovalov wrote:
> This macro is defined as SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn),
> so imx290_power_off must be the 1st arg, and imx290_power_on the 2nd.
>
Oops. That's a mistake.
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/media/i2c/imx290.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 2d8c38ffe2f0..d0322f9a8856 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -648,7 +648,7 @@ static int imx290_power_off(struct device *dev)
> }
>
> static const struct dev_pm_ops imx290_pm_ops = {
> - SET_RUNTIME_PM_OPS(imx290_power_on, imx290_power_off, NULL)
> + SET_RUNTIME_PM_OPS(imx290_power_off, imx290_power_on, NULL)
> };
>
> static const struct v4l2_subdev_video_ops imx290_video_ops = {
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-03-03 9:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 21:59 [PATCH 0/3] IMX290 sensor driver fixes Andrey Konovalov
2020-02-26 21:59 ` [PATCH 1/3] media: i2c: imx290: set the format before VIDIOC_SUBDEV_G_FMT is called Andrey Konovalov
2020-03-03 9:30 ` Manivannan Sadhasivam
2020-02-26 21:59 ` [PATCH 2/3] media: i2c: imx290: fix the order of the args in SET_RUNTIME_PM_OPS() Andrey Konovalov
2020-03-03 9:39 ` Manivannan Sadhasivam [this message]
2020-02-26 21:59 ` [PATCH 3/3] media: i2c: imx290: fix reset GPIO pin handling Andrey Konovalov
2020-03-03 11:33 ` Manivannan Sadhasivam
2020-04-07 8:19 ` [PATCH 0/3] IMX290 sensor driver fixes Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303093946.GB16981@mani \
--to=manivannan.sadhasivam@linaro.org \
--cc=andrey.konovalov@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peter.griffin@linaro.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).