From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58CBDC18E5B for ; Wed, 25 Mar 2020 08:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E23620722 for ; Wed, 25 Mar 2020 08:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585126784; bh=cOn4xweSXTjnIBdVVy7zlvAJx1b+MPNOhF7f/SvJVtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ze7+jdO57ckiddnY13l3gV0JuDHM5RhTGynTffZO/RuGoK6RKUDTM/FvNL3mZx3vr 5FmUVZQOU5wdXK8GEnNnhlNF+oWBPq0NlO/3bX6aXOMyoNLVt1urAR4OCRAGTeRa6n jKGo3NA6/OVDIR8mfGMl2VkJVYk2gbu/FVIZs7ek= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727360AbgCYI7l (ORCPT ); Wed, 25 Mar 2020 04:59:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:44788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbgCYI7k (ORCPT ); Wed, 25 Mar 2020 04:59:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC28320663; Wed, 25 Mar 2020 08:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585126780; bh=cOn4xweSXTjnIBdVVy7zlvAJx1b+MPNOhF7f/SvJVtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xQC5Ih3hLcbZJRHGtrKpb8yn1ichnhGO1RqPmWYrlqvsm9829JJgzDLGTSNVjcWWa I40Wh6XsucAcBLauxgR6yogL5mBCB04aZtY4skOD1t25Fhbr5yKQH4ViMUvVQixQSd w7U5G2kKkCu600AcV10hIUPiV9c7E3DNgqxa+FCA= Date: Wed, 25 Mar 2020 09:59:36 +0100 From: Greg KH To: Seungchul Kim Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: v4l2-fh: define v4l2_fh struct regardless of condition Message-ID: <20200325085936.GA3072245@kroah.com> References: <000601d600bb$0e2d4320$2a87c960$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000601d600bb$0e2d4320$2a87c960$@samsung.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Mar 23, 2020 at 11:30:45AM +0900, Seungchul Kim wrote: > v4l2_fh struct define differently by CONFIG_V4L2_MEM2MEM_DEV. > If some vendors use CONFIG_V4L2_MEM2MEM_DEV by module, it can make the > mismatch of v4l2_fh sturct. > > By the mismatch, the following error occurs. > =============================== > [ 7.533506] v4l2_mem2mem: disagrees about version of symbol video_devdata > [ 7.533594] v4l2_mem2mem: Unknown symbol video_devdata (err -22) > [ 7.535319] v4l2_mem2mem: disagrees about version of symbol > v4l2_event_pending > [ 7.542532] v4l2_mem2mem: Unknown symbol v4l2_event_pending (err -22) > =============================== > > So v4l2_fh struct is modified to does not have dependency for > CONFIG_V4L2_MEM2MEM_DEV. > > Signed-off-by: Seungchul Kim > --- > include/media/v4l2-fh.h | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Greg Kroah-Hartman