From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Guillaume La Roque <glaroque@baylibre.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lee Jones <lee.jones@linaro.org>,
linux-clk@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Zhang Rui <rui.zhang@intel.com>,
Brian Masney <masneyb@onstation.org>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-gpio@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-amlogic@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Stephen Boyd <sboyd@kernel.org>,
netdev@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-media@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: iio/accel: Drop duplicate adi, adxl345/6 from trivial-devices.yaml
Date: Fri, 27 Mar 2020 21:21:59 +0100 [thread overview]
Message-ID: <20200327202159.GA12749@ravnborg.org> (raw)
In-Reply-To: <20200325220542.19189-2-robh@kernel.org>
Hi Rob.
On Wed, Mar 25, 2020 at 04:05:38PM -0600, Rob Herring wrote:
> The 'adi,adxl345' definition is a duplicate as there's a full binding in:
> Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
>
> The trivial-devices binding doesn't capture that 'adi,adxl346' has a
> fallback compatible 'adi,adxl345', so let's add it to adi,adxl345.yaml.
>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 10 +++++++---
> Documentation/devicetree/bindings/trivial-devices.yaml | 4 ----
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> index c602b6fe1c0c..d124eba1ce54 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> @@ -17,9 +17,13 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - adi,adxl345
> - - adi,adxl375
> + oneOf:
> + - items:
> + - const: adi,adxl346
> + - const: adi,adxl345
> + - enum:
> + - adi,adxl345
> + - adi,adxl375
I assume it is my schema understanding that is poor.
But I cannot parse the above.
The mix of items, enum and const confuses me.
I guess that if I am confused then others may end in the same situation.
Can we improve readability here or amybe add a comment?
Sam
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 978de7d37c66..51d1f6e43c02 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -42,10 +42,6 @@ properties:
> - adi,adt7476
> # +/-1C TDM Extended Temp Range I.C
> - adi,adt7490
> - # Three-Axis Digital Accelerometer
> - - adi,adxl345
> - # Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
> - - adi,adxl346
> # AMS iAQ-Core VOC Sensor
> - ams,iaq-core
> # i2c serial eeprom (24cxx)
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-27 20:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 22:05 [PATCH 0/4] dt-bindings: additionalProperties clean-up Rob Herring
2020-03-25 22:05 ` [PATCH 1/4] dt-bindings: iio/accel: Drop duplicate adi,adxl345/6 from trivial-devices.yaml Rob Herring
2020-03-26 7:57 ` Ardelean, Alexandru
2020-03-27 20:21 ` Sam Ravnborg [this message]
2020-03-31 14:48 ` [PATCH 1/4] dt-bindings: iio/accel: Drop duplicate adi, adxl345/6 " Rob Herring
2020-03-25 22:05 ` [PATCH 2/4] dt-bindings: sram: qcom: Clean-up 'ranges' and child node names Rob Herring
2020-03-25 23:34 ` Brian Masney
2020-03-25 22:05 ` [PATCH 3/4] dt-bindings: Clean-up schema errors due to missing 'addtionalProperties: false' Rob Herring
2020-03-26 7:58 ` Ardelean, Alexandru
2020-03-26 8:39 ` Neil Armstrong
2020-03-26 12:45 ` Jonathan Cameron
2020-03-27 8:32 ` Lee Jones
2020-03-27 9:59 ` Linus Walleij
2020-03-30 7:10 ` Masahiro Yamada
2020-03-25 22:05 ` [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' Rob Herring
2020-03-25 22:07 ` Mark Brown
2020-03-26 8:07 ` Ardelean, Alexandru
2020-03-26 8:37 ` Neil Armstrong
2020-03-26 12:47 ` Jonathan Cameron
2020-03-26 13:27 ` Benjamin Gaignard
2020-03-27 8:31 ` Lee Jones
2020-03-30 7:09 ` Masahiro Yamada
2020-03-30 8:37 ` Masahiro Yamada
2020-03-31 14:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327202159.GA12749@ravnborg.org \
--to=sam@ravnborg.org \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=glaroque@baylibre.com \
--cc=jic23@kernel.org \
--cc=khilman@baylibre.com \
--cc=knaack.h@gmx.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=mchehab@kernel.org \
--cc=michael.hennerich@analog.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).