From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D2BC43331 for ; Thu, 2 Apr 2020 15:03:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A78FA206CC for ; Thu, 2 Apr 2020 15:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389069AbgDBPDZ (ORCPT ); Thu, 2 Apr 2020 11:03:25 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:57337 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388744AbgDBPDZ (ORCPT ); Thu, 2 Apr 2020 11:03:25 -0400 Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MybX9-1j7PZQ1xzp-00z00b; Thu, 02 Apr 2020 17:03:09 +0200 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id 097A0650AA7; Thu, 2 Apr 2020 15:03:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qP8o4QmZzMyZ; Thu, 2 Apr 2020 17:03:07 +0200 (CEST) Received: from pflmari.corp.cetitec.com (unknown [10.8.5.56]) by mail.cetitecgmbh.com (Postfix) with ESMTPS id 9404064C938; Thu, 2 Apr 2020 17:03:07 +0200 (CEST) Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id 68B12804FB; Thu, 2 Apr 2020 16:16:54 +0200 (CEST) Date: Thu, 2 Apr 2020 16:16:54 +0200 From: Alex Riesen To: Geert Uytterhoeven Cc: Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Linux-Renesas Subject: Re: [PATCH v4 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Message-ID: <20200402141654.GB4291@pflmari> Mail-Followup-To: Alex Riesen , Geert Uytterhoeven , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Linux-Renesas References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:Is5uJxMg3JOTXfihWmw/yAJXlIzEj/786Ut3euQGsigzUph1yio H5V1cBF7XgZEEeI7WsFwuZTxP2E6Hj6azmNrJh9qwFSuXDZ+zCCP81RCQlmSPJla0Sr6IY6 QSzQfPaUUl+mZtQjwdOV8zhedWfwf9gToq+Iv9Gat4KWV8g7VMTdPkti9uvTMfDtvqBdOTd PDGuW+kIr2pCE6T9+kHjg== X-UI-Out-Filterresults: notjunk:1;V03:K0:FPfBvf1WZKE=:2e0MwuWr49u0npND5T8YEM fXabhm3nmxL2DQkHlFFAFd/AZJcQQiHJROAR+13cGIK/BQ/5L5fhbKsr7QiYNSbpyhGhT1ZXC DruPJmtG+lW129VEWTRpAKIV5wDbNozyUjfNELnMLoLiIgZrFxhzuYtOI4hT+pTegAreOtXuY YfcTsBxuvY4dba3wKL2aYMR5m8DUoCn2hdNWbACXx4muJNO+uRItRcQSWagsMF3DlswZ5+Us2 B0+yMDRs7PtQd3w0V3y33k3JPgrBXnZ4w558yfeHQLg4kIWRIHpFhFo8ChpuzQWXxM2F0vQlv HtSDfCZITzq7skt8OyjiMW/jnep2ho+Z9HY1Lxic6ZaS/c1oKGfmYEsa5yjLRoTRUFPiYRFGS 4eWSizLGLgXzJCKL4UZjwwOQQo8F9tKigOvvEkmQqZszuPk2XWOxoop+EHnYkilEOa1eCL4sN axL1Vs/QBvg0L3KWDLUSBXyuPLu1Rafzc9r5rXt+ffN/w75EG6YkVVacAiZC3sBbn4PsgddkC uqAdlMvF1MSmd8W8OaNN1yeN3JuYYF4XRosNbKHSTjriS7k/zZvLxcWpWaZSh+szMs62045IH 8VBAbwU/Wxez46XOtQkuodomLlPQ/dUWP7rllc2j8+g4nBltzexHbEmghcrGNssSjZT/zum// 2jEC3qaNRVnKT06kQAI/jRiueES0WlRUmPhUre8tZGmxjSssxMHxNw5UWej9WOECkNcm3p8u4 Yl88JIj+7JtrYyzm88d18pAMmJkOZHw1SaJDqUVASOi5RnYxHDytRQaYe/XrkIqzmlwid6o0T NeU6XqJ/1T6H0LTy6Lk4ke+UK68Rywv87xDbbBW0VOB/RHYoGHeNaIxr4Dl/Nmq4ENHwMYk Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Geert, I'm sorry for late reply. Some unrelated happenings here in south Germany. Geert Uytterhoeven, Mon, Mar 30, 2020 10:32:47 +0200: > On Thu, Mar 26, 2020 at 11:55 AM Alex Riesen wrote: > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > @@ -510,6 +511,15 @@ adv7482_txb: endpoint { > > remote-endpoint = <&csi20_in>; > > }; > > }; > > + > > + port@c { > > + reg = <12>; > > + > > + adv7482_i2s: endpoint { > > + remote-endpoint = <&rsnd_endpoint3>; > > + system-clock-direction-out; > > + }; > > + }; > > As the adv748x driver just ignores "invalid" endpoints... > > > @@ -758,8 +769,19 @@ &rcar_sound { > > <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, > > <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, > > <&audio_clk_a>, <&cs2000>, > > - <&audio_clk_c>, > > + <&adv7482_hdmi_in>, > > <&cpg CPG_CORE CPG_AUDIO_CLK_I>; > > ... and the rsnd driver ignores nonexistent-clocks, the DT change has no > hard dependency on the driver change, and won't introduce regressions > when included, right? Well, it maybe won't, but isn't it a little ... implicit? And I'm no haste to include the changes, if you mean I can (or should) submit the device tree patch separately. > > @@ -777,6 +799,21 @@ rsnd_endpoint0: endpoint { > > capture = <&ssi1 &src1 &dvc1>; > > }; > > }; > > + rsnd_port3: port@3 { > > + reg = <3>; > > + rsnd_endpoint3: endpoint { > > + remote-endpoint = <&adv7482_i2s>; > > + > > + dai-tdm-slot-num = <8>; > > + dai-tdm-slot-width = <32>; > > + dai-format = "left_j"; > > + mclk-fs = <256>; > > + bitclock-master = <&adv7482_i2s>; > > + frame-master = <&adv7482_i2s>; > > + > > + capture = <&ssi4>; > > + }; > > + }; > > }; > > }; > > However, as salvator-common.dtsi is shared by all Salvator-X(S) variants, > you'll have to add a dummy ssi4 node to r8a77961.dtsi first. I see. There are even two dummy SSI nodes already. I would prefer to submit the change together with other Salvator device tree changes. Is that alright? Regards, Alex