From: Rob Herring <robh@kernel.org>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mchehab@kernel.org, andriy.shevchenko@linux.intel.com,
mark.rutland@arm.com, sakari.ailus@linux.intel.com,
drinkcat@chromium.org, tfiga@chromium.org,
matthias.bgg@gmail.com, bingbu.cao@intel.com,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
louis.kuo@mediatek.com, shengnan.wang@mediatek.com
Subject: Re: [V4, 1/2] media: i2c: dw9768: Add DT support and MAINTAINERS entry
Date: Fri, 10 Apr 2020 12:25:27 -0500 [thread overview]
Message-ID: <20200410172527.GA24529@bogus> (raw)
In-Reply-To: <20200330123634.363-2-dongchun.zhu@mediatek.com>
On Mon, Mar 30, 2020 at 08:36:33PM +0800, Dongchun Zhu wrote:
> This patch is to add the Devicetreee binding documentation and
> MAINTAINERS entry for dw9768 actuator.
>
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
> .../bindings/media/i2c/dongwoon,dw9768.yaml | 62 ++++++++++++++++++++++
> MAINTAINERS | 7 +++
> 2 files changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
> new file mode 100644
> index 0000000..8a353dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) 2020 MediaTek Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9768.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dongwoon Anatech DW9768 Voice Coil Motor (VCM) Device Tree Bindings
> +
> +maintainers:
> + - Dongchun Zhu <dongchun.zhu@mediatek.com>
> +
> +description: |-
> + The Dongwoon DW9768 is a single 10-bit digital-to-analog (DAC) converter
> + with 100 mA output current sink capability. VCM current is controlled with
> + a linear mode driver. The DAC is controlled via a 2-wire (I2C-compatible)
> + serial interface that operates at clock rates up to 1MHz. This chip
> + integrates Advanced Actuator Control (AAC) technology and is intended for
> + driving voice coil lenses in camera modules.
> +
> +properties:
> + compatible:
> + const: dongwoon,dw9768
> +
> + reg:
> + maxItems: 1
> +
> + vin-supply:
> + description:
> + Definition of the regulator used as I2C I/O interface power supply.
> + maxItems: 1
You can drop this. *-supply is always a single entry.
> +
> + vdd-supply:
> + description:
> + Definition of the regulator used as VCM chip power supply.
> + maxItems: 1
Same here.
> +
> +required:
> + - compatible
> + - reg
> + - vin-supply
> + - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c2: i2c@11009000 {
i2c {
> + clock-frequency = <400000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dw9768: camera-lens@c {
> + compatible = "dongwoon,dw9768";
> + reg = <0x0c>;
> +
> + vin-supply = <&mt6358_vcamio_reg>;
> + vdd-supply = <&mt6358_vcama2_reg>;
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 38fe2f3..5e124d2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5134,6 +5134,13 @@ S: Maintained
> F: drivers/media/i2c/dw9714.c
> F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt
>
> +DONGWOON DW9768 LENS VOICE COIL DRIVER
> +M: Dongchun Zhu <dongchun.zhu@mediatek.com>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +T: git git://linuxtv.org/media_tree.git
> +F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml
> +
> DONGWOON DW9807 LENS VOICE COIL DRIVER
> M: Sakari Ailus <sakari.ailus@linux.intel.com>
> L: linux-media@vger.kernel.org
> --
> 2.9.2
next prev parent reply other threads:[~2020-04-10 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 12:36 [V4, 0/2] media: i2c: add support for DW9768 VCM driver Dongchun Zhu
2020-03-30 12:36 ` [V4, 1/2] media: i2c: dw9768: Add DT support and MAINTAINERS entry Dongchun Zhu
2020-04-10 17:25 ` Rob Herring [this message]
2020-04-30 8:42 ` Dongchun Zhu
2020-03-30 12:36 ` [V4, 2/2] media: i2c: Add DW9768 VCM driver Dongchun Zhu
2020-03-30 13:57 ` Andy Shevchenko
2020-03-31 2:16 ` Dongchun Zhu
2020-03-31 10:14 ` Andy Shevchenko
2020-04-30 8:47 ` Dongchun Zhu
2020-04-02 12:32 ` Sakari Ailus
2020-04-30 10:15 ` Dongchun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410172527.GA24529@bogus \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).