From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Francescodario Cuzzocrea <francescodario.cuzzocrea@mail.polimi.it>
Cc: "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gnomes@lxorguk.ukuu.org.uk" <gnomes@lxorguk.ukuu.org.uk>,
"alan@linux.intel.com" <alan@linux.intel.com>
Subject: Re: [GIT PULL] Ressurect the atomisp staging driver
Date: Sun, 3 May 2020 12:07:14 +0200 [thread overview]
Message-ID: <20200503120714.28f62360@coco.lan> (raw)
In-Reply-To: <3f551a8f87808ee7828dc03d41c7a23faac89f3c.camel@mail.polimi.it>
Hi Francescodario,
Em Sun, 3 May 2020 09:19:55 +0000
Francescodario Cuzzocrea <francescodario.cuzzocrea@mail.polimi.it> escreveu:
> Hi !
>
> Thanks for this, it is very appreciated !!
>
> I have a bay trail 2in1 (namely, the acer aspire swtich 10 sw5-012,
> with an OV2722 module, so supported by the driver) on top of which I
> run android-x86-q so I would be able to help a bit with testing the
> driver.
>
> I tried to pull in your changes on top of my 5.7-rc2 here :
> https://gitlab.com/lineageos-x86/android_kernel_common/-/commits/5.7-media
>
> but I did not understood how to correctly enable the driver.
> According
> to Kconfig help, there is still the hardcoded switch between ISP2401
> and ISP2400, so for my Bay Trail tablet I should set :
>
> #
> CONFIG_VIDEO_ATOMISP_ISP2401 is not set
>
> but settings this breaks compilation with :
>
> ERROR: modpost:
> "ia_css_configure_sc"[drivers/staging/media/atomisp/atomisp.ko]
> undefined!
I'll double check and address this issue.
>
> Looking at commit history, I noticed that the driver should be able to
> recognize at runtime the ISP version,
Not yet. There are simply too many places there with checks for ISP2400
or ISP2401. I got rid of most of them, but there are 4 header files
that contain ISP-version specific information, whose are used by several
parts of the driver. Getting rid of it would require more work.
> so what I tried next was to set
> CONFIG_VIDEO_ATOMISP_ISP2401=y, and the compilation went fine.
> I was able to boot the kernel (and I also added both
> shisp_2400b0_v21.bin and shisp_2401a0_v21.bin from an android tablet
> dump).
>
> The kernel booted fine, the ov2722 module is loaded, but according to
> dmesg it is not able to initialize the hardware :
> https://pastebin.com/VBMD1bau
(transcribing the relevant messages from pastebin below)
> ov2722 i2c-INT33FB: 00: gmin: initializing atomisp module subdev data.PMIC ID 1
> ov2722 i2c-INT33FB: 00: supply V1P2A not found, using dummy regulator
> ov2722 i2c-INT33FB: 00: supply VPROG4B not found, using dummy regulator
> ov2722 i2c-INT33FB: 00: supply Regulator1p8v not found, using dummy regulator
> ov2722 i2c-INT33FB: 00: supply Regulator2p8v not found, using dummy regulator
> ov2722 i2c-INT33FB: 00: unable to set PMC rate 1
> ov2722 i2c-INT33FB: 00: camera pdata: port: 0 lanes: 1 order: 00000000
> ov2722 i2c-INT33FB: 00: read from offset 0x300a error -121
> ov2722 i2c-INT33FB: 00: sensor_id_high = 0xffff
> ov2722 i2c-INT33FB: 00: ov2722_detect err s_config.
> ov2722 i2c-INT33FB: 00: sensor power-gating failed
That's the same that happened with the tests we've done so far:
it is not finding the regulators. I'm currently seeking for a solution
to that.
Usually, regulator data comes via OpenFirmware/Device Tree.
However, ACPI BIOS store this on a different way. Some (missing) code
would need to get the relevant parameters from the BIOS and setup
the regulators.
Btw, could you please send me a tarball with the output of your
BIOS ACPI tables?
You can get it with:
$ sudo acpidump |bzip2 > acpi.log.bz2
Thanks,
Mauro
next prev parent reply other threads:[~2020-05-03 10:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 19:57 [GIT PULL] Ressurect the atomisp staging driver Mauro Carvalho Chehab
2020-05-02 6:03 ` Greg KH
2020-05-20 7:48 ` Mauro Carvalho Chehab
2020-05-03 9:19 ` Francescodario Cuzzocrea
2020-05-03 10:07 ` Mauro Carvalho Chehab [this message]
2020-05-03 15:32 ` Mauro Carvalho Chehab
[not found] ` <CADnVkj96W0QfthukTKQ0a-i2fH1buooH3BEgfy22J9H9=_PcKA@mail.gmail.com>
2020-05-03 16:07 ` Patrik Gfeller
2020-05-04 8:16 ` Patrik Gfeller
2020-05-04 8:49 ` Mauro Carvalho Chehab
2020-05-04 10:45 ` Patrik Gfeller
2020-05-04 12:08 ` Mauro Carvalho Chehab
2020-05-04 13:44 ` Patrik Gfeller
2020-05-15 8:32 ` Mauro Carvalho Chehab
2020-05-15 9:10 ` Hans de Goede
2020-05-15 9:42 ` Mauro Carvalho Chehab
2020-05-19 7:39 ` Mauro Carvalho Chehab
2020-05-19 17:36 ` Mauro Carvalho Chehab
2020-05-22 10:46 ` Hans de Goede
2020-05-22 11:42 ` Mauro Carvalho Chehab
2020-05-23 8:00 ` Mauro Carvalho Chehab
2020-05-27 16:23 ` Hans de Goede
2020-05-27 17:36 ` Mauro Carvalho Chehab
2020-05-15 9:37 ` Ressurect the atomisp staging driver - current progress Mauro Carvalho Chehab
2020-05-06 15:10 ` [GIT PULL] Ressurect the atomisp staging driver Mauro Carvalho Chehab
2020-05-03 9:23 ` bosconovic
2020-05-16 13:23 [GIT,PULL] " Finn Rayment
[not found] ` <20200516115459.4a24063b@coco.lan>
2020-05-16 19:53 ` Finn Rayment
2020-05-19 17:37 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503120714.28f62360@coco.lan \
--to=mchehab@kernel.org \
--cc=alan@linux.intel.com \
--cc=francescodario.cuzzocrea@mail.polimi.it \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).