From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
linaro-mm-sig@lists.linaro.org,
Daniel Vetter <daniel.vetter@intel.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] dma-fence: use default wait function for mock fences
Date: Mon, 11 May 2020 12:12:02 +0200 [thread overview]
Message-ID: <20200511101202.GB206103@phenom.ffwll.local> (raw)
In-Reply-To: <158919006380.1729.6928823811672806738@build.alporthouse.com>
On Mon, May 11, 2020 at 10:41:03AM +0100, Chris Wilson wrote:
> Quoting Daniel Vetter (2020-05-11 10:11:41)
> > No need to micro-optmize when we're waiting in a mocked object ...
>
> It's setting up the expected return values for the test.
Drat, I suspect something like that but didn't spot it. Kinda wondering
whether we should maybe lift the -ETIME special case to the generic
version. But that's not really a safe thing to do there, drivers might
actually use it for funny stuff.
Anyway motivation is that I'm pondering some extensions of dma_fence_wait
and removing as many of the ->wait hooks as possible would have helped.
But there's some nastier stuff like the legacy nouvea and radeon ones.
-Daniel
next prev parent reply other threads:[~2020-05-11 10:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200511091142.208787-1-daniel.vetter@ffwll.ch>
2020-05-11 9:11 ` [PATCH 2/3] dma-fence: use default wait function for mock fences Daniel Vetter
2020-05-11 9:41 ` Chris Wilson
2020-05-11 10:12 ` Daniel Vetter [this message]
2020-05-11 18:13 ` [Intel-gfx] " Ruhl, Michael J
2020-05-11 18:17 ` Ruhl, Michael J
2020-05-11 9:11 ` [PATCH 3/3] misc/habalabs: don't set default fence_ops->wait Daniel Vetter
2020-05-11 9:36 ` Oded Gabbay
2020-05-11 9:43 ` Oded Gabbay
2020-05-12 2:14 ` [Intel-gfx] " Dave Airlie
2020-05-12 6:12 ` Daniel Vetter
2020-05-14 11:38 ` Oded Gabbay
2020-05-20 18:04 ` Daniel Vetter
2020-05-20 18:09 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511101202.GB206103@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).