From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: linux-media@vger.kernel.org, dafna.hirschfeld@collabora.com,
helen.koike@collabora.com, ezequiel@collabora.com,
hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com,
sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org,
mchehab@kernel.org, laurent.pinchart@ideasonboard.com
Subject: [PATCH v2 0/4] media: staging: rkisp1: various fixes to capture formats
Date: Fri, 15 May 2020 16:29:48 +0200 [thread overview]
Message-ID: <20200515142952.20163-1-dafna.hirschfeld@collabora.com> (raw)
This patchset fixes some issues in the supported capture formats
of rkisp1.
Patches Summary:
1. Replaces the format V4L2_PIX_FMT_RGB24 with format V4L2_PIX_FMT_XBGR32 which
is the format the device supports.
2. Uses the vdiv, hdiv of the yuv422 explicitly instead of defining macros.
This is a cleanup patch to make it clear where those values are taken from.
3. In case of YUV444 format, the memory input format should stay YUV422
and not be converted by the resizer. This patch fixes it
4. remove support of BGR666 format since it is not supported by the device.
The fixes to formats V4L2_PIX_FMT_XBGR32, V4L2_PIX_FMT_YUV444M
were tested.
Changes from v1:
In v1 I sent a single patch
"media: staging: rkisp1: cap: change RGB24 format to XBGR32"
This patchset reword the commit log of that patch and includes
the 3 other patches.
Dafna Hirschfeld (4):
media: staging: rkisp1: cap: change RGB24 format to XBGR32
media: staging: rkisp1: rsz: use hdiv, vdiv of yuv422 instead of
macros
media: staging: rkisp1: rsz: set output format to YUV422 if cap format
is YUV444
media: staging: rkisp1: cap: remove support of BGR666 format
drivers/staging/media/rkisp1/rkisp1-capture.c | 6 +---
drivers/staging/media/rkisp1/rkisp1-resizer.c | 28 +++++++++----------
2 files changed, 15 insertions(+), 19 deletions(-)
--
2.17.1
next reply other threads:[~2020-05-15 14:30 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:29 Dafna Hirschfeld [this message]
2020-05-15 14:29 ` [PATCH v2 1/4] media: staging: rkisp1: cap: change RGB24 format to XBGR32 Dafna Hirschfeld
2020-05-20 21:50 ` Helen Koike
2020-05-26 23:04 ` Tomasz Figa
2020-06-10 16:11 ` Dafna Hirschfeld
2020-06-10 16:15 ` Tomasz Figa
2020-05-15 14:29 ` [PATCH v2 2/4] media: staging: rkisp1: rsz: use hdiv, vdiv of yuv422 instead of macros Dafna Hirschfeld
2020-05-20 21:54 ` Helen Koike
2020-05-20 22:08 ` Helen Koike
2020-05-22 12:11 ` Dafna Hirschfeld
2020-05-22 13:31 ` Ezequiel Garcia
2020-05-22 14:15 ` Dafna Hirschfeld
2020-05-22 15:04 ` Ezequiel Garcia
2020-05-25 9:51 ` Dafna Hirschfeld
2020-05-26 22:26 ` Tomasz Figa
2020-05-22 13:57 ` Laurent Pinchart
2020-05-22 14:54 ` Dafna Hirschfeld
2020-05-22 14:59 ` Laurent Pinchart
2020-06-10 16:36 ` Dafna Hirschfeld
2020-05-26 22:44 ` Tomasz Figa
2020-06-10 17:01 ` Dafna Hirschfeld
2020-06-10 17:08 ` Tomasz Figa
2020-05-15 14:29 ` [PATCH v2 3/4] media: staging: rkisp1: rsz: set output format to YUV422 if cap format is YUV444 Dafna Hirschfeld
2020-05-20 22:23 ` Helen Koike
2020-05-26 23:09 ` Tomasz Figa
2020-06-12 12:45 ` Dafna Hirschfeld
2020-06-18 17:47 ` Tomasz Figa
2020-06-18 18:00 ` Dafna Hirschfeld
2020-06-18 18:12 ` Tomasz Figa
2020-06-18 18:50 ` Dafna Hirschfeld
2020-06-18 19:18 ` Tomasz Figa
2020-06-19 7:30 ` Dafna Hirschfeld
2020-06-19 12:04 ` Tomasz Figa
2020-07-18 16:05 ` Dafna Hirschfeld
2020-05-15 14:29 ` [PATCH v2 4/4] media: staging: rkisp1: cap: remove support of BGR666 format Dafna Hirschfeld
2020-05-20 22:34 ` Helen Koike
2020-05-26 22:57 ` Tomasz Figa
2020-05-27 10:14 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515142952.20163-1-dafna.hirschfeld@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).