From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Bingbu Cao <bingbu.cao@intel.com>,
Tian Shu Qiu <tian.shu.qiu@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] media: ipu3: add a module to probe sensors via ACPI
Date: Sun, 17 May 2020 13:36:59 +0300 [thread overview]
Message-ID: <20200517103659.GS17578@paasikivi.fi.intel.com> (raw)
In-Reply-To: <12fbe3f5c6a16c5f3447adbc09fe27ceb2b16823.1589625807.git.mchehab+huawei@kernel.org>
Hi Mauro,
Thanks for the patch.
On Sat, May 16, 2020 at 12:43:39PM +0200, Mauro Carvalho Chehab wrote:
> On devices without ACPI, or which ACPI is not prepared to
> export sensor data via DT, we need a different probing
> method.
>
> This little driver adds initial support to probe the
> sensors found on a Dell Latitude 7285.
>
> For now, it just detects the hardware and use request_module()
> to load a sensor driver.
>
> In the specific case of this device, the ACPI DTST dable
> describes 2 camera sensors for this module, but the
> current upstream doesn't have yet drivers for such
> sensors. So, this patch just detects the PMIC used on
> this device and tries to load a sensor.
>
> Once the sensor gets added, some additional code will
> be needed to pass via platform_data other details, like
> callbacks for PMIC's command to turn the sensor on/off
> and other sensor-specific settings.
>
> The idea of this patch was inspired on how the sensors
> are probed by the staging atomisp driver.
>
> The current result of this driver with the Dell
> Latitude 7285 is:
>
> ipu3_acpi i2c-INT3477:00: ipu3_acpi_probe: ACPI detected it on bus ID=LNK1, HID=INT3477
> ipu3_acpi i2c-INT3477:00: Found DMI entry for 'Latitude 7285' with sensor INT3477
> ipu3_acpi i2c-INT3477:00: Loading sensor module ov8858
> ipu3_acpi i2c-OVTI9234:00: ipu3_acpi_probe: ACPI detected it on bus ID=LNK2, HID=OVTI9234
> ipu3_acpi i2c-OVTI9234:00: Found DMI entry for 'Latitude 7285' with sensor OVTI9234
> ipu3_acpi i2c-OVTI9234:00: Loading sensor module ov9234
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
...
> +/*
> + * Should list known sensor devices found at DSDT table as "CAM0", "CAM1", ...
> + *
> + * The table below is probably incomplete. It came from the DSDT table found
> + * at a Dell Latitude 7285 (Method HCID).
> + */
> +static const struct acpi_device_id ipu3_acpi_acpi_match[] = {
> + {"INT3471"},
> + {"INT33BE"},
> + {"INT3476"},
> + {"INT3477"},
> + {"INT3474"},
> + {"INT3473"},
> + {"INT3475"},
> + {"INT3478"},
> + {"INT3479"},
> + {"INT347A"},
> + {"INT347B"},
> + {"OVTI9234"},
> + {"OVTI9734"},
> + {"OVTI8856"},
> + {"OVTIF860"},
> + {},
> +};
> +MODULE_DEVICE_TABLE(acpi, ipu3_acpi_acpi_match);
Instead of creating a new way to probe drivers on ACPI systems, please add
the appropriate ACPI device IDs to the respective drivers. E.g.
drivers/media/i2c/imx319.c implements this.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2020-05-17 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 10:43 [PATCH] media: ipu3: add a module to probe sensors via ACPI Mauro Carvalho Chehab
2020-05-17 10:36 ` Sakari Ailus [this message]
2020-05-20 7:44 ` Mauro Carvalho Chehab
2020-05-20 8:26 ` Sakari Ailus
2020-05-20 11:18 ` Mauro Carvalho Chehab
2020-05-21 8:00 ` Andy Shevchenko
2020-05-22 9:57 ` Mauro Carvalho Chehab
2020-05-26 14:31 ` Heikki Krogerus
2020-07-01 1:16 ` Jordan Hand
2020-09-07 13:17 ` Dan Scally
2020-09-08 23:41 ` Dan Scally
2020-05-25 7:59 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517103659.GS17578@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).