Re: [PATCH] firewire: Remove function callback casts

From: Oscar Carter <oscar.carter@gmx.com>
To: "Lev R. Oshvang ." <levonshe@gmail.com>
Cc: Oscar Carter <oscar.carter@gmx.com>,
	Kees Cook <keescook@chromium.org>,
	Stefan Richter <stefanr@s5r6.in-berlin.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Clemens Ladisch <clemens@ladisch.de>,
	Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	kernel-hardening@lists.openwall.com,
	linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] firewire: Remove function callback casts
Date: Tue, 19 May 2020 18:59:11 +0200	[thread overview]
Message-ID: <20200519165910.GA3187@ubuntu> (raw)
In-Reply-To: <CAP22eLF2Q3O+=tnHRKE5q=jn9gw2G1rjAKiewM4qGsf4WYvP0Q@mail.gmail.com>

On Sun, May 17, 2020 at 07:43:21PM +0300, Lev R. Oshvang . wrote:
>
> Hi Oscar,
> I would recommend to explicitly set NULL to _cb and use if elif to
> exclude the case where botm _cb paraneters are passed as NULLs :
> > +
>   ctx->callback.mc =NULL:
>   ctx->callback.sc = NULL;
> > +       if (cb_sc)
> > +               ctx->callback.sc = cb_sc;
>
> > +       elif (cb_ms)
> > +               ctx->callback.mc = cb_mc;
> > +         else
>                     return -EINVAL;

Ok, I will do the changes you suggested and I will resend a new version.

> Hope you get the point.
> Lev

Thanks,
Oscar Carter