From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
helen.koike@collabora.com, ezequiel@collabora.com,
dafna3@gmail.com, kernel@collabora.com, hverkuil@xs4all.nl,
sakari.ailus@linux.intel.com, mchehab@kernel.org
Subject: Re: [PATCH 2/2] media: staging: rkisp1: stats: don't set stats flags in rkisp1_stats_send_measurement
Date: Wed, 20 May 2020 03:16:01 +0300 [thread overview]
Message-ID: <20200520001601.GN3820@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200509152904.26348-2-dafna.hirschfeld@collabora.com>
Hi Dafna,
Thank you for the patch.
On Sat, May 09, 2020 at 05:29:04PM +0200, Dafna Hirschfeld wrote:
> The flags that indicate which statistics are read are already
> set in the functions that read them so there is no need to
> set them in the function rkisp1_stats_send_measurement.
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/staging/media/rkisp1/rkisp1-stats.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-stats.c b/drivers/staging/media/rkisp1/rkisp1-stats.c
> index 8351bda0be03..0616793ae395 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-stats.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-stats.c
> @@ -356,26 +356,19 @@ rkisp1_stats_send_measurement(struct rkisp1_stats *stats,
> cur_stat_buf =
> (struct rkisp1_stat_buffer *)(cur_buf->vaddr[0]);
>
> - if (meas_work->isp_ris & RKISP1_CIF_ISP_AWB_DONE) {
> + if (meas_work->isp_ris & RKISP1_CIF_ISP_AWB_DONE)
> rkisp1_stats_get_awb_meas(stats, cur_stat_buf);
> - cur_stat_buf->meas_type |= RKISP1_CIF_ISP_STAT_AWB;
> - }
>
> - if (meas_work->isp_ris & RKISP1_CIF_ISP_AFM_FIN) {
> + if (meas_work->isp_ris & RKISP1_CIF_ISP_AFM_FIN)
> rkisp1_stats_get_afc_meas(stats, cur_stat_buf);
> - cur_stat_buf->meas_type |= RKISP1_CIF_ISP_STAT_AFM_FIN;
> - }
>
> if (meas_work->isp_ris & RKISP1_CIF_ISP_EXP_END) {
> rkisp1_stats_get_aec_meas(stats, cur_stat_buf);
> rkisp1_stats_get_bls_meas(stats, cur_stat_buf);
> - cur_stat_buf->meas_type |= RKISP1_CIF_ISP_STAT_AUTOEXP;
> }
>
> - if (meas_work->isp_ris & RKISP1_CIF_ISP_HIST_MEASURE_RDY) {
> + if (meas_work->isp_ris & RKISP1_CIF_ISP_HIST_MEASURE_RDY)
> rkisp1_stats_get_hst_meas(stats, cur_stat_buf);
> - cur_stat_buf->meas_type |= RKISP1_CIF_ISP_STAT_HIST;
> - }
>
> vb2_set_plane_payload(&cur_buf->vb.vb2_buf, 0,
> sizeof(struct rkisp1_stat_buffer));
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-05-20 0:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 15:29 [PATCH 1/2] media: staging: rkisp1 stats: set a measure flag with '|=' instead of '=' Dafna Hirschfeld
2020-05-09 15:29 ` [PATCH 2/2] media: staging: rkisp1: stats: don't set stats flags in rkisp1_stats_send_measurement Dafna Hirschfeld
2020-05-19 16:44 ` Helen Koike
2020-05-20 0:16 ` Laurent Pinchart [this message]
2020-05-26 23:15 ` Tomasz Figa
2020-05-19 16:39 ` [PATCH 1/2] media: staging: rkisp1 stats: set a measure flag with '|=' instead of '=' Helen Koike
2020-05-19 16:41 ` Helen Koike
2020-05-20 0:15 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520001601.GN3820@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).