From: Tomasz Figa <tfiga@chromium.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Michael Tretter <m.tretter@pengutronix.de>,
Nicolas Dufresne <nicolas@ndufresne.ca>
Subject: Re: [PATCHv2 2/2] vidioc-g-parm.rst: update the VIDIOC_G/S_PARM documentation
Date: Wed, 20 May 2020 19:09:25 +0000 [thread overview]
Message-ID: <20200520190925.GB35530@chromium.org> (raw)
In-Reply-To: <20200520100159.2094831-3-hverkuil-cisco@xs4all.nl>
Hi Hans,
On Wed, May 20, 2020 at 12:01:59PM +0200, Hans Verkuil wrote:
> This documentation is very outdated. In particular, it is
> not obvious at all that this is used to change the framerate of
> sensors.
>
> Fix it, and include references to the stateful encoder API where
> this works slightly different.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
> .../userspace-api/media/v4l/vidioc-g-parm.rst | 51 ++++++++++++-------
> 1 file changed, 32 insertions(+), 19 deletions(-)
Just one nit inline.
> @@ -216,8 +229,8 @@ union holding separate parameters for input and output devices.
>
> * - ``V4L2_CAP_TIMEPERFRAME``
> - 0x1000
> - - The frame skipping/repeating controlled by the ``timeperframe``
> - field is supported.
> + - The frame period can be modified by settings the ``timeperframe``
> + field.
>
s/settings/setting/
Best regards,
Tomasz
next prev parent reply other threads:[~2020-05-20 19:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 10:01 [PATCHv2 0/2] Stateful Encoding: final bits Hans Verkuil
2020-05-20 10:01 ` [PATCHv2 1/2] media: docs-rst: Document memory-to-memory video encoder interface Hans Verkuil
2020-05-20 19:07 ` Tomasz Figa
2020-05-20 20:32 ` Nicolas Dufresne
2020-05-26 8:32 ` Hans Verkuil
2020-05-26 16:01 ` Tomasz Figa
2020-05-28 7:44 ` Michael Tretter
2020-05-28 8:48 ` Hans Verkuil
2020-05-28 12:02 ` Tomasz Figa
2020-05-20 20:33 ` Stanimir Varbanov
2020-05-26 8:18 ` Hans Verkuil
2020-05-20 10:01 ` [PATCHv2 2/2] vidioc-g-parm.rst: update the VIDIOC_G/S_PARM documentation Hans Verkuil
2020-05-20 19:09 ` Tomasz Figa [this message]
2020-05-20 19:11 ` [PATCHv2 0/2] Stateful Encoding: final bits Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520190925.GB35530@chromium.org \
--to=tfiga@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=nicolas@ndufresne.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).