From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E275AC433E0 for ; Sun, 24 May 2020 20:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC37E207D8 for ; Sun, 24 May 2020 20:33:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388075AbgEXUdv (ORCPT ); Sun, 24 May 2020 16:33:51 -0400 Received: from mga09.intel.com ([134.134.136.24]:8056 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388045AbgEXUdu (ORCPT ); Sun, 24 May 2020 16:33:50 -0400 IronPort-SDR: DCubHS15rd9IwKKdybv3X9Sleift3gq9agqNrnj4MdfLcY+J96Yk8NUZKjiktPO69TQgvh+Y/y oqY8IFhS6RLA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2020 13:33:50 -0700 IronPort-SDR: hGO7Y3wYazKbBMeBckgS76jnZK8vgx3/d2+Tum7KpIZBE7Os41Bbvt3Qwb/u2VDS+n2UM4fhvq Z18P3EudgMLg== X-IronPort-AV: E=Sophos;i="5.73,430,1583222400"; d="scan'208";a="254745249" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2020 13:33:46 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 554C820736; Sun, 24 May 2020 23:33:44 +0300 (EEST) Date: Sun, 24 May 2020 23:33:44 +0300 From: Sakari Ailus To: Tomasz Figa Cc: Dongchun Zhu , Rob Herring , Linus Walleij , Bartosz Golaszewski , Mauro Carvalho Chehab , Andy Shevchenko , Mark Rutland , Nicolas Boichat , Matthias Brugger , Cao Bing Bu , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , linux-devicetree , Louis Kuo , Shengnan Wang =?utf-8?B?KOeOi+Wco+eUtyk=?= Subject: Re: [V8, 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Message-ID: <20200524203344.GB7618@paasikivi.fi.intel.com> References: <20200509080627.23222-1-dongchun.zhu@mediatek.com> <20200509080627.23222-2-dongchun.zhu@mediatek.com> <20200511160207.GA32476@bogus> <1589251221.8804.289.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, May 21, 2020 at 08:59:56PM +0200, Tomasz Figa wrote: > Hi Dongchun, Rob, > > On Tue, May 12, 2020 at 4:41 AM Dongchun Zhu wrote: > > > > Hi Rob, > > > > Thanks for the review. > > > > On Mon, 2020-05-11 at 11:02 -0500, Rob Herring wrote: > > > On Sat, May 09, 2020 at 04:06:26PM +0800, Dongchun Zhu wrote: > [snip] > > > > + port { > > > > + wcam_out: endpoint { > > > > + remote-endpoint = <&mipi_in_wcam>; > > > > + data-lanes = <1>; > > > > > > This doesn't match the schema which says this should be 4 entries. > > > > > > > Property "data-lanes" shows the number of lanes that sensor supports. > > If this property is omitted, four-lane operation is assumed. > > For OV02A10, it is one-lane operation, so the property is supposed to be > > set to <1>. > > > > To clarify on this, the ov02a10 sensor supports only 1 lane. It's not > a driver limitation. If there's nothing to configure there, then the property should be omitted. I understood the sensor supported one to four lanes... -- Sakari Ailus