From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
<linux-media@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Eugeniu Rosca <roscaeugeniu@gmail.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] media: vsp1: dl: Fix NULL pointer dereference on unbind
Date: Mon, 25 May 2020 15:31:57 +0200 [thread overview]
Message-ID: <20200525133157.GA19608@lxhi-065.adit-jv.com> (raw)
In-Reply-To: <d4544b1b-a695-bd70-0ccb-e2fb1838f3f8@ideasonboard.com>
Hi Kieran,
On Mon, May 25, 2020 at 02:19:02PM +0100, Kieran Bingham wrote:
> Hi Eugeniu,
>
> Yeouch. Looks like I really missed a trick there!
Not a big deal. The good part is that it can be proactively fixed and
shared across the community.
>
> We should probably update the $SUBJECT to match what is performed in the
> patch, which is perhaps more like:
>
> "media: vsp1: dl: Store VSP reference when creating cmd pools"
To be honest, I am not a big fan of WHAT summary lines.
Rather, I prefer the WHY summary lines (and I think everyone should).
>
> On 23/05/2020 09:13, Eugeniu Rosca wrote:
>
> And then we can explain here:
>
> In commit f3b98e3c4d2e16 ("media: vsp1: Provide support for extended
> command pools"), the vsp pointer used for referencing the VSP1 device
> structure from a command pool during vsp1_dl_ext_cmd_pool_destroy() was
> not populated.
>
> Correctly assign the pointer to prevent the following
> null-pointer-dereference when removing the device:
That sounds good and I can push this improved description as v2.
> > Fixes: f3b98e3c4d2e16 ("media: vsp1: Provide support for extended command pools")
> > Cc: stable@vger.kernel.org # v4.19+
> > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> > ---
> >
> > How about adding a new unit test perfoming unbind/rebind to
> > http://git.ideasonboard.com/renesas/vsp-tests.git, to avoid
> > such issues in future?
>
> Yes, now I wish I had done so back at 4.19! I hope this wasn't too
> painful to diagnose and fix, and thank you for being so thorough in your
> report!
>
>
> > Locally, below command has been used to identify the problem:
> >
> > for f in $(find /sys/bus/platform/devices/ -name "*vsp*" -o -name "*fdp*"); do \
> > b=$(basename $f); \
> > echo $b > $f/driver/unbind; \
> > done
> >
>
> I've created a test to add to vsp-tests, which I'll post next, thank you
> for the suggestion.
>
> Before your patch is applied, I experience the same crash you have seen,
> and after your patch - I can successfully unbind/bind all of the VSP1
> instances.
>
> So I think you can have this too:
>
> Tested-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Awesome. Thanks!
--
Best regards,
Eugeniu Rosca
prev parent reply other threads:[~2020-05-25 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 8:13 [PATCH] media: vsp1: dl: Fix NULL pointer dereference on unbind Eugeniu Rosca
2020-05-25 13:19 ` Kieran Bingham
2020-05-25 13:31 ` Eugeniu Rosca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525133157.GA19608@lxhi-065.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=roscaeugeniu@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).