Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on usb/usb-testing balbi-usb/testing/next linus/master v5.7-rc7 next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Sean-Young/IR-Toy-IR-Droid-USB-driver/20200527-233914 base: git://linuxtv.org/media_tree.git master config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> drivers/media/rc/ir_toy.c:197:4: error: expected identifier or '(' } else { ^ >> drivers/media/rc/ir_toy.c:200:1: error: extraneous closing brace ('}') } ^ 2 errors generated. vim +197 drivers/media/rc/ir_toy.c 188 189 static void irtoy_out_callback(struct urb *urb) 190 { 191 struct irtoy *irtoy = urb->context; 192 193 if (urb->status == 0) { 194 if (irtoy->state == STATE_RESET) 195 complete(&irtoy->command_done); 196 } > 197 } else { 198 dev_warn(irtoy->dev, "out urb status: %d\n", urb->status); 199 } > 200 } 201 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org