From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C05C433E3 for ; Fri, 17 Jul 2020 19:31:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAD072064C for ; Fri, 17 Jul 2020 19:31:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gCHU735e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728548AbgGQTbY (ORCPT ); Fri, 17 Jul 2020 15:31:24 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:34522 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727999AbgGQTbX (ORCPT ); Fri, 17 Jul 2020 15:31:23 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 21B1C71D; Fri, 17 Jul 2020 21:31:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1595014281; bh=4K+wUuB36Bg97qnWUYUEzLxlrwOde0NvN+/s8ACX1Yg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gCHU735e9Ycq36ulTnrTE7hYks5yFbBR/jSPtjNSLljIwL/qTReeNB5GQUrbYyS2t 8t7e6OM0A01Rb2TJ0S6x9Sglwv9KYNozuQ12Y5/Z8gYC0mw+sETl9eraMpZrDDMqJi PJmcuuasZUUpd+RrzKMQjkNvuuqJzAAa7tjFPz+A= Date: Fri, 17 Jul 2020 22:31:13 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, slongerbeam@gmail.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Message-ID: <20200717193113.GC5961@pendragon.ideasonboard.com> References: <20200717132859.237120-1-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200717132859.237120-1-jacopo+renesas@jmondi.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Jacopo, On Fri, Jul 17, 2020 at 03:28:46PM +0200, Jacopo Mondi wrote: > Hello, > this series has been broken out from > " [PATCH 0/8] dt-bindings: media: i2c: Convert to json-schema" > which I sent out a few days ago. > > It was a single patch, now it's 13. Not sure it's a good sign :) > > Anyway, in the version sent as part of the mentioned series I just converted > the existing bindings to the json-schema format, without putting to much > attention to what was there. > > As suggested by Laurent I moved to specify properties as dt-schema, to > allow their validation, and that sprinkled to a lot of fun. I found it "fun" too when I started converting bindings to YAML schemas, albeit a quite painful fun at times. It was time consuming for me, as I found out a new mindset was needed to really understand what I was doing. I wonder if it's easier for people with prior exposure to formal languages. > For each patch in the series, the DTS and bindings maintainers are CC-ed. > The whole series has been sent to a limited audience only. > > The series starts with a plain conversion of the existing bindings to > dt-schema. It then fixes a potential issue on a dts user of the sensor, > and then move to remove or demote endpoint properties that were marked as > required in the original text bindings. This of course causes a log of churn > in the existing DTS which use the sensor, and opens some questions there from > which I expect the individual maintainers to provide directions on. > > Finally, the small patch for the driver to initialize DVP default signal > values to what the sensor manual and the bindings report. > > The series ends with the update of the MAINTAINERS file with the new > .yaml binding file and the addition of myself as co-maintainer for the driver. > Steve if you intended to remove yourself please send a patch, I didn't dare to > do it myself :) > > A final note for Rob and his bot: some patches breaks validation of existing > dts, which are then fixed by following patches. Hope this is ok, but it I > have to keep validation of all dts successful, patches would likely be huge > and hinder changes which I preferred to make explicitly in single patches. > > Jacopo Mondi (13): > dt-bindings: media: ov5640: Convert to json-schema > arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing > dt-bindings: media: ov5640: Do not limit rotation > dt-bindings: media: ti,cal: Remove sensor from example > dt-bindings: media: ov5640: Make bus-type mandatory > dt-bindings: media: ov5640: Require ep properties > dt-bindings: media: ov5640: Remove clock-lanes > dt-bindings: media: ov5640: Remove data-shift > dt-bindings: media: ov5640: Add default for synch signals > dt-bindings: media: ov5640: Demote DVP required properties > media: i2c: ov5640: Initialize DVP polarities as default > MAINTAINERS: ov5640: Add bindings file > dt-bindings: media: ov5640: Add myself as co-maintainer > > .../devicetree/bindings/media/i2c/ov5640.txt | 92 -------- > .../devicetree/bindings/media/i2c/ov5640.yaml | 208 ++++++++++++++++++ > .../devicetree/bindings/media/ti,cal.yaml | 22 -- > MAINTAINERS | 2 + > arch/arm/boot/dts/dra72-evm-common.dtsi | 2 +- > arch/arm/boot/dts/dra76-evm.dts | 2 +- > arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-icore.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- > arch/arm/boot/dts/stm32mp157c-ev1.dts | 2 +- > .../allwinner/sun50i-a64-amarula-relic.dts | 1 + > .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 1 + > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 8 +- > .../arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +- > drivers/media/i2c/ov5640.c | 16 +- > 16 files changed, 232 insertions(+), 134 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.txt > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.yaml -- Regards, Laurent Pinchart