From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
devicetree@vger.kernel.org, slongerbeam@gmail.com,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 09/13] dt-bindings: media: ov5640: Add default for synch signals
Date: Mon, 20 Jul 2020 13:50:32 -0600 [thread overview]
Message-ID: <20200720195032.GA2889388@bogus> (raw)
In-Reply-To: <20200717205931.GK5961@pendragon.ideasonboard.com>
On Fri, Jul 17, 2020 at 11:59:31PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Fri, Jul 17, 2020 at 03:28:55PM +0200, Jacopo Mondi wrote:
> > Add defalt value for the DVP interface synchronism signals.
>
> s/synchronism/synchronization/
>
> > The default values have been derived from register 0x4740
> > documentation (datasheet version 2.03)
> >
> > 0x4740 POLARITY CTRL00 default = 0x20
> > bit 5: pclk polarity = 1 active high
> > bit 1: HREF polarity = 0 active low
> > bit 0: VSYNC polarity = 0 active low
>
> Do we need default values ? That's only for the case where the
> properties are not specified, and I think they are mandatory when the
> bus-type is set to parallel, aren't they ? I think stating this
> explicitly will be less error-prone.
In this case, I think default should be fixed or not configurable.
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> > Documentation/devicetree/bindings/media/i2c/ov5640.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> > index ab700a1830aa..3c20cdd02f76 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> > @@ -94,12 +94,15 @@ properties:
> >
> > hsync-active:
> > enum: [0, 1]
> > + default: 0
> >
> > vsync-active:
> > enum: [0, 1]
> > + default: 0
> >
> > pclk-sample:
> > enum: [0, 1]
> > + default: 1
> >
> > allOf:
> > - if:
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2020-07-20 19:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 13:28 [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Jacopo Mondi
2020-07-17 13:28 ` [PATCH 01/13] " Jacopo Mondi
2020-07-17 19:28 ` Laurent Pinchart
2020-07-20 16:32 ` Rob Herring
2020-07-17 13:28 ` [PATCH 02/13] arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing Jacopo Mondi
2020-07-17 19:35 ` Laurent Pinchart
2020-07-22 8:14 ` Loic Poulain
2020-07-22 8:34 ` Jacopo Mondi
2020-07-17 13:28 ` [PATCH 03/13] dt-bindings: media: ov5640: Do not limit rotation Jacopo Mondi
2020-07-17 19:38 ` Laurent Pinchart
2020-07-20 19:36 ` Rob Herring
2020-07-17 13:28 ` [PATCH 04/13] dt-bindings: media: ti,cal: Remove sensor from example Jacopo Mondi
2020-07-17 19:39 ` Laurent Pinchart
2020-07-23 20:57 ` Rob Herring
2020-07-17 13:28 ` [PATCH 05/13] dt-bindings: media: ov5640: Make bus-type mandatory Jacopo Mondi
2020-07-17 15:48 ` Fabio Estevam
2020-07-17 19:48 ` Laurent Pinchart
2020-07-20 19:45 ` Rob Herring
2020-07-17 13:28 ` [PATCH 06/13] dt-bindings: media: ov5640: Require ep properties Jacopo Mondi
2020-07-17 19:50 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 07/13] dt-bindings: media: ov5640: Remove clock-lanes Jacopo Mondi
2020-07-17 20:48 ` Laurent Pinchart
2020-07-20 19:47 ` Rob Herring
2020-07-17 13:28 ` [PATCH 08/13] dt-bindings: media: ov5640: Remove data-shift Jacopo Mondi
2020-07-17 20:57 ` Laurent Pinchart
2020-07-23 22:22 ` Sakari Ailus
2020-07-23 23:15 ` Laurent Pinchart
2020-07-25 21:18 ` Sakari Ailus
2020-07-25 21:31 ` Laurent Pinchart
2020-07-29 14:29 ` Sakari Ailus
2020-07-29 14:46 ` Laurent Pinchart
2020-07-30 16:22 ` Sakari Ailus
2020-07-30 16:32 ` Laurent Pinchart
2020-07-30 16:43 ` Sakari Ailus
2020-07-17 13:28 ` [PATCH 09/13] dt-bindings: media: ov5640: Add default for synch signals Jacopo Mondi
2020-07-17 20:59 ` Laurent Pinchart
2020-07-20 19:50 ` Rob Herring [this message]
2020-07-17 13:28 ` [PATCH 10/13] dt-bindings: media: ov5640: Demote DVP required properties Jacopo Mondi
2020-07-17 21:00 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 11/13] media: i2c: ov5640: Initialize DVP polarities as default Jacopo Mondi
2020-07-17 21:02 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 12/13] MAINTAINERS: ov5640: Add bindings file Jacopo Mondi
2020-07-17 21:03 ` Laurent Pinchart
2020-07-17 13:28 ` [PATCH 13/13] dt-bindings: media: ov5640: Add myself as co-maintainer Jacopo Mondi
2020-07-17 21:03 ` Laurent Pinchart
2020-07-17 19:31 ` [PATCH 00/13] dt-bindings: media: ov5640: Convert to json-schema Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720195032.GA2889388@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).