* [PATCH] Staging : media : atomisp : pci : fixed a brace coding sytle issue
@ 2020-07-27 8:01 Ankit
2020-07-27 12:16 ` Andy Shevchenko
0 siblings, 1 reply; 13+ messages in thread
From: Ankit @ 2020-07-27 8:01 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, andriy.shevchenko
Cc: linux-media, devel, linux-kernel, b18007
From: Ankit Baluni<b18007@students.iitmandi.ac.in>
Fixed a coding style issue.
Signed-off-by: Ankit Baluni<b18007@students.iitmandi.ac.in>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] Staging : media : atomisp : pci : fixed a brace coding sytle issue
2020-07-27 8:01 [PATCH] Staging : media : atomisp : pci : fixed a brace coding sytle issue Ankit
@ 2020-07-27 12:16 ` Andy Shevchenko
2020-07-27 21:30 ` [PATCH] Staging : media : atomisp " Ankit
0 siblings, 1 reply; 13+ messages in thread
From: Andy Shevchenko @ 2020-07-27 12:16 UTC (permalink / raw)
To: Ankit; +Cc: mchehab, gregkh, sakari.ailus, linux-media, devel, linux-kernel
On Mon, Jul 27, 2020 at 01:31:50PM +0530, Ankit wrote:
> From: Ankit Baluni<b18007@students.iitmandi.ac.in>
>
> Fixed a coding style issue.
One time is enough to be sent :-)
The Subject nevertheless can be amended, like
media: atomisp: fixed a brace coding sytle issue
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-27 12:16 ` Andy Shevchenko
@ 2020-07-27 21:30 ` Ankit
2020-07-28 7:37 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: Ankit @ 2020-07-27 21:30 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, andriy.shevchenko
Cc: linux-media, devel, linux-kernel, b18007
From: Ankit Baluni<b18007@students.iitmandi.ac.in>
Fixed a coding style issue.
Signed-off-by: Ankit Baluni<b18007@students.iitmandi.ac.in>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-27 21:30 ` [PATCH] Staging : media : atomisp " Ankit
@ 2020-07-28 7:37 ` Greg KH
2020-07-28 8:23 ` [PATCH v2] " Ankit
0 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2020-07-28 7:37 UTC (permalink / raw)
To: Ankit
Cc: mchehab, sakari.ailus, andriy.shevchenko, linux-media, devel,
linux-kernel
On Tue, Jul 28, 2020 at 03:00:10AM +0530, Ankit wrote:
> From: Ankit Baluni<b18007@students.iitmandi.ac.in>
You need a ' ' before the '<' character.
>
> Fixed a coding style issue.
Be more descriptive of what you are doing, this is vague.
>
> Signed-off-by: Ankit Baluni<b18007@students.iitmandi.ac.in>
Same here with the ' '.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-28 7:37 ` Greg KH
@ 2020-07-28 8:23 ` Ankit
2020-07-28 8:43 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: Ankit @ 2020-07-28 8:23 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, andriy.shevchenko
Cc: linux-media, devel, linux-kernel, b18007
From: Ankit Baluni <b18007@students.iitmandi.ac.in>
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-28 8:23 ` [PATCH v2] " Ankit
@ 2020-07-28 8:43 ` Greg KH
2020-07-28 9:02 ` Ankit
2020-07-28 22:59 ` Ankit
0 siblings, 2 replies; 13+ messages in thread
From: Greg KH @ 2020-07-28 8:43 UTC (permalink / raw)
To: Ankit
Cc: mchehab, sakari.ailus, andriy.shevchenko, linux-media, devel,
linux-kernel
On Tue, Jul 28, 2020 at 01:53:30PM +0530, Ankit wrote:
> From: Ankit Baluni <b18007@students.iitmandi.ac.in>
>
> Removed braces for a 'if' condition as it contain only single line &
> there is no need for braces for such case according to coding style
> rules.
>
> Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
>
> ---
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
What changed from v1?
Always put that below the --- line as the documentation asks for.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-28 8:43 ` Greg KH
@ 2020-07-28 9:02 ` Ankit
2020-07-28 22:59 ` Ankit
1 sibling, 0 replies; 13+ messages in thread
From: Ankit @ 2020-07-28 9:02 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, andriy.shevchenko
Cc: linux-media, devel, linux-kernel, b18007
From: Ankit Baluni <b18007@students.iitmandi.ac.in>
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
---
Added extra description and added space before '<' in above lines.
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-28 8:43 ` Greg KH
2020-07-28 9:02 ` Ankit
@ 2020-07-28 22:59 ` Ankit
2020-07-29 7:39 ` [PATCH v3] " Ankit Baluni
2020-07-29 7:49 ` [PATCH v3] Staging: media: atomisp: " Ankit Baluni
1 sibling, 2 replies; 13+ messages in thread
From: Ankit @ 2020-07-28 22:59 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, andriy.shevchenko
Cc: linux-media, devel, linux-kernel, b18007
From: Ankit Baluni <b18007@students.iitmandi.ac.in>
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
---
Changes in v2:
-Added more description about the patch.
-Added space before the symobol '<' in 'From'
and 'Signed-off-by' line.
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v3] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-28 22:59 ` Ankit
@ 2020-07-29 7:39 ` Ankit Baluni
2020-07-29 7:45 ` Greg KH
2020-07-29 7:49 ` [PATCH v3] Staging: media: atomisp: " Ankit Baluni
1 sibling, 1 reply; 13+ messages in thread
From: Ankit Baluni @ 2020-07-29 7:39 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, andriy.shevchenko
Cc: linux-media, devel, linux-kernel, b18007
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
---
Changes in v2:
-Added more description about the patch.
-Added space before the symobol '<' in 'From'
and 'Signed-off-by' line.
Changes in v3:
-Removed space before ':' in subject line.
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v3] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-29 7:39 ` [PATCH v3] " Ankit Baluni
@ 2020-07-29 7:45 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2020-07-29 7:45 UTC (permalink / raw)
To: Ankit Baluni
Cc: mchehab, sakari.ailus, andriy.shevchenko, devel, linux-kernel,
linux-media
On Wed, Jul 29, 2020 at 01:09:02PM +0530, Ankit Baluni wrote:
> Removed braces for a 'if' condition as it contain only single line &
> there is no need for braces for such case according to coding style
> rules.
>
> Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
>
> ---
> Changes in v2:
> -Added more description about the patch.
> -Added space before the symobol '<' in 'From'
> and 'Signed-off-by' line.
> Changes in v3:
> -Removed space before ':' in subject line.
No you did not :(
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v3] Staging: media: atomisp: fixed a brace coding sytle issue
2020-07-28 22:59 ` Ankit
2020-07-29 7:39 ` [PATCH v3] " Ankit Baluni
@ 2020-07-29 7:49 ` Ankit Baluni
2020-07-29 10:56 ` Andy Shevchenko
1 sibling, 1 reply; 13+ messages in thread
From: Ankit Baluni @ 2020-07-29 7:49 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, andriy.shevchenko
Cc: linux-media, devel, linux-kernel, b18007
Removed braces for a 'if' condition as it contain only single line &
there is no need for braces for such case according to coding style
rules.
Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
---
Changes in v2:
-Added more description about the patch.
-Added space before the symobol '<' in 'From'
and 'Signed-off-by' line.
Changes in v3:
-Removed space before ':' in subject line.
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v3] Staging: media: atomisp: fixed a brace coding sytle issue
2020-07-29 7:49 ` [PATCH v3] Staging: media: atomisp: " Ankit Baluni
@ 2020-07-29 10:56 ` Andy Shevchenko
0 siblings, 0 replies; 13+ messages in thread
From: Andy Shevchenko @ 2020-07-29 10:56 UTC (permalink / raw)
To: Ankit Baluni
Cc: mchehab, gregkh, sakari.ailus, linux-media, devel, linux-kernel
On Wed, Jul 29, 2020 at 01:19:50PM +0530, Ankit Baluni wrote:
> Removed braces for a 'if' condition as it contain only single line &
> there is no need for braces for such case according to coding style
> rules.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
>
> ---
> Changes in v2:
> -Added more description about the patch.
> -Added space before the symobol '<' in 'From'
> and 'Signed-off-by' line.
> Changes in v3:
> -Removed space before ':' in subject line.
>
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 8ea65bef35d2..28b96b66f4f3 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
> case ATOMISP_CAMERA_PORT_SECONDARY:
> return MIPI_PORT1_ID;
> case ATOMISP_CAMERA_PORT_TERTIARY:
> - if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
> + if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
> return MIPI_PORT1_ID + 1;
> - }
> /* fall through */
> default:
> dev_err(isp->dev, "unsupported port: %d\n", port);
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] Staging : media : atomisp : pci : fixed a brace coding sytle issue
@ 2020-07-27 7:55 Ankit
0 siblings, 0 replies; 13+ messages in thread
From: Ankit @ 2020-07-27 7:55 UTC (permalink / raw)
To: mchehab
Cc: gregkh, sakari.ailus, andriy.shevchenko, linux-media, devel,
linux-kernel, b18007
From: Ankit Baluni<b18007@students.iitmandi.ac.in>
Fixed a coding style issue.
Signed-off-by: Ankit Baluni<b18007@students.iitmandi.ac.in>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-07-29 10:56 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 8:01 [PATCH] Staging : media : atomisp : pci : fixed a brace coding sytle issue Ankit
2020-07-27 12:16 ` Andy Shevchenko
2020-07-27 21:30 ` [PATCH] Staging : media : atomisp " Ankit
2020-07-28 7:37 ` Greg KH
2020-07-28 8:23 ` [PATCH v2] " Ankit
2020-07-28 8:43 ` Greg KH
2020-07-28 9:02 ` Ankit
2020-07-28 22:59 ` Ankit
2020-07-29 7:39 ` [PATCH v3] " Ankit Baluni
2020-07-29 7:45 ` Greg KH
2020-07-29 7:49 ` [PATCH v3] Staging: media: atomisp: " Ankit Baluni
2020-07-29 10:56 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 7:55 [PATCH] Staging : media : atomisp : pci : " Ankit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).