Linux-Media Archive on lore.kernel.org
 help / color / Atom feed
* nxp imx8m CSI drivers
@ 2020-07-09  9:32 Martin Kepplinger
  2020-07-28 10:36 ` Martin Kepplinger
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Kepplinger @ 2020-07-09  9:32 UTC (permalink / raw)
  To: slongerbeam, p.zabel, mchehab
  Cc: linux-media, Shawn Guo, Pengutronix Kernel Team, NXP Linux Team,
	kernel, devel, linux-arm-kernel

hi linux-media people,

TL-DR: when exactly is "sd->entity.function == MEDIA_ENT_F_VID_MUX"?


I try to use the camera on our librem5-devkit (imx8mq): I try to use
only mainline drivers except for "mxc-mipi-csi2_yav" taken from
linux-imx (which we can prepare to submit if a PoC works. This is the
tree I'm experimenting with:

https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.8-rc4/librem5___csi

* "imx7-media-csi" / imx-media-capture / imx-media-utils currently in
staging (that should work according to NXP)
* ov5640 mainline driver
* mxc-mipi-csi2_yav from NXP tree (linux-imx) with
v4l2_subdev_video_ops' mipi_csis_g_parm and mipi_csis_s_parm callbacks
removed (due to missing API in mainline)

the drivers probe and run but the following fails when trying to use the
camera (gstreamer):

in imx-media-utils' imx_media_pipeline_set_stream() the call to
v4l2_subdev_call(sd, video, s_stream, 1) returns with 32 (broken pipe)
and thus the application that tries to use the camera too.

One problem is definitely the trees' last commit (that I did as a
workaround) in this tree that makes the drivers probe but only by
ignoring this probably needed check:

imx7-media-csi's imx7_csi_notify_bound() callback implementation gets
called during startup. But if (WARN_ON(sd->entity.function !=
MEDIA_ENT_F_VID_MUX)) is true so this is the wrong type of subdev (?).

I just want to put this out there and check if the general approach is
valid at all and if there's anything that comes to your mind.

thanks a lot,
                              martin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: nxp imx8m CSI drivers
  2020-07-09  9:32 nxp imx8m CSI drivers Martin Kepplinger
@ 2020-07-28 10:36 ` Martin Kepplinger
  2020-07-29  0:44   ` Laurent Pinchart
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Kepplinger @ 2020-07-28 10:36 UTC (permalink / raw)
  To: slongerbeam, p.zabel, mchehab, Pavel Machek
  Cc: linux-media, Shawn Guo, Pengutronix Kernel Team, NXP Linux Team,
	kernel, devel, linux-arm-kernel

On 09.07.20 11:32, Martin Kepplinger wrote:
> hi linux-media people,
> 
> TL-DR: when exactly is "sd->entity.function == MEDIA_ENT_F_VID_MUX"?
> 
> 
> I try to use the camera on our librem5-devkit (imx8mq): I try to use
> only mainline drivers except for "mxc-mipi-csi2_yav" taken from
> linux-imx (which we can prepare to submit if a PoC works. This is the
> tree I'm experimenting with:
> 
> https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.8-rc4/librem5___csi
> 
> * "imx7-media-csi" / imx-media-capture / imx-media-utils currently in
> staging (that should work according to NXP)
> * ov5640 mainline driver
> * mxc-mipi-csi2_yav from NXP tree (linux-imx) with
> v4l2_subdev_video_ops' mipi_csis_g_parm and mipi_csis_s_parm callbacks
> removed (due to missing API in mainline)
> 
> the drivers probe and run but the following fails when trying to use the
> camera (gstreamer):
> 
> in imx-media-utils' imx_media_pipeline_set_stream() the call to
> v4l2_subdev_call(sd, video, s_stream, 1) returns with 32 (broken pipe)
> and thus the application that tries to use the camera too.
> 
> One problem is definitely the trees' last commit (that I did as a
> workaround) in this tree that makes the drivers probe but only by
> ignoring this probably needed check:
> 
> imx7-media-csi's imx7_csi_notify_bound() callback implementation gets
> called during startup. But if (WARN_ON(sd->entity.function !=
> MEDIA_ENT_F_VID_MUX)) is true so this is the wrong type of subdev (?).
> 
> I just want to put this out there and check if the general approach is
> valid at all and if there's anything that comes to your mind.
> 
> thanks a lot,
>                               martin
> 

(added Pavel Machek)

still I'm only on the librem5 Devkit: the situation regarding a tree
that should use the imx7-media-csi csi_bridge driver hasn't changed, see
above for the details. The tree I tried now is this one:

https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.8-rc7/librem5___csi_ml1

A tree that includes NXP's csi_bridge and mipi-csi drivers (and camera
driver) on the other hand works, and I have one based on v5.8-rcX too:

https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.8-rc7/librem5___csi_nxp

Since I want to look into a different camera driver, I might use that
nxp-drivers tree to work on that, but our goal is obviously to use what
is already in staging and should work (the csi bridge driver at least).
In case you know more about the v4l2 details that don't match over
there, please have a look.

thanks a lot in advance,

                               martin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: nxp imx8m CSI drivers
  2020-07-28 10:36 ` Martin Kepplinger
@ 2020-07-29  0:44   ` Laurent Pinchart
  0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2020-07-29  0:44 UTC (permalink / raw)
  To: Martin Kepplinger
  Cc: slongerbeam, p.zabel, mchehab, Pavel Machek, linux-media,
	Shawn Guo, Pengutronix Kernel Team, NXP Linux Team, kernel,
	devel, linux-arm-kernel

Hi Martin,

On Tue, Jul 28, 2020 at 12:36:58PM +0200, Martin Kepplinger wrote:
> On 09.07.20 11:32, Martin Kepplinger wrote:
> > hi linux-media people,
> > 
> > TL-DR: when exactly is "sd->entity.function == MEDIA_ENT_F_VID_MUX"?
> > 
> > 
> > I try to use the camera on our librem5-devkit (imx8mq): I try to use
> > only mainline drivers except for "mxc-mipi-csi2_yav" taken from
> > linux-imx (which we can prepare to submit if a PoC works. This is the
> > tree I'm experimenting with:
> > 
> > https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.8-rc4/librem5___csi
> > 
> > * "imx7-media-csi" / imx-media-capture / imx-media-utils currently in
> > staging (that should work according to NXP)
> > * ov5640 mainline driver
> > * mxc-mipi-csi2_yav from NXP tree (linux-imx) with
> > v4l2_subdev_video_ops' mipi_csis_g_parm and mipi_csis_s_parm callbacks
> > removed (due to missing API in mainline)
> > 
> > the drivers probe and run but the following fails when trying to use the
> > camera (gstreamer):
> > 
> > in imx-media-utils' imx_media_pipeline_set_stream() the call to
> > v4l2_subdev_call(sd, video, s_stream, 1) returns with 32 (broken pipe)
> > and thus the application that tries to use the camera too.
> > 
> > One problem is definitely the trees' last commit (that I did as a
> > workaround) in this tree that makes the drivers probe but only by
> > ignoring this probably needed check:
> > 
> > imx7-media-csi's imx7_csi_notify_bound() callback implementation gets
> > called during startup. But if (WARN_ON(sd->entity.function !=
> > MEDIA_ENT_F_VID_MUX)) is true so this is the wrong type of subdev (?).
> > 
> > I just want to put this out there and check if the general approach is
> > valid at all and if there's anything that comes to your mind.
> 
> (added Pavel Machek)
> 
> still I'm only on the librem5 Devkit: the situation regarding a tree
> that should use the imx7-media-csi csi_bridge driver hasn't changed, see
> above for the details. The tree I tried now is this one:
> 
> https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.8-rc7/librem5___csi_ml1
> 
> A tree that includes NXP's csi_bridge and mipi-csi drivers (and camera
> driver) on the other hand works, and I have one based on v5.8-rcX too:
> 
> https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.8-rc7/librem5___csi_nxp
> 
> Since I want to look into a different camera driver, I might use that
> nxp-drivers tree to work on that, but our goal is obviously to use what
> is already in staging and should work (the csi bridge driver at least).
> In case you know more about the v4l2 details that don't match over
> there, please have a look.

For what it's worth, I'm debugging a complete system memory corruption
with the imx staging camera driver on an i.MX7D, on v5.8-rc6. The issue
didn't occur on v5.7. I however have a fairly large number of custom
patches that I'm in the process of upstreaming on top of mainline for
that driver, so I can't tell yet whether the problem is in my code or in
v5.8-rc6.

I haven't been able to use the staging driver as-is, neither on v5.7 nor
on v5.8-rc6, with the camera sensor I'm working with (a Sony IMX296). I
also get an EPIPE (32) error. Seems there's a reason why this driver is
in staging :-) This however makes debugging more difficult as I can't
test v5.8-rc6 without my custom changes.

As for MEDIA_ENT_F_VID_MUX, the check is about verifying that the device
connected directly to the input of the CSI (*not* MIPI CSI2) is the
video mux that selects between the MIPI CSI2 receiver and the parallel
sensor input. On i.MX7D, this models the "CSI Input MUX Control" bit in
register IOMUXC_GPR_GPR5. On i.MX8M, there seems to be no such mux, as
there seems to be no parallel sensor input. It should thus be safe to
drop the check, but other adjustements to the routing and pipeline
configuration logic in the driver will likely be needed.

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09  9:32 nxp imx8m CSI drivers Martin Kepplinger
2020-07-28 10:36 ` Martin Kepplinger
2020-07-29  0:44   ` Laurent Pinchart

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git