tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6ba1b005ffc388c2aeaddae20da29e4810dea298 commit: 5b552b198c2557295becd471bff53bb520fefee5 media: atomisp: re-enable warnings again date: 7 weeks ago config: i386-randconfig-r016-20200729 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): git checkout 5b552b198c2557295becd471bff53bb520fefee5 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): cc1: warning: drivers/staging/media/atomisp//pci/hive_isp_css_include/memory_access/: No such file or directory [-Wmissing-include-dirs] drivers/staging/media/atomisp/pci/atomisp_cmd.c: In function 'atomisp_get_metadata': >> drivers/staging/media/atomisp/pci/atomisp_cmd.c:2805:31: warning: variable 'stream_config' set but not used [-Wunused-but-set-variable] 2805 | struct ia_css_stream_config *stream_config; | ^~~~~~~~~~~~~ drivers/staging/media/atomisp/pci/atomisp_cmd.c: In function 'atomisp_get_metadata_by_type': drivers/staging/media/atomisp/pci/atomisp_cmd.c:2884:31: warning: variable 'stream_config' set but not used [-Wunused-but-set-variable] 2884 | struct ia_css_stream_config *stream_config; | ^~~~~~~~~~~~~ In file included from drivers/staging/media/atomisp//pci/system_local.h:8, from drivers/staging/media/atomisp//pci/ia_css_acc_types.h:23, from drivers/staging/media/atomisp//pci/ia_css_pipe_public.h:29, from drivers/staging/media/atomisp/pci/sh_css_legacy.h:23, from drivers/staging/media/atomisp/pci/atomisp_internal.h:34, from drivers/staging/media/atomisp/pci/atomisp_cmd.h:30, from drivers/staging/media/atomisp/pci/atomisp_cmd.c:37: At top level: drivers/staging/media/atomisp//pci/isp2401_system_local.h:217:26: warning: 'STREAM2MMIO_CTRL_BASE' defined but not used [-Wunused-const-variable=] 217 | static const hrt_address STREAM2MMIO_CTRL_BASE[N_STREAM2MMIO_ID] = { | ^~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:210:26: warning: 'PIXELGEN_CTRL_BASE' defined but not used [-Wunused-const-variable=] 210 | static const hrt_address PIXELGEN_CTRL_BASE[N_PIXELGEN_ID] = { | ^~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:203:26: warning: 'CSI_RX_BE_CTRL_BASE' defined but not used [-Wunused-const-variable=] 203 | static const hrt_address CSI_RX_BE_CTRL_BASE[N_CSI_RX_BACKEND_ID] = { | ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:196:26: warning: 'CSI_RX_FE_CTRL_BASE' defined but not used [-Wunused-const-variable=] 196 | static const hrt_address CSI_RX_FE_CTRL_BASE[N_CSI_RX_FRONTEND_ID] = { | ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:189:26: warning: 'ISYS_IRQ_BASE' defined but not used [-Wunused-const-variable=] 189 | static const hrt_address ISYS_IRQ_BASE[N_ISYS_IRQ_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:182:26: warning: 'IBUF_CTRL_BASE' defined but not used [-Wunused-const-variable=] 182 | static const hrt_address IBUF_CTRL_BASE[N_IBUF_CTRL_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:177:26: warning: 'RX_BASE' defined but not used [-Wunused-const-variable=] 177 | static const hrt_address RX_BASE[N_RX_ID] = { | ^~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:162:26: warning: 'INPUT_SYSTEM_BASE' defined but not used [-Wunused-const-variable=] 162 | static const hrt_address INPUT_SYSTEM_BASE[N_INPUT_SYSTEM_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:154:26: warning: 'INPUT_FORMATTER_BASE' defined but not used [-Wunused-const-variable=] 154 | static const hrt_address INPUT_FORMATTER_BASE[N_INPUT_FORMATTER_ID] = { | ^~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:149:26: warning: 'TIMED_CTRL_BASE' defined but not used [-Wunused-const-variable=] 149 | static const hrt_address TIMED_CTRL_BASE[N_TIMED_CTRL_ID] = { | ^~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:144:26: warning: 'GPIO_BASE' defined but not used [-Wunused-const-variable=] 144 | static const hrt_address GPIO_BASE[N_GPIO_ID] = { | ^~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:140:26: warning: 'GP_TIMER_BASE' defined but not used [-Wunused-const-variable=] 140 | static const hrt_address GP_TIMER_BASE = | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:133:26: warning: 'GP_DEVICE_BASE' defined but not used [-Wunused-const-variable=] 133 | static const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:120:26: warning: 'FIFO_MONITOR_BASE' defined but not used [-Wunused-const-variable=] 120 | static const hrt_address FIFO_MONITOR_BASE[N_FIFO_MONITOR_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:114:26: warning: 'GDC_BASE' defined but not used [-Wunused-const-variable=] 114 | static const hrt_address GDC_BASE[N_GDC_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:102:26: warning: 'IRQ_BASE' defined but not used [-Wunused-const-variable=] 102 | static const hrt_address IRQ_BASE[N_IRQ_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:97:26: warning: 'ISYS2401_DMA_BASE' defined but not used [-Wunused-const-variable=] 97 | static const hrt_address ISYS2401_DMA_BASE[N_ISYS2401_DMA_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:93:26: warning: 'DMA_BASE' defined but not used [-Wunused-const-variable=] 93 | static const hrt_address DMA_BASE[N_DMA_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:84:26: warning: 'MMU_BASE' defined but not used [-Wunused-const-variable=] 84 | static const hrt_address MMU_BASE[N_MMU_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:74:26: warning: 'SP_DMEM_BASE' defined but not used [-Wunused-const-variable=] 74 | static const hrt_address SP_DMEM_BASE[N_SP_ID] = { | ^~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:70:26: warning: 'SP_CTRL_BASE' defined but not used [-Wunused-const-variable=] 70 | static const hrt_address SP_CTRL_BASE[N_SP_ID] = { | ^~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:65:26: warning: 'ISP_HMEM_BASE' defined but not used [-Wunused-const-variable=] 65 | static const hrt_address ISP_HMEM_BASE[N_HMEM_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:59:26: warning: 'ISP_VAMEM_BASE' defined but not used [-Wunused-const-variable=] 59 | static const hrt_address ISP_VAMEM_BASE[N_VAMEM_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:55:26: warning: 'ISP_BAMEM_BASE' defined but not used [-Wunused-const-variable=] 55 | static const hrt_address ISP_BAMEM_BASE[N_BAMEM_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:51:26: warning: 'ISP_DMEM_BASE' defined but not used [-Wunused-const-variable=] 51 | static const hrt_address ISP_DMEM_BASE[N_ISP_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:47:26: warning: 'ISP_CTRL_BASE' defined but not used [-Wunused-const-variable=] 47 | static const hrt_address ISP_CTRL_BASE[N_ISP_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:42:26: warning: 'DDR_BASE' defined but not used [-Wunused-const-variable=] 42 | static const hrt_address DDR_BASE[N_DDR_ID] = { | ^~~~~~~~ -- cc1: warning: drivers/staging/media/atomisp//pci/hive_isp_css_include/memory_access/: No such file or directory [-Wmissing-include-dirs] drivers/staging/media/atomisp/pci/atomisp_compat_css20.c: In function 'atomisp_css2_dbg_print': >> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:159:2: warning: function 'atomisp_css2_dbg_print' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 159 | vprintk(fmt, args); | ^~~~~~~ drivers/staging/media/atomisp/pci/atomisp_compat_css20.c: In function 'atomisp_css2_dbg_ftrace_print': >> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:165:2: warning: function 'atomisp_css2_dbg_ftrace_print' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 165 | ftrace_vprintk(fmt, args); | ^~~~~~~~~~~~~~ >> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:165:2: warning: function 'atomisp_css2_dbg_ftrace_print' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] drivers/staging/media/atomisp/pci/atomisp_compat_css20.c: In function 'atomisp_css2_err_print': >> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:171:2: warning: function 'atomisp_css2_err_print' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 171 | vprintk(fmt, args); | ^~~~~~~ In file included from drivers/staging/media/atomisp//pci/system_local.h:8, from drivers/staging/media/atomisp/pci/ia_css_acc_types.h:23, from drivers/staging/media/atomisp/pci/ia_css.h:26, from drivers/staging/media/atomisp/pci/atomisp_compat_css20.h:24, from drivers/staging/media/atomisp/pci/atomisp_compat.h:22, from drivers/staging/media/atomisp/pci/atomisp_compat_css20.c:28: At top level: drivers/staging/media/atomisp//pci/isp2401_system_local.h:217:26: warning: 'STREAM2MMIO_CTRL_BASE' defined but not used [-Wunused-const-variable=] 217 | static const hrt_address STREAM2MMIO_CTRL_BASE[N_STREAM2MMIO_ID] = { | ^~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:210:26: warning: 'PIXELGEN_CTRL_BASE' defined but not used [-Wunused-const-variable=] 210 | static const hrt_address PIXELGEN_CTRL_BASE[N_PIXELGEN_ID] = { | ^~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:203:26: warning: 'CSI_RX_BE_CTRL_BASE' defined but not used [-Wunused-const-variable=] 203 | static const hrt_address CSI_RX_BE_CTRL_BASE[N_CSI_RX_BACKEND_ID] = { | ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:196:26: warning: 'CSI_RX_FE_CTRL_BASE' defined but not used [-Wunused-const-variable=] 196 | static const hrt_address CSI_RX_FE_CTRL_BASE[N_CSI_RX_FRONTEND_ID] = { | ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:189:26: warning: 'ISYS_IRQ_BASE' defined but not used [-Wunused-const-variable=] 189 | static const hrt_address ISYS_IRQ_BASE[N_ISYS_IRQ_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:182:26: warning: 'IBUF_CTRL_BASE' defined but not used [-Wunused-const-variable=] 182 | static const hrt_address IBUF_CTRL_BASE[N_IBUF_CTRL_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:177:26: warning: 'RX_BASE' defined but not used [-Wunused-const-variable=] 177 | static const hrt_address RX_BASE[N_RX_ID] = { | ^~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:162:26: warning: 'INPUT_SYSTEM_BASE' defined but not used [-Wunused-const-variable=] 162 | static const hrt_address INPUT_SYSTEM_BASE[N_INPUT_SYSTEM_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:154:26: warning: 'INPUT_FORMATTER_BASE' defined but not used [-Wunused-const-variable=] 154 | static const hrt_address INPUT_FORMATTER_BASE[N_INPUT_FORMATTER_ID] = { | ^~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:149:26: warning: 'TIMED_CTRL_BASE' defined but not used [-Wunused-const-variable=] 149 | static const hrt_address TIMED_CTRL_BASE[N_TIMED_CTRL_ID] = { | ^~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:144:26: warning: 'GPIO_BASE' defined but not used [-Wunused-const-variable=] 144 | static const hrt_address GPIO_BASE[N_GPIO_ID] = { | ^~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:140:26: warning: 'GP_TIMER_BASE' defined but not used [-Wunused-const-variable=] 140 | static const hrt_address GP_TIMER_BASE = | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:133:26: warning: 'GP_DEVICE_BASE' defined but not used [-Wunused-const-variable=] 133 | static const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:120:26: warning: 'FIFO_MONITOR_BASE' defined but not used [-Wunused-const-variable=] 120 | static const hrt_address FIFO_MONITOR_BASE[N_FIFO_MONITOR_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:114:26: warning: 'GDC_BASE' defined but not used [-Wunused-const-variable=] 114 | static const hrt_address GDC_BASE[N_GDC_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:102:26: warning: 'IRQ_BASE' defined but not used [-Wunused-const-variable=] 102 | static const hrt_address IRQ_BASE[N_IRQ_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:97:26: warning: 'ISYS2401_DMA_BASE' defined but not used [-Wunused-const-variable=] 97 | static const hrt_address ISYS2401_DMA_BASE[N_ISYS2401_DMA_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:93:26: warning: 'DMA_BASE' defined but not used [-Wunused-const-variable=] 93 | static const hrt_address DMA_BASE[N_DMA_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:84:26: warning: 'MMU_BASE' defined but not used [-Wunused-const-variable=] 84 | static const hrt_address MMU_BASE[N_MMU_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:74:26: warning: 'SP_DMEM_BASE' defined but not used [-Wunused-const-variable=] 74 | static const hrt_address SP_DMEM_BASE[N_SP_ID] = { | ^~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:70:26: warning: 'SP_CTRL_BASE' defined but not used [-Wunused-const-variable=] 70 | static const hrt_address SP_CTRL_BASE[N_SP_ID] = { | ^~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:65:26: warning: 'ISP_HMEM_BASE' defined but not used [-Wunused-const-variable=] 65 | static const hrt_address ISP_HMEM_BASE[N_HMEM_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:59:26: warning: 'ISP_VAMEM_BASE' defined but not used [-Wunused-const-variable=] 59 | static const hrt_address ISP_VAMEM_BASE[N_VAMEM_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:55:26: warning: 'ISP_BAMEM_BASE' defined but not used [-Wunused-const-variable=] 55 | static const hrt_address ISP_BAMEM_BASE[N_BAMEM_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:51:26: warning: 'ISP_DMEM_BASE' defined but not used [-Wunused-const-variable=] 51 | static const hrt_address ISP_DMEM_BASE[N_ISP_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:47:26: warning: 'ISP_CTRL_BASE' defined but not used [-Wunused-const-variable=] 47 | static const hrt_address ISP_CTRL_BASE[N_ISP_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:42:26: warning: 'DDR_BASE' defined but not used [-Wunused-const-variable=] 42 | static const hrt_address DDR_BASE[N_DDR_ID] = { | ^~~~~~~~ -- cc1: warning: drivers/staging/media/atomisp//pci/hive_isp_css_include/memory_access/: No such file or directory [-Wmissing-include-dirs] drivers/staging/media/atomisp/pci/atomisp_v4l2.c: In function 'is_valid_device': >> drivers/staging/media/atomisp/pci/atomisp_v4l2.c:1499:15: warning: variable 'a0_max_id' set but not used [-Wunused-but-set-variable] 1499 | unsigned int a0_max_id = 0; | ^~~~~~~~~ At top level: drivers/staging/media/atomisp/pci/atomisp_v4l2.c:769:12: warning: 'atomisp_mrfld_power' defined but not used [-Wunused-function] 769 | static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) | ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp/pci/atomisp_v4l2.c:395:40: warning: 'dfs_config_byt_cr' defined but not used [-Wunused-const-variable=] 395 | static const struct atomisp_dfs_config dfs_config_byt_cr = { | ^~~~~~~~~~~~~~~~~ In file included from drivers/staging/media/atomisp//pci/system_local.h:8, from drivers/staging/media/atomisp//pci/ia_css_acc_types.h:23, from drivers/staging/media/atomisp//pci/ia_css_pipe_public.h:29, from drivers/staging/media/atomisp/pci/sh_css_legacy.h:23, from drivers/staging/media/atomisp/pci/atomisp_internal.h:34, from drivers/staging/media/atomisp/pci/atomisp_cmd.h:30, from drivers/staging/media/atomisp/pci/atomisp_v4l2.c:33: drivers/staging/media/atomisp//pci/isp2401_system_local.h:217:26: warning: 'STREAM2MMIO_CTRL_BASE' defined but not used [-Wunused-const-variable=] 217 | static const hrt_address STREAM2MMIO_CTRL_BASE[N_STREAM2MMIO_ID] = { | ^~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:210:26: warning: 'PIXELGEN_CTRL_BASE' defined but not used [-Wunused-const-variable=] 210 | static const hrt_address PIXELGEN_CTRL_BASE[N_PIXELGEN_ID] = { | ^~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:203:26: warning: 'CSI_RX_BE_CTRL_BASE' defined but not used [-Wunused-const-variable=] 203 | static const hrt_address CSI_RX_BE_CTRL_BASE[N_CSI_RX_BACKEND_ID] = { | ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:196:26: warning: 'CSI_RX_FE_CTRL_BASE' defined but not used [-Wunused-const-variable=] 196 | static const hrt_address CSI_RX_FE_CTRL_BASE[N_CSI_RX_FRONTEND_ID] = { | ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:189:26: warning: 'ISYS_IRQ_BASE' defined but not used [-Wunused-const-variable=] 189 | static const hrt_address ISYS_IRQ_BASE[N_ISYS_IRQ_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:182:26: warning: 'IBUF_CTRL_BASE' defined but not used [-Wunused-const-variable=] 182 | static const hrt_address IBUF_CTRL_BASE[N_IBUF_CTRL_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:177:26: warning: 'RX_BASE' defined but not used [-Wunused-const-variable=] 177 | static const hrt_address RX_BASE[N_RX_ID] = { | ^~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:162:26: warning: 'INPUT_SYSTEM_BASE' defined but not used [-Wunused-const-variable=] 162 | static const hrt_address INPUT_SYSTEM_BASE[N_INPUT_SYSTEM_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:154:26: warning: 'INPUT_FORMATTER_BASE' defined but not used [-Wunused-const-variable=] 154 | static const hrt_address INPUT_FORMATTER_BASE[N_INPUT_FORMATTER_ID] = { | ^~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:149:26: warning: 'TIMED_CTRL_BASE' defined but not used [-Wunused-const-variable=] 149 | static const hrt_address TIMED_CTRL_BASE[N_TIMED_CTRL_ID] = { | ^~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:144:26: warning: 'GPIO_BASE' defined but not used [-Wunused-const-variable=] 144 | static const hrt_address GPIO_BASE[N_GPIO_ID] = { | ^~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:140:26: warning: 'GP_TIMER_BASE' defined but not used [-Wunused-const-variable=] 140 | static const hrt_address GP_TIMER_BASE = | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:133:26: warning: 'GP_DEVICE_BASE' defined but not used [-Wunused-const-variable=] 133 | static const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:120:26: warning: 'FIFO_MONITOR_BASE' defined but not used [-Wunused-const-variable=] 120 | static const hrt_address FIFO_MONITOR_BASE[N_FIFO_MONITOR_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:114:26: warning: 'GDC_BASE' defined but not used [-Wunused-const-variable=] 114 | static const hrt_address GDC_BASE[N_GDC_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:102:26: warning: 'IRQ_BASE' defined but not used [-Wunused-const-variable=] 102 | static const hrt_address IRQ_BASE[N_IRQ_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:97:26: warning: 'ISYS2401_DMA_BASE' defined but not used [-Wunused-const-variable=] 97 | static const hrt_address ISYS2401_DMA_BASE[N_ISYS2401_DMA_ID] = { | ^~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:93:26: warning: 'DMA_BASE' defined but not used [-Wunused-const-variable=] 93 | static const hrt_address DMA_BASE[N_DMA_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:84:26: warning: 'MMU_BASE' defined but not used [-Wunused-const-variable=] 84 | static const hrt_address MMU_BASE[N_MMU_ID] = { | ^~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:74:26: warning: 'SP_DMEM_BASE' defined but not used [-Wunused-const-variable=] 74 | static const hrt_address SP_DMEM_BASE[N_SP_ID] = { | ^~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:70:26: warning: 'SP_CTRL_BASE' defined but not used [-Wunused-const-variable=] 70 | static const hrt_address SP_CTRL_BASE[N_SP_ID] = { | ^~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:65:26: warning: 'ISP_HMEM_BASE' defined but not used [-Wunused-const-variable=] 65 | static const hrt_address ISP_HMEM_BASE[N_HMEM_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:59:26: warning: 'ISP_VAMEM_BASE' defined but not used [-Wunused-const-variable=] 59 | static const hrt_address ISP_VAMEM_BASE[N_VAMEM_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:55:26: warning: 'ISP_BAMEM_BASE' defined but not used [-Wunused-const-variable=] 55 | static const hrt_address ISP_BAMEM_BASE[N_BAMEM_ID] = { | ^~~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:51:26: warning: 'ISP_DMEM_BASE' defined but not used [-Wunused-const-variable=] 51 | static const hrt_address ISP_DMEM_BASE[N_ISP_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:47:26: warning: 'ISP_CTRL_BASE' defined but not used [-Wunused-const-variable=] 47 | static const hrt_address ISP_CTRL_BASE[N_ISP_ID] = { | ^~~~~~~~~~~~~ drivers/staging/media/atomisp//pci/isp2401_system_local.h:42:26: warning: 'DDR_BASE' defined but not used [-Wunused-const-variable=] 42 | static const hrt_address DDR_BASE[N_DDR_ID] = { | ^~~~~~~~ .. vim +/stream_config +2805 drivers/staging/media/atomisp/pci/atomisp_cmd.c ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2800 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2801 int atomisp_get_metadata(struct atomisp_sub_device *asd, int flag, ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2802 struct atomisp_metadata *md) ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2803 { ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2804 struct atomisp_device *isp = asd->isp; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 @2805 struct ia_css_stream_config *stream_config; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2806 struct ia_css_stream_info *stream_info; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2807 struct camera_mipi_info *mipi_info; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2808 struct atomisp_metadata_buf *md_buf; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2809 enum atomisp_metadata_type md_type = ATOMISP_MAIN_METADATA; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2810 int ret, i; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2811 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2812 if (flag != 0) ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2813 return -EINVAL; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2814 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2815 stream_config = &asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL]. ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2816 stream_config; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2817 stream_info = &asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL]. ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2818 stream_info; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2819 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2820 /* We always return the resolution and stride even if there is ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2821 * no valid metadata. This allows the caller to get the information ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2822 * needed to allocate user-space buffers. */ ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2823 md->width = stream_info->metadata_info.resolution.width; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2824 md->height = stream_info->metadata_info.resolution.height; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2825 md->stride = stream_info->metadata_info.stride; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2826 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2827 /* sanity check to avoid writing into unallocated memory. ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2828 * This does not return an error because it is a valid way ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2829 * for applications to detect that metadata is not enabled. */ ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2830 if (md->width == 0 || md->height == 0 || !md->data) ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2831 return 0; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2832 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2833 /* This is done in the atomisp_buf_done() */ ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2834 if (list_empty(&asd->metadata_ready[md_type])) { ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2835 dev_warn(isp->dev, "Metadata queue is empty now!\n"); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2836 return -EAGAIN; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2837 } ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2838 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2839 mipi_info = atomisp_to_sensor_mipi_info( ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2840 isp->inputs[asd->input_curr].camera); bdfe0beb95eebc8 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2841 if (!mipi_info) ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2842 return -EINVAL; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2843 bdfe0beb95eebc8 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2844 if (mipi_info->metadata_effective_width) { ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2845 for (i = 0; i < md->height; i++) ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2846 md->effective_width[i] = ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2847 mipi_info->metadata_effective_width[i]; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2848 } ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2849 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2850 md_buf = list_entry(asd->metadata_ready[md_type].next, ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2851 struct atomisp_metadata_buf, list); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2852 md->exp_id = md_buf->metadata->exp_id; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2853 if (md_buf->md_vptr) { ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2854 ret = copy_to_user(md->data, ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2855 md_buf->md_vptr, ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2856 stream_info->metadata_info.size); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2857 } else { ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2858 hmm_load(md_buf->metadata->address, ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2859 asd->params.metadata_user[md_type], ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2860 stream_info->metadata_info.size); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2861 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2862 ret = copy_to_user(md->data, ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2863 asd->params.metadata_user[md_type], ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2864 stream_info->metadata_info.size); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2865 } ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2866 if (ret) { ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2867 dev_err(isp->dev, "copy to user failed: copied %d bytes\n", ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2868 ret); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2869 return -EFAULT; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2870 } ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2871 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2872 list_del_init(&md_buf->list); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2873 list_add_tail(&md_buf->list, &asd->metadata[md_type]); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2874 ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2875 dev_dbg(isp->dev, "%s: HAL de-queued metadata type %d with exp_id %d\n", ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2876 __func__, md_type, md->exp_id); ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2877 return 0; ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2878 } ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 2879 :::::: The code at line 2805 was first introduced by commit :::::: ad85094b293e40e7a2f831b0311a389d952ebd5e Revert "media: staging: atomisp: Remove driver" :::::: TO: Mauro Carvalho Chehab :::::: CC: Mauro Carvalho Chehab --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org