From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
frankc@nvidia.com, hverkuil@xs4all.nl, luca@lucaceresoli.net,
leonl@leopardimaging.com, robh+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: media: imx274: Add optional input clock and supplies
Date: Fri, 31 Jul 2020 19:19:08 +0300 [thread overview]
Message-ID: <20200731161908.GA6401@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1595264494-2400-2-git-send-email-skomatineni@nvidia.com>
Hi Sowjanya,
On Mon, Jul 20, 2020 at 10:01:33AM -0700, Sowjanya Komatineni wrote:
> This patch adds IMX274 optional external clock input and voltage
> supplies to device tree bindings.
>
> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> index 80f2e89..0727079 100644
> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> @@ -13,6 +13,11 @@ Required Properties:
>
> Optional Properties:
> - reset-gpios: Sensor reset GPIO
> +- clocks: Reference to the input clock.
> +- clock-names: Should be "inck".
> +- VANA-supply: Sensor 2.8v analog supply.
> +- VDIG-supply: Sensor 1.8v digital core supply.
> +- VDDL-supply: Sensor digital IO 1.2v supply.
I believe lower case is preferred.
>
> The imx274 device node should contain one 'port' child node with
> an 'endpoint' subnode. For further reading on port node refer to
--
Sakari Ailus
next prev parent reply other threads:[~2020-07-31 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 17:01 [PATCH v3 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting Sowjanya Komatineni
2020-07-20 17:01 ` [PATCH v3 2/3] dt-bindings: media: imx274: Add optional input clock and supplies Sowjanya Komatineni
2020-07-31 16:19 ` Sakari Ailus [this message]
2020-07-31 16:28 ` Mark Brown
2020-07-20 17:01 ` [PATCH v3 3/3] media: i2c: imx274: Add IMX274 power on and off sequence Sowjanya Komatineni
2020-07-21 14:03 ` Luca Ceresoli
2020-07-21 14:28 ` Sowjanya Komatineni
2020-07-31 16:26 ` Sakari Ailus
2020-07-31 16:34 ` Sowjanya Komatineni
2020-08-13 22:01 ` Sakari Ailus
2020-08-27 22:55 ` Sowjanya Komatineni
2020-08-31 16:25 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731161908.GA6401@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frankc@nvidia.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=leonl@leopardimaging.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).