From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-media@vger.kernel.org, "Lad,
Prabhakar" <prabhakar.csengg@gmail.com>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
hverkuil-cisco@xs4all.nl, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: media: ov772x: Make bus-type mandatory
Date: Wed, 19 Aug 2020 16:52:42 +0300 [thread overview]
Message-ID: <20200819135242.GK6049@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200818122012.37956-3-jacopo+renesas@jmondi.org>
Hi Jacopo,
Thank you for the patch.
On Tue, Aug 18, 2020 at 02:20:11PM +0200, Jacopo Mondi wrote:
> In order to establish required properties based on the selected
> bus type, make the 'bus-type' property mandatory.
>
> Binary compatibility with existing DTB is kept as the driver does not
> enforce the property to be present, and shall fall-back to default
> parallel bus configuration, which was the only supported bus type, if
> the property is not specified.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ov772x.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml
> index 2b84fefeb4aa..75dad40f70cc 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml
> @@ -47,9 +47,15 @@ properties:
> endpoint:
> type: object
> properties:
> + bus-type:
> + enum: [5, 6]
> +
> remote-endpoint:
> description: A phandle to the bus receiver's endpoint node.
>
> + required:
> + - bus-type
> +
> additionalProperties: false
>
> required:
> @@ -75,6 +81,7 @@ examples:
>
> port {
> ov772x_0: endpoint {
> + bus-type = <5>;
> remote-endpoint = <&vcap1_in0>;
> };
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-08-19 13:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 12:20 [PATCH 0/3] dt-bindings: media: ov772x: Convert to json-schama Jacopo Mondi
2020-08-18 12:20 ` [PATCH 1/3] dt-bindings: media: ov772x: Convert to json-schema Jacopo Mondi
2020-08-19 13:52 ` Laurent Pinchart
2020-08-24 8:32 ` Jacopo Mondi
2020-08-24 11:34 ` Laurent Pinchart
2020-08-24 12:15 ` Jacopo Mondi
2020-08-24 12:14 ` Laurent Pinchart
2020-08-25 20:55 ` Rob Herring
2020-08-25 21:41 ` Laurent Pinchart
2020-08-21 11:26 ` Lad, Prabhakar
2020-08-25 21:03 ` Rob Herring
2020-08-18 12:20 ` [PATCH 2/3] dt-bindings: media: ov772x: Make bus-type mandatory Jacopo Mondi
2020-08-19 13:52 ` Laurent Pinchart [this message]
2020-08-21 11:29 ` Lad, Prabhakar
2020-08-25 21:06 ` Rob Herring
2020-08-18 12:20 ` [PATCH 3/3] dt-bindings: media: ov772x: Document endpoint props Jacopo Mondi
2020-08-19 13:54 ` Laurent Pinchart
2020-08-21 11:37 ` Lad, Prabhakar
2020-08-22 1:35 ` Laurent Pinchart
2020-08-26 8:42 ` Lad, Prabhakar
2020-08-24 8:35 ` Jacopo Mondi
2020-08-26 8:47 ` Lad, Prabhakar
-- strict thread matches above, loose matches on Subject: below --
2020-08-17 15:59 [PATCH 0/3] dt-bindings: media: ov772x: Convert to json-schama Jacopo Mondi
2020-08-17 15:59 ` [PATCH 2/3] dt-bindings: media: ov772x: Make bus-type mandatory Jacopo Mondi
2020-08-17 20:14 ` Sergei Shtylyov
2020-08-18 12:06 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819135242.GK6049@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).