From: Kaaira Gupta <kgupta@es.iitr.ac.in> To: Helen Koike <helen.koike@collabora.com>, Shuah Khan <skhan@linuxfoundation.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Kaaira Gupta <kgupta@es.iitr.ac.in> Subject: [PATCH v3 8/9] media: vimc: Join pipeline if one already exists Date: Wed, 19 Aug 2020 23:34:41 +0530 [thread overview] Message-ID: <20200819180442.11630-9-kgupta@es.iitr.ac.in> (raw) In-Reply-To: <20200819180442.11630-1-kgupta@es.iitr.ac.in> Start another capture, if one is already running, by checking for existing pipe. If it exists already, don't fail to start second capture, instead join it to the already running pipeline. Use the same stream struct used by already running capture. Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in> --- drivers/media/test-drivers/vimc/vimc-capture.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/media/test-drivers/vimc/vimc-capture.c b/drivers/media/test-drivers/vimc/vimc-capture.c index 73e5bdd17c57..4d20eda9335e 100644 --- a/drivers/media/test-drivers/vimc/vimc-capture.c +++ b/drivers/media/test-drivers/vimc/vimc-capture.c @@ -247,9 +247,15 @@ static int vimc_cap_start_streaming(struct vb2_queue *vq, unsigned int count) atomic_inc(&vcap->ved.use_count); vcap->sequence = 0; - stream = kzalloc(sizeof(*stream), GFP_ATOMIC); - kref_init(&stream->refcount); - pipe = &stream->pipe; + if (vcap->ved.ent->pipe) { + pipe = vcap->ved.ent->pipe; + stream = container_of(pipe, struct vimc_stream, pipe); + kref_get(&stream->refcount); + } else { + stream = kzalloc(sizeof(*stream), GFP_ATOMIC); + kref_init(&stream->refcount); + pipe = &stream->pipe; + } /* Start the media pipeline */ ret = media_pipeline_start(entity, pipe); -- 2.17.1
next prev parent reply other threads:[~2020-08-19 18:05 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-19 18:04 [PATCH v3 0/9] media: vimc: Multiple stream support in vimc Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 1/9] media: vimc: Move get_source_entity to vimc-common Kaaira Gupta 2020-08-20 15:32 ` Kieran Bingham 2020-08-19 18:04 ` [PATCH v3 2/9] media: vimc: Add get_frame callback Kaaira Gupta 2020-08-20 15:36 ` Kieran Bingham 2020-09-12 10:01 ` Kaaira Gupta 2020-10-02 11:08 ` Dafna Hirschfeld 2020-08-19 18:04 ` [PATCH v3 3/9] media: vimc: Add usage count to subdevices Kaaira Gupta 2020-10-02 11:13 ` Dafna Hirschfeld 2020-08-19 18:04 ` [PATCH v3 4/9] media: vimc: Separate starting stream from pipeline initialisation Kaaira Gupta 2020-08-21 15:11 ` Dafna Hirschfeld 2020-08-21 21:01 ` Kaaira Gupta 2020-08-28 20:37 ` Dafna Hirschfeld 2020-09-02 9:56 ` Kieran Bingham 2020-09-12 10:21 ` Kaaira Gupta 2020-09-12 10:16 ` Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 5/9] media: vimc: Separate closing of stream and thread Kaaira Gupta 2020-09-02 10:13 ` Kieran Bingham 2020-09-12 10:28 ` Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 6/9] media: vimc: Serialize vimc_streamer_s_stream() Kaaira Gupta 2020-08-19 18:04 ` [PATCH v3 7/9] media: vimc: Dynamically allocate stream struct Kaaira Gupta 2020-09-02 10:29 ` Kieran Bingham 2020-09-12 10:39 ` Kaaira Gupta 2020-08-19 18:04 ` Kaaira Gupta [this message] 2020-09-02 10:40 ` [PATCH v3 8/9] media: vimc: Join pipeline if one already exists Kieran Bingham 2020-08-19 18:04 ` [PATCH v3 9/9] media: vimc: Run multiple captures on same thread Kaaira Gupta 2020-09-02 10:46 ` Kieran Bingham 2020-09-12 10:45 ` Kaaira Gupta 2020-09-02 10:51 ` [PATCH v3 0/9] media: vimc: Multiple stream support in vimc Kieran Bingham 2020-09-12 10:49 ` Kaaira Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200819180442.11630-9-kgupta@es.iitr.ac.in \ --to=kgupta@es.iitr.ac.in \ --cc=helen.koike@collabora.com \ --cc=kieran.bingham@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=skhan@linuxfoundation.org \ --subject='Re: [PATCH v3 8/9] media: vimc: Join pipeline if one already exists' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).