From: Steven Rostedt <rostedt@goodmis.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed
Date: Thu, 20 Aug 2020 10:23:47 -0400 [thread overview]
Message-ID: <20200820102347.15d2f610@oasis.local.home> (raw)
In-Reply-To: <20200820170951.v4.3.I066d89f39023956c47fb0a42edf196b3950ffbf7@changeid>
On Thu, 20 Aug 2020 17:14:12 +0800
Nicolas Boichat <drinkcat@chromium.org> wrote:
> Technically, we could only initialize the trace_printk buffers
> when the print env is switched, to avoid the build error and
> unconditional boot-time warning, but I assume this printing
> framework will eventually get removed when the driver moves out
> of staging?
Perhaps this should be converting into a trace event. Look at what bpf
did for their bpf_trace_printk().
The more I think about it, the less I like this series.
-- Steve
next prev parent reply other threads:[~2020-08-20 14:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 9:14 [PATCH v4 1/3, RESEND] media: camss: vfe: Use trace_printk for debugging only Nicolas Boichat
2020-08-20 9:14 ` [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed Nicolas Boichat
2020-08-20 14:23 ` Steven Rostedt [this message]
2020-08-21 0:13 ` Nicolas Boichat
2020-08-21 0:36 ` Steven Rostedt
2020-08-21 1:39 ` Nicolas Boichat
2020-08-21 1:57 ` Steven Rostedt
2020-08-21 2:36 ` Joe Perches
2020-08-21 2:42 ` Nicolas Boichat
2020-08-21 2:49 ` Joe Perches
2020-08-21 3:04 ` Steven Rostedt
2020-08-21 3:08 ` Steven Rostedt
2020-08-21 2:44 ` Steven Rostedt
2020-08-21 2:39 ` Nicolas Boichat
2020-08-21 3:01 ` Steven Rostedt
2020-08-21 12:19 ` Nicolas Boichat
2020-08-21 8:48 ` David Laight
2020-08-21 10:27 ` Nicolas Boichat
2020-08-21 11:32 ` David Laight
2020-08-21 12:07 ` Nicolas Boichat
2020-08-21 12:18 ` David Laight
2020-08-21 12:37 ` Nicolas Boichat
2020-08-20 14:21 ` [PATCH v4 1/3, RESEND] media: camss: vfe: Use trace_printk for debugging only Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820102347.15d2f610@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).