From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B55E6C433E1 for ; Mon, 24 Aug 2020 10:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DE422071E for ; Mon, 24 Aug 2020 10:01:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbgHXIcO (ORCPT ); Mon, 24 Aug 2020 04:32:14 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:58461 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgHXIcL (ORCPT ); Mon, 24 Aug 2020 04:32:11 -0400 X-Originating-IP: 93.34.118.233 Received: from uno.localdomain (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 7E4B81BF207; Mon, 24 Aug 2020 08:32:06 +0000 (UTC) Date: Mon, 24 Aug 2020 10:35:52 +0200 From: Jacopo Mondi To: "Lad, Prabhakar" Cc: Laurent Pinchart , Jacopo Mondi , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-media , Mauro Carvalho Chehab , Sakari Ailus , Hans Verkuil , Linux-Renesas Subject: Re: [PATCH 3/3] dt-bindings: media: ov772x: Document endpoint props Message-ID: <20200824083552.v7s5gggqcviigvzu@uno.localdomain> References: <20200818122012.37956-1-jacopo+renesas@jmondi.org> <20200818122012.37956-4-jacopo+renesas@jmondi.org> <20200819135423.GL6049@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Laurent, Prabhakar, On Fri, Aug 21, 2020 at 12:37:35PM +0100, Lad, Prabhakar wrote: > Hi Laurent and Jacopo > > On Wed, Aug 19, 2020 at 2:54 PM Laurent Pinchart > wrote: > > > > Hi Jacopo, > > > > Thank you for the patch. > > > > On Tue, Aug 18, 2020 at 02:20:12PM +0200, Jacopo Mondi wrote: > > > Document endpoint properties for the parallel bus type and > > > add them to the example. > > > > > > Specify a few constraints: > > > - If the bus type is BT.656 no hsync or vsycn polarities can be > > > specified. > > > - If the bus width is 10 bits, not data-shift can be applied. > > > > > > Signed-off-by: Jacopo Mondi > > > --- > > > .../devicetree/bindings/media/i2c/ov772x.yaml | 43 +++++++++++++++++++ > > > 1 file changed, 43 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml > > > index 75dad40f70cc..3fad5dffd19a 100644 > > > --- a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml > > > +++ b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml > > > @@ -50,9 +50,47 @@ properties: > > > bus-type: > > > enum: [5, 6] > > > > > > + bus-width: > > > + enum: [8, 10] > > > + default: 10 > > > + > > > + data-shift: > > > + enum: [0, 2] > > > + default: 0 > > > + > > > + hsync-active: > > > + enum: [0, 1] > > > + default: 1 > > > + > > > + vsync-active: > > > + enum: [0, 1] > > > + default: 1 > > > + > > > + pclk-sample: > > > + enum: [0, 1] > > > + default: 1 > > > + > > > remote-endpoint: > > > description: A phandle to the bus receiver's endpoint node. > > > > > > + allOf: > > > + - if: > > > + properties: > > > + bus-type: > > > + const: 6 > > > + then: > > > + properties: > > > + hsync-active: false > > > + vsync-active: false > > > + > > > + - if: > > > + properties: > > > + bus-width: > > > + const: 10 > > > + then: > > > + properties: > > > + data-shift: > > > + const: 0 > > > > I'd add a blank line here. > > > > > required: > > > - bus-type > > > > Should some of the properties be required ? Possibly conditioned on > > bus-type ? > > I am not sure. They all have defaults, as reported here and as supported by the driver. There's nothing -strictly- required, as long as the here reported defaults are correct. > Agreed, would be interesting to know how this can be handled (split > out bus-type and add required properties for each) ? > That already happens with + - if: + properties: + bus-type: + const: 6 + then: + properties: + hsync-active: false + vsync-active: false And could be expanded, if we want any of these to be required. Thanks j > Cheers, > Prabhakar > > > > > > > @@ -82,6 +120,11 @@ examples: > > > port { > > > ov772x_0: endpoint { > > > bus-type = <5>; > > > + vsync-active = <0>; > > > + hsync-active = <0>; > > > + pclk-sample = <0>; > > > + bus-width = <8>; > > > + data-shift = <0>; > > > remote-endpoint = <&vcap1_in0>; > > > }; > > > }; > > > > -- > > Regards, > > > > Laurent Pinchart