From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Cengiz Can <cengiz@kernel.wtf>
Cc: dan.carpenter@oracle.com, andriy.shevchenko@linux.intel.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com
Subject: Re: [PATCH v2] staging: atomisp: Remove unnecessary 'fallthrough'
Date: Mon, 31 Aug 2020 09:28:48 -0500 [thread overview]
Message-ID: <20200831142848.GF2671@embeddedor> (raw)
In-Reply-To: <20200831135103.93399-1-cengiz@kernel.wtf>
On Mon, Aug 31, 2020 at 04:51:04PM +0300, Cengiz Can wrote:
> commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from
> Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments
> with 'fallthrough' pseudo-keyword.
>
> However, in one of the switch-case statements, Coverity Static Analyzer
> throws a warning that 'fallthrough' is unreachable due to the adjacent
> 'return false' statement. (Coverity ID CID 1466511)
>
> In order to fix the unreachable code warning, remove unnecessary
> fallthrough keyword.
>
> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> index 1b2b2c68025b..feb26c221e96 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> @@ -711,7 +711,6 @@ static bool is_pipe_valid_to_current_run_mode(struct atomisp_sub_device *asd,
> return true;
>
> return false;
> - fallthrough;
> case ATOMISP_RUN_MODE_VIDEO:
> if (!asd->continuous_mode->val) {
> if (pipe_id == IA_CSS_PIPE_ID_VIDEO ||
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-08-31 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 13:30 [PATCH] staging: atomisp: Fix fallthrough keyword warning Cengiz Can
2020-08-31 13:40 ` Dan Carpenter
2020-08-31 13:45 ` Dan Carpenter
2020-08-31 13:51 ` [PATCH v2] staging: atomisp: Remove unnecessary 'fallthrough' Cengiz Can
2020-08-31 14:28 ` Gustavo A. R. Silva [this message]
2020-08-31 14:35 ` [PATCH] staging: atomisp: Fix fallthrough keyword warning Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831142848.GF2671@embeddedor \
--to=gustavoars@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cengiz@kernel.wtf \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).