From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4355CC433E2 for ; Mon, 31 Aug 2020 20:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C6612087D for ; Mon, 31 Aug 2020 20:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729939AbgHaUSQ (ORCPT ); Mon, 31 Aug 2020 16:18:16 -0400 Received: from retiisi.org.uk ([95.216.213.190]:34418 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728129AbgHaUSQ (ORCPT ); Mon, 31 Aug 2020 16:18:16 -0400 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id E8FD8634C87; Mon, 31 Aug 2020 23:17:57 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1kCqFZ-0000z4-RL; Mon, 31 Aug 2020 23:17:57 +0300 Date: Mon, 31 Aug 2020 23:17:57 +0300 From: Sakari Ailus To: Sowjanya Komatineni Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, hverkuil@xs4all.nl, luca@lucaceresoli.net, leonl@leopardimaging.com, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] dt-bindings: media: imx274: Move clock and supplies to required properties Message-ID: <20200831201757.GC844@valkosipuli.retiisi.org.uk> References: <1598903558-9691-1-git-send-email-skomatineni@nvidia.com> <1598903558-9691-4-git-send-email-skomatineni@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598903558-9691-4-git-send-email-skomatineni@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Sowjanya, On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote: > Clock and supplies are external to IMX274 sensor and are dependent > on camera module design. > > So, this patch moves them to required properties. > > Signed-off-by: Sowjanya Komatineni > --- > Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt > index d0a5c899..b43bed6 100644 > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt > +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt > @@ -10,15 +10,15 @@ at 1440 Mbps. > Required Properties: > - compatible: value should be "sony,imx274" for imx274 sensor > - reg: I2C bus address of the device > - > -Optional Properties: > -- reset-gpios: Sensor reset GPIO > - clocks: Reference to the input clock. > - clock-names: Should be "inck". > - vana-supply: Sensor 2.8v analog supply. > - vdig-supply: Sensor 1.8v digital core supply. > - vddl-supply: Sensor digital IO 1.2v supply. If these have been optional in the past I don't think we can start requiring them now. The framework will just give the driver a dummy regulator if one isn't found. > > +Optional Properties: > +- reset-gpios: Sensor reset GPIO > + > The imx274 device node should contain one 'port' child node with > an 'endpoint' subnode. For further reading on port node refer to > Documentation/devicetree/bindings/media/video-interfaces.txt. -- Kind regards, Sakari Ailus