From: Jacopo Mondi <jacopo@jmondi.org>
To: Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
sakari.ailus@iki.fi, hverkuil@xs4all.nl,
jacopo+renesas@jmondi.org, luca@lucaceresoli.net,
leonl@leopardimaging.com, robh+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies
Date: Thu, 3 Sep 2020 14:55:42 +0200 [thread overview]
Message-ID: <20200903125542.nxiafnysatoexken@uno.localdomain> (raw)
In-Reply-To: <1599012278-10203-3-git-send-email-skomatineni@nvidia.com>
Hello Sowjanya,
On Tue, Sep 01, 2020 at 07:04:37PM -0700, Sowjanya Komatineni wrote:
> This patch adds IMX274 optional external clock input and voltage
> supplies to device tree bindings.
>
> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> .../devicetree/bindings/media/i2c/sony,imx274.yaml | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> index 7ae47a6..57e7176 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> @@ -25,6 +25,27 @@ properties:
> reset-gpios:
> maxItems: 1
>
I just sent an update to my json-schema conversion of this bindings
document (not yet on patchwork, sorry) and Sakari pointed me to the
fact in between my v2 and my v4 this patch from you went in:
4ea3273d24b ("dt-bindings: media: imx274: Add optional input clock and supplies")
I should probably now update my bindings conversion patch, basically
taking in what you've done here, but I would have one question.
> + clocks:
> + maxItems: 1
> + description: Reference to the sensor input clock
> +
> + clock-names:
> + maxItems: 1
> + items:
> + - const: inck
> +
> + vana-supply:
> + description:
> + Analog voltage supply, 2.8 volts
> +
> + vdig-supply:
> + description:
> + Digital IO voltage supply, 1.8 volts
> +
> + vddl-supply:
> + description:
> + Digital core voltage supply, 1.2 volts
4ea3273d24b introduced these regulators as VANA-supply, VDIG-supply
and VDDL-supply (please note the upper-case names). This version uses
lower-case ones instead. Is this intentional ? The driver currently
does not parse any of these if I'm not mistaken, but as the bindings
in textual form defines an ABI which should be preserved during the
conversion to json-schema, should these be kept in upper-case ?
Thanks
j
> +
> port:
> type: object
> description: |
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-09-03 12:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 2:04 [PATCH v5 0/3] IMX274 fixes and power on and off implementation Sowjanya Komatineni
2020-09-02 2:04 ` [PATCH v5 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting Sowjanya Komatineni
2020-09-02 2:04 ` [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies Sowjanya Komatineni
2020-09-02 6:46 ` Luca Ceresoli
2020-09-02 6:52 ` Luca Ceresoli
2020-09-03 12:55 ` Jacopo Mondi [this message]
2020-09-03 16:05 ` Sowjanya Komatineni
2020-09-03 16:35 ` Jacopo Mondi
2020-09-03 16:40 ` Sowjanya Komatineni
2020-09-08 9:33 ` Sakari Ailus
2020-09-08 14:34 ` Jacopo Mondi
2020-09-08 18:10 ` Sowjanya Komatineni
2020-09-02 2:04 ` [PATCH v5 3/3] media: i2c: imx274: Add IMX274 power on and off sequence Sowjanya Komatineni
2020-09-03 15:03 ` Jacopo Mondi
2020-09-03 16:25 ` Sowjanya Komatineni
2020-09-04 8:55 ` Jacopo Mondi
[not found] ` <5ebe8d22-86fb-7bf2-ab19-e729caf8d88f@nvidia.com>
2020-09-07 7:48 ` Jacopo Mondi
2020-09-08 18:13 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903125542.nxiafnysatoexken@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=jonathanh@nvidia.com \
--cc=leonl@leopardimaging.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).