From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BBF6C4727E for ; Tue, 22 Sep 2020 08:49:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16808221EB for ; Tue, 22 Sep 2020 08:49:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726430AbgIVIs5 (ORCPT ); Tue, 22 Sep 2020 04:48:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbgIVIs4 (ORCPT ); Tue, 22 Sep 2020 04:48:56 -0400 Received: from hillosipuli.retiisi.org.uk (hillosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::81:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D85C061755; Tue, 22 Sep 2020 01:48:56 -0700 (PDT) Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 03C27634C87; Tue, 22 Sep 2020 11:47:46 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1kKdxj-0002fR-3R; Tue, 22 Sep 2020 11:47:47 +0300 Date: Tue, 22 Sep 2020 11:47:47 +0300 From: Sakari Ailus To: Luca Ceresoli Cc: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, hverkuil@xs4all.nl, jacopo+renesas@jmondi.org, leonl@leopardimaging.com, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/3] media: i2c: imx274: Remove stop stream i2c writes during remove Message-ID: <20200922084746.GA8644@valkosipuli.retiisi.org.uk> References: <1600724379-7324-1-git-send-email-skomatineni@nvidia.com> <1600724379-7324-3-git-send-email-skomatineni@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Luca, On Tue, Sep 22, 2020 at 10:09:33AM +0200, Luca Ceresoli wrote: > Hi, > > On 21/09/20 23:39, Sowjanya Komatineni wrote: > > Sensor should already be in standby during remove and there is no > > need to configure sensor registers for stream stop. > > I beg your pardon for the newbie question: does the V4L2 framework > guarantee that the stream is stopped (.s_stream(..., 0)) before removing > the driver? It doesn't. That's however one of the lesser concerns, and I don't think it'd help if drivers tried to prepare for that. -- Sakari Ailus