From: Yu Kuai <yukuai3@huawei.com>
To: <rick.chang@mediatek.com>, <bin.liu@mediatek.com>,
<mchehab@kernel.org>, <matthias.bgg@gmail.com>,
<tiffany.lin@mediatek.com>, <andrew-ct.chen@mediatek.com>,
<tfiga@chromium.org>, <xia.jiang@mediatek.com>,
<hverkuil-cisco@xs4all.nl>, <jcliang@chromium.org>,
<minghsiu.tsai@mediatek.com>
Cc: <linux-media@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <yukuai3@huawei.com>,
<yi.zhang@huawei.com>
Subject: [PATCH 1/7] media: platform: add missing put_device() call in mtk_jpeg_clk_init()
Date: Fri, 9 Oct 2020 20:37:58 +0800 [thread overview]
Message-ID: <20201009123804.3977562-2-yukuai3@huawei.com> (raw)
In-Reply-To: <20201009123804.3977562-1-yukuai3@huawei.com>
if of_find_device_by_node() succeed, mtk_jpeg_clk_init() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
Fixes: 648372a87cee ("media: platform: Change the call functions of getting/enable/disable the jpeg's clock")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 227245ccaedc..106543391c46 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1306,6 +1306,7 @@ static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg)
jpeg->variant->clks);
if (ret) {
dev_err(&pdev->dev, "failed to get jpeg clock:%d\n", ret);
+ put_device(&pdev->dev);
return ret;
}
--
2.25.4
next prev parent reply other threads:[~2020-10-09 12:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 12:37 [PATCH V2 0/7] patches to add missing put_device() call Yu Kuai
2020-10-09 12:37 ` Yu Kuai [this message]
2020-10-09 12:37 ` [PATCH 2/7] media: platform: add missing put_device() call in mtk_jpeg_probe() Yu Kuai
2020-10-30 9:46 ` Hans Verkuil
2020-10-09 12:38 ` [PATCH 3/7] media: platform: add missing put_device() call in mtk_jpeg_remove() Yu Kuai
2020-10-09 12:38 ` [PATCH 4/7] media: mtk-vcodec: add missing put_device() call in mtk_vcodec_init_dec_pm() Yu Kuai
2020-10-09 12:38 ` [PATCH 5/7] media: mtk-vcodec: add missing put_device() call in mtk_vcodec_release_dec_pm() Yu Kuai
2020-10-09 12:38 ` [PATCH 6/7] media: mtk-vcodec: add missing put_device() call in mtk_vcodec_init_enc_pm() Yu Kuai
2020-10-09 12:38 ` [PATCH 7/7] media: mtk-vcodec: add missing put_device() call in mtk_vcodec_release_enc_pm() Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009123804.3977562-2-yukuai3@huawei.com \
--to=yukuai3@huawei.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=bin.liu@mediatek.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jcliang@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=minghsiu.tsai@mediatek.com \
--cc=rick.chang@mediatek.com \
--cc=tfiga@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=xia.jiang@mediatek.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).