From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, Tsuchiya Yuto <kitakar@gmail.com>,
bingbu.cao@intel.com, Yong Zhi <yong.zhi@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>
Subject: Re: [PATCH 5/5] ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONE
Date: Fri, 9 Oct 2020 20:10:57 +0300 [thread overview]
Message-ID: <20201009171057.GB3935@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20201009150756.3397-6-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Fri, Oct 09, 2020 at 06:07:56PM +0300, Sakari Ailus wrote:
> The ipu3-cio2 doesn't make use of the field and this is reflected in V4L2
> buffers as well as the try format. Do this in active format, too.
>
> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index 9726091c9985..a821c40627f9 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1284,6 +1284,7 @@ static int cio2_subdev_set_fmt(struct v4l2_subdev *sd,
>
> fmt->format.width = min(fmt->format.width, CIO2_IMAGE_MAX_WIDTH);
> fmt->format.height = min(fmt->format.height, CIO2_IMAGE_MAX_LENGTH);
> + fmt->format.field = V4L2_FIELD_NONE;
>
> mutex_lock(&q->subdev_lock);
> *mbus = fmt->format;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-10-09 17:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:07 [PATCH 0/5] ipu3-cio2 format fixes Sakari Ailus
2020-10-09 15:07 ` [PATCH 1/5] ipu3-cio2: Return actual subdev format Sakari Ailus
2020-10-12 1:50 ` Cao, Bingbu
2020-10-09 15:07 ` [PATCH 2/5] ipu3-cio2: Serialise access to pad format Sakari Ailus
2020-10-09 16:19 ` Andy Shevchenko
2020-10-12 1:34 ` Cao, Bingbu
2020-10-09 15:07 ` [PATCH 3/5] ipu3-cio2: Use unsigned values where appropriate Sakari Ailus
2020-10-09 17:16 ` Laurent Pinchart
2020-10-12 9:02 ` Sakari Ailus
2020-10-09 15:07 ` [PATCH 4/5] ipu3-cio2: Validate mbus format in setting subdev format Sakari Ailus
2020-10-09 16:22 ` Andy Shevchenko
2020-10-12 9:26 ` Sakari Ailus
2020-10-09 17:14 ` Laurent Pinchart
2020-10-09 15:07 ` [PATCH 5/5] ipu3-cio2: Make the field on subdev format V4L2_FIELD_NONE Sakari Ailus
2020-10-09 17:10 ` Laurent Pinchart [this message]
2020-10-12 1:44 ` Cao, Bingbu
2020-10-09 15:08 ` [PATCH 0/5] ipu3-cio2 format fixes Sakari Ailus
2020-10-09 16:23 ` Andy Shevchenko
2020-10-12 8:13 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009171057.GB3935@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bingbu.cao@intel.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).