From: Rob Herring <robh@kernel.org>
To: Rui Miguel Silva <rmfrfs@gmail.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
sakari.ailus@linux.intel.com, Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: ov2680: convert bindings to yaml
Date: Mon, 19 Oct 2020 15:33:59 -0500 [thread overview]
Message-ID: <20201019203359.GA3550266@bogus> (raw)
In-Reply-To: <20201016144204.3viee7spmvwtms5i@arch-thunder.localdomain>
On Fri, Oct 16, 2020 at 03:42:04PM +0100, Rui Miguel Silva wrote:
> Hey Jacopo,
> Thanks for the review.
>
> On Thu, Oct 15, 2020 at 04:49:05PM +0200, Jacopo Mondi wrote:
> > Hi Rui,
> >
> > On Wed, Oct 14, 2020 at 03:27:57PM +0100, Rui Miguel Silva wrote:
> > > Convert ov2680 sensor bindings documentation to yaml schema, remove
> > > the textual bindings document and update MAINTAINERS entry.
> > >
> > > Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
> > > + clock-names:
> > > + description:
> >
> > I'll never get yaml right, doesn't breaking lines require '|' after
> > the semicolon ? The validator does not complain, so I guess not.
>
> I also had that idea, but looking also to other cases, and also in the
> examlpe-schema where you have both cases, looks like it is not needed.
'|' will preserve line breaks and formatting. For a single line like
this it doesn't really matter. Though ruamel's round trip will make it a
single line when writing back out.
> >
> > > + Input clock for the sensor.
Really, you can just drop the description. Doesn't really add anything
specific for this device.
> > > + items:
> > > + - const: xvclk
next prev parent reply other threads:[~2020-10-19 20:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 14:27 [PATCH v2 0/3] dt-bindings: media: imx7 and ov2680 updates to yaml Rui Miguel Silva
2020-10-14 14:27 ` [PATCH v2 1/3] dt-bindings: ov2680: convert bindings " Rui Miguel Silva
2020-10-15 14:49 ` Jacopo Mondi
2020-10-16 14:42 ` Rui Miguel Silva
2020-10-19 20:33 ` Rob Herring [this message]
2020-10-21 15:52 ` Jacopo Mondi
2020-12-01 22:44 ` Rob Herring
2020-10-19 20:39 ` Rob Herring
2020-10-20 9:09 ` Rui Miguel Silva
2020-10-14 14:27 ` [PATCH v2 2/3] dt-bindings: imx7-csi: " Rui Miguel Silva
2020-10-15 15:25 ` Jacopo Mondi
2020-10-16 14:44 ` Rui Miguel Silva
2020-10-14 14:27 ` [PATCH v2 3/3] dt-bindings: imx7-mipi-csi2: " Rui Miguel Silva
2020-10-15 15:52 ` Jacopo Mondi
2020-10-16 14:51 ` Rui Miguel Silva
2020-10-16 18:02 ` Jacopo Mondi
2020-10-19 14:29 ` Rui Miguel Silva
2020-10-16 15:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019203359.GA3550266@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=linux-media@vger.kernel.org \
--cc=rmfrfs@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).