linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikhil Devshatwar <nikhil.nd@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: <linux-media@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Benoit Parrot <bparrot@ti.com>, Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
Date: Tue, 20 Oct 2020 13:08:17 +0530	[thread overview]
Message-ID: <20201020073817.3cug7vgaezf3vj67@NiksLab> (raw)
In-Reply-To: <67d3fae1-5ba6-9f9a-3036-5752e3f6849d@ti.com>

On 14:38-20201019, Tomi Valkeinen wrote:
> On 12/10/2020 15:52, Nikhil Devshatwar wrote:
> > vpdma firmware is now available in the linux-firmware repo.
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
> > 
> > Update the firmware path requested by the VPDMA driver so that
> > it gets looked up correctly in the filesystem.
> > 
> > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > ---
> >  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> > index 2e5148ae7a0f..5a378449a4ff 100644
> > --- a/drivers/media/platform/ti-vpe/vpdma.c
> > +++ b/drivers/media/platform/ti-vpe/vpdma.c
> > @@ -23,7 +23,7 @@
> >  #include "vpdma.h"
> >  #include "vpdma_priv.h"
> >  
> > -#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
> > +#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
> 
> I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for
> directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.

The firmware is already merged at ti-connectivity/
I didn't create a new folder because I felt the exising ti-connectivity
is good enough.

> 
>  Tomi
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2020-10-20  7:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 12:52 [PATCH] media: platform: ti-vpe: Update the path to firmware Nikhil Devshatwar
2020-10-12 12:53 ` Laurent Pinchart
2020-10-19 11:38 ` Tomi Valkeinen
2020-10-20  7:38   ` Nikhil Devshatwar [this message]
2020-10-20  7:52     ` Tomi Valkeinen
2020-10-22 11:45       ` Nikhil Devshatwar
2020-10-30  9:57 ` Hans Verkuil
2020-10-30 14:03   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201020073817.3cug7vgaezf3vj67@NiksLab \
    --to=nikhil.nd@ti.com \
    --cc=bparrot@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).