Linux-Media Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] media: platform: ti-vpe: Update the path to firmware
@ 2020-10-12 12:52 Nikhil Devshatwar
  2020-10-12 12:53 ` Laurent Pinchart
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Nikhil Devshatwar @ 2020-10-12 12:52 UTC (permalink / raw)
  To: linux-media, Laurent Pinchart; +Cc: Benoit Parrot, Tomi Valkeinen, Sekhar Nori

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that
it gets looked up correctly in the filesystem.

Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
index 2e5148ae7a0f..5a378449a4ff 100644
--- a/drivers/media/platform/ti-vpe/vpdma.c
+++ b/drivers/media/platform/ti-vpe/vpdma.c
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
 
 const struct vpdma_data_format vpdma_yuv_fmts[] = {
 	[VPDMA_DATA_FMT_Y444] = {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
  2020-10-12 12:52 [PATCH] media: platform: ti-vpe: Update the path to firmware Nikhil Devshatwar
@ 2020-10-12 12:53 ` Laurent Pinchart
  2020-10-19 11:38 ` Tomi Valkeinen
  2020-10-30  9:57 ` Hans Verkuil
  2 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2020-10-12 12:53 UTC (permalink / raw)
  To: Nikhil Devshatwar; +Cc: linux-media, Benoit Parrot, Tomi Valkeinen, Sekhar Nori

Hi Nikhil,

Thank you for the patch.

On Mon, Oct 12, 2020 at 06:22:00PM +0530, Nikhil Devshatwar wrote:
> vpdma firmware is now available in the linux-firmware repo.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
> 
> Update the firmware path requested by the VPDMA driver so that
> it gets looked up correctly in the filesystem.
> 
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 2e5148ae7a0f..5a378449a4ff 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -23,7 +23,7 @@
>  #include "vpdma.h"
>  #include "vpdma_priv.h"
>  
> -#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
> +#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
>  
>  const struct vpdma_data_format vpdma_yuv_fmts[] = {
>  	[VPDMA_DATA_FMT_Y444] = {

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
  2020-10-12 12:52 [PATCH] media: platform: ti-vpe: Update the path to firmware Nikhil Devshatwar
  2020-10-12 12:53 ` Laurent Pinchart
@ 2020-10-19 11:38 ` Tomi Valkeinen
  2020-10-20  7:38   ` Nikhil Devshatwar
  2020-10-30  9:57 ` Hans Verkuil
  2 siblings, 1 reply; 8+ messages in thread
From: Tomi Valkeinen @ 2020-10-19 11:38 UTC (permalink / raw)
  To: Nikhil Devshatwar, linux-media, Laurent Pinchart
  Cc: Benoit Parrot, Sekhar Nori

On 12/10/2020 15:52, Nikhil Devshatwar wrote:
> vpdma firmware is now available in the linux-firmware repo.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
> 
> Update the firmware path requested by the VPDMA driver so that
> it gets looked up correctly in the filesystem.
> 
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> ---
>  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 2e5148ae7a0f..5a378449a4ff 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -23,7 +23,7 @@
>  #include "vpdma.h"
>  #include "vpdma_priv.h"
>  
> -#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
> +#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"

I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for
directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
  2020-10-19 11:38 ` Tomi Valkeinen
@ 2020-10-20  7:38   ` Nikhil Devshatwar
  2020-10-20  7:52     ` Tomi Valkeinen
  0 siblings, 1 reply; 8+ messages in thread
From: Nikhil Devshatwar @ 2020-10-20  7:38 UTC (permalink / raw)
  To: Tomi Valkeinen; +Cc: linux-media, Laurent Pinchart, Benoit Parrot, Sekhar Nori

On 14:38-20201019, Tomi Valkeinen wrote:
> On 12/10/2020 15:52, Nikhil Devshatwar wrote:
> > vpdma firmware is now available in the linux-firmware repo.
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
> > 
> > Update the firmware path requested by the VPDMA driver so that
> > it gets looked up correctly in the filesystem.
> > 
> > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > ---
> >  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> > index 2e5148ae7a0f..5a378449a4ff 100644
> > --- a/drivers/media/platform/ti-vpe/vpdma.c
> > +++ b/drivers/media/platform/ti-vpe/vpdma.c
> > @@ -23,7 +23,7 @@
> >  #include "vpdma.h"
> >  #include "vpdma_priv.h"
> >  
> > -#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
> > +#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
> 
> I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for
> directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.

The firmware is already merged at ti-connectivity/
I didn't create a new folder because I felt the exising ti-connectivity
is good enough.

> 
>  Tomi
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
  2020-10-20  7:38   ` Nikhil Devshatwar
@ 2020-10-20  7:52     ` Tomi Valkeinen
  2020-10-22 11:45       ` Nikhil Devshatwar
  0 siblings, 1 reply; 8+ messages in thread
From: Tomi Valkeinen @ 2020-10-20  7:52 UTC (permalink / raw)
  To: Nikhil Devshatwar
  Cc: linux-media, Laurent Pinchart, Benoit Parrot, Sekhar Nori

On 20/10/2020 10:38, Nikhil Devshatwar wrote:
> On 14:38-20201019, Tomi Valkeinen wrote:
>> On 12/10/2020 15:52, Nikhil Devshatwar wrote:
>>> vpdma firmware is now available in the linux-firmware repo.
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
>>>
>>> Update the firmware path requested by the VPDMA driver so that
>>> it gets looked up correctly in the filesystem.
>>>
>>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
>>> ---
>>>  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
>>> index 2e5148ae7a0f..5a378449a4ff 100644
>>> --- a/drivers/media/platform/ti-vpe/vpdma.c
>>> +++ b/drivers/media/platform/ti-vpe/vpdma.c
>>> @@ -23,7 +23,7 @@
>>>  #include "vpdma.h"
>>>  #include "vpdma_priv.h"
>>>  
>>> -#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
>>> +#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
>>
>> I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for
>> directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.
> 
> The firmware is already merged at ti-connectivity/
> I didn't create a new folder because I felt the exising ti-connectivity
> is good enough.

ti-connectivity is for TI wlan, no? I think the fw should either be in the root dir, as that's where
the driver has been loading it from for a long time, or if we're going to change the path in the
driver, put it into a proper directory.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
  2020-10-20  7:52     ` Tomi Valkeinen
@ 2020-10-22 11:45       ` Nikhil Devshatwar
  0 siblings, 0 replies; 8+ messages in thread
From: Nikhil Devshatwar @ 2020-10-22 11:45 UTC (permalink / raw)
  To: Tomi Valkeinen; +Cc: linux-media, Laurent Pinchart, Benoit Parrot, Sekhar Nori

On 10:52-20201020, Tomi Valkeinen wrote:
> On 20/10/2020 10:38, Nikhil Devshatwar wrote:
> > On 14:38-20201019, Tomi Valkeinen wrote:
> >> On 12/10/2020 15:52, Nikhil Devshatwar wrote:
> >>> vpdma firmware is now available in the linux-firmware repo.
> >>>
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
> >>>
> >>> Update the firmware path requested by the VPDMA driver so that
> >>> it gets looked up correctly in the filesystem.
> >>>
> >>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> >>> ---
> >>>  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> >>> index 2e5148ae7a0f..5a378449a4ff 100644
> >>> --- a/drivers/media/platform/ti-vpe/vpdma.c
> >>> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> >>> @@ -23,7 +23,7 @@
> >>>  #include "vpdma.h"
> >>>  #include "vpdma_priv.h"
> >>>  
> >>> -#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
> >>> +#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
> >>
> >> I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for
> >> directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.
> > 
> > The firmware is already merged at ti-connectivity/
> > I didn't create a new folder because I felt the exising ti-connectivity
> > is good enough.
> 
> ti-connectivity is for TI wlan, no?
I didn't know that. I assumed all ti firmwares regarding connectivity go
here :)
I am not sure if the linux-firmware accept moving firmware path.
I can try posting the patch and see what's the feedback.

> I think the fw should either be in the root dir, as that's where
> the driver has been loading it from for a long time, or if we're going to change the path in the
> driver, put it into a proper directory.
> 
>  Tomi
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
  2020-10-12 12:52 [PATCH] media: platform: ti-vpe: Update the path to firmware Nikhil Devshatwar
  2020-10-12 12:53 ` Laurent Pinchart
  2020-10-19 11:38 ` Tomi Valkeinen
@ 2020-10-30  9:57 ` Hans Verkuil
  2020-10-30 14:03   ` Tomi Valkeinen
  2 siblings, 1 reply; 8+ messages in thread
From: Hans Verkuil @ 2020-10-30  9:57 UTC (permalink / raw)
  To: Nikhil Devshatwar, linux-media, Laurent Pinchart
  Cc: Benoit Parrot, Tomi Valkeinen, Sekhar Nori

Hi Nikhil,

On 12/10/2020 14:52, Nikhil Devshatwar wrote:
> vpdma firmware is now available in the linux-firmware repo.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
> 
> Update the firmware path requested by the VPDMA driver so that
> it gets looked up correctly in the filesystem.
> 
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> ---
>  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
> index 2e5148ae7a0f..5a378449a4ff 100644
> --- a/drivers/media/platform/ti-vpe/vpdma.c
> +++ b/drivers/media/platform/ti-vpe/vpdma.c
> @@ -23,7 +23,7 @@
>  #include "vpdma.h"
>  #include "vpdma_priv.h"
>  
> -#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
> +#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"

Based on the discussion, this will change to ti/vpdma-1b8.bin, right?
At least once linux-firmware has been updated.

I'll wait for a v2.

Regards,

	Hans

>  
>  const struct vpdma_data_format vpdma_yuv_fmts[] = {
>  	[VPDMA_DATA_FMT_Y444] = {
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
  2020-10-30  9:57 ` Hans Verkuil
@ 2020-10-30 14:03   ` Tomi Valkeinen
  0 siblings, 0 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2020-10-30 14:03 UTC (permalink / raw)
  To: Hans Verkuil, Nikhil Devshatwar, linux-media, Laurent Pinchart
  Cc: Benoit Parrot, Sekhar Nori

On 30/10/2020 11:57, Hans Verkuil wrote:
> Hi Nikhil,
> 
> On 12/10/2020 14:52, Nikhil Devshatwar wrote:
>> vpdma firmware is now available in the linux-firmware repo.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
>>
>> Update the firmware path requested by the VPDMA driver so that
>> it gets looked up correctly in the filesystem.
>>
>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
>> ---
>>  drivers/media/platform/ti-vpe/vpdma.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
>> index 2e5148ae7a0f..5a378449a4ff 100644
>> --- a/drivers/media/platform/ti-vpe/vpdma.c
>> +++ b/drivers/media/platform/ti-vpe/vpdma.c
>> @@ -23,7 +23,7 @@
>>  #include "vpdma.h"
>>  #include "vpdma_priv.h"
>>  
>> -#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
>> +#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
> 
> Based on the discussion, this will change to ti/vpdma-1b8.bin, right?
> At least once linux-firmware has been updated.
> 
> I'll wait for a v2.

Yes, please wait for v2. I think it'll be ti/vpdma-1b8.bin, or alternatively keep it as it is now
(in the root).

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 12:52 [PATCH] media: platform: ti-vpe: Update the path to firmware Nikhil Devshatwar
2020-10-12 12:53 ` Laurent Pinchart
2020-10-19 11:38 ` Tomi Valkeinen
2020-10-20  7:38   ` Nikhil Devshatwar
2020-10-20  7:52     ` Tomi Valkeinen
2020-10-22 11:45       ` Nikhil Devshatwar
2020-10-30  9:57 ` Hans Verkuil
2020-10-30 14:03   ` Tomi Valkeinen

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git