From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Dan Scally <djrscally@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux.walleij@linaro.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
heikki.krogerus@linux.intel.com, dmitry.torokhov@gmail.com,
laurent.pinchart+renesas@ideasonboard.com,
kieran.bingham+renesas@ideasonboard.com,
jacopo+renesas@jmondi.org, robh@kernel.org, davem@davemloft.net,
linux@rasmusvillemoes.dk, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org, pmladek@suse.com, mchehab@kernel.org,
tian.shu.qiu@intel.com, bingbu.cao@intel.com, yong.zhi@intel.com,
rafael@kernel.org, gregkh@linuxfoundation.org, kitakar@gmail.com,
dan.carpenter@oracle.org
Subject: Re: [RFC PATCH v3 7/9] ipu3-cio2: Check if pci_dev->dev's fwnode is a software_node in cio2_parse_firmware() and set FWNODE_GRAPH_DEVICE_DISABLED if so
Date: Sat, 24 Oct 2020 17:29:07 +0300 [thread overview]
Message-ID: <20201024142907.GB26150@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20201024003955.GS5979@pendragon.ideasonboard.com>
On Sat, Oct 24, 2020 at 03:39:55AM +0300, Laurent Pinchart wrote:
> Hi Sakari
>
> On Wed, Oct 21, 2020 at 01:49:10AM +0300, Sakari Ailus wrote:
> > On Tue, Oct 20, 2020 at 08:56:07PM +0100, Dan Scally wrote:
> > > On 20/10/2020 13:06, Sakari Ailus wrote:
> > > > On Tue, Oct 20, 2020 at 12:19:58PM +0300, Andy Shevchenko wrote:
> > > >> On Mon, Oct 19, 2020 at 11:59:01PM +0100, Daniel Scally wrote:
> > > >>> fwnode_graph_get_endpoint_by_id() will optionally parse enabled devices
> > > >>> only; that status being determined through the .device_is_available() op
> > > >>> of the device's fwnode. As software_nodes don't have that operation and
> > > >>> adding it is meaningless, we instead need to check if the device's fwnode
> > > >>> is a software_node and if so pass the appropriate flag to disable that
> > > >>> check
> > > >> Period.
> > > >>
> > > >> I'm wondering if actually this can be hidden in fwnode_graph_get_endpoint_by_id().
> > > > The device availability test is actually there for a reason. Some firmware
> > > > implementations put all the potential devices in the tables and only one
> > > > (of some) of them are available.
> > > >
> > > > Could this be implemented so that if the node is a software node, then get
> > > > its parent and then see if that is available?
> > > >
> > > > I guess that could be implemented in software node ops. Any opinions?
> > > Actually when considering the cio2 device, it seems that
> > > set_secondary_fwnode() actually overwrites the _primary_, given
> > > fwnode_is_primary(dev->fwnode) returns false. So in at least some cases,
> > > this wouldn't work.
> >
> > Ouch. I wonder when this happens --- have you checked what's the primary
> > there? I guess it might be if it's a PCI device without the corresponding
> > ACPI device node?
> >
> > I remember you had an is_available implementation that just returned true
> > for software nodes in an early version of the set? I think it would still
> > be a lesser bad in this case.
>
> How about the following ?
Looks good to me.
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 81bd01ed4042..ea44ba846299 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -706,9 +706,14 @@ EXPORT_SYMBOL_GPL(fwnode_handle_put);
> /**
> * fwnode_device_is_available - check if a device is available for use
> * @fwnode: Pointer to the fwnode of the device.
> + *
> + * For fwnode node types that don't implement the .device_is_available()
> + * operation, such as software nodes, this function returns true.
> */
> bool fwnode_device_is_available(const struct fwnode_handle *fwnode)
> {
> + if (!fwnode_has_op(fwnode, device_is_available))
> + return true;
> return fwnode_call_bool_op(fwnode, device_is_available);
> }
> EXPORT_SYMBOL_GPL(fwnode_device_is_available);
>
--
Sakari Ailus
next prev parent reply other threads:[~2020-10-24 14:29 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:58 [RFC PATCH v3 0/9] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows Daniel Scally
2020-10-19 22:58 ` [RFC PATCH v3 1/9] software_node: Add helper function to unregister arrays of software_nodes ordered parent to child Daniel Scally
2020-10-20 9:22 ` Andy Shevchenko
2020-10-20 10:05 ` Sakari Ailus
2020-10-20 11:01 ` Andy Shevchenko
2020-10-20 11:02 ` Andy Shevchenko
2020-10-20 11:04 ` Heikki Krogerus
2020-10-20 22:52 ` Dan Scally
2020-10-21 9:40 ` Andy Shevchenko
2020-10-21 9:54 ` Dan Scally
2020-10-19 22:58 ` [RFC PATCH v3 2/9] lib/test_printf.c: Use helper function to unwind array of software_nodes Daniel Scally
2020-10-20 7:23 ` Petr Mladek
2020-10-20 9:20 ` Andy Shevchenko
2020-10-19 22:58 ` [RFC PATCH v3 3/9] software_node: Fix failure to hold refcount in software_node_get_next_child Daniel Scally
2020-10-20 12:44 ` Rafael J. Wysocki
2020-10-20 13:31 ` Sakari Ailus
2020-10-20 23:25 ` Dan Scally
2020-10-21 9:33 ` Andy Shevchenko
2020-10-21 9:37 ` Sakari Ailus
2020-10-21 9:56 ` Dan Scally
2020-10-19 22:58 ` [RFC PATCH v3 4/9] software_node: Add support for fwnode_graph*() family of functions Daniel Scally
2020-10-20 9:17 ` Andy Shevchenko
2020-10-20 12:35 ` Sakari Ailus
2020-10-20 13:32 ` Sakari Ailus
2020-10-19 22:58 ` [RFC PATCH v3 5/9] ipu3-cio2: Add T: entry to MAINTAINERS Daniel Scally
2020-10-20 9:16 ` Andy Shevchenko
2020-10-24 0:28 ` Laurent Pinchart
2020-10-19 22:59 ` [RFC PATCH v3 6/9] ipu3-cio2: Rename ipu3-cio2.c to allow module to be built from multiple sources files retaining ipu3-cio2 name Daniel Scally
2020-10-20 9:15 ` Andy Shevchenko
2020-10-20 20:41 ` Dan Scally
2020-10-24 0:34 ` Laurent Pinchart
2020-10-19 22:59 ` [RFC PATCH v3 7/9] ipu3-cio2: Check if pci_dev->dev's fwnode is a software_node in cio2_parse_firmware() and set FWNODE_GRAPH_DEVICE_DISABLED if so Daniel Scally
2020-10-20 9:19 ` Andy Shevchenko
2020-10-20 12:06 ` Sakari Ailus
2020-10-20 19:56 ` Dan Scally
2020-10-20 22:49 ` Sakari Ailus
2020-10-20 22:55 ` Dan Scally
2020-10-24 0:39 ` Laurent Pinchart
2020-10-24 14:29 ` Sakari Ailus [this message]
2020-10-24 16:33 ` Dan Scally
2020-10-24 16:55 ` Laurent Pinchart
2020-10-19 22:59 ` [RFC PATCH v3 8/9] media: v4l2-core: v4l2-async: Check possible match in match_fwnode based on sd->fwnode->secondary Daniel Scally
2020-10-19 22:59 ` [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows Daniel Scally
2020-10-20 9:41 ` Andy Shevchenko
2020-10-21 22:05 ` Daniel Scally
2020-10-22 13:40 ` Andy Shevchenko
2020-10-23 10:06 ` Dan Scally
2020-10-24 1:24 ` Laurent Pinchart
2020-10-24 8:50 ` Dan Scally
2020-10-24 9:37 ` Laurent Pinchart
2020-10-24 22:28 ` Daniel Scally
2020-10-24 22:36 ` Laurent Pinchart
2020-10-24 22:50 ` Daniel Scally
2020-10-26 8:20 ` Dan Scally
2020-10-26 16:05 ` Andy Shevchenko
2020-10-29 20:17 ` Laurent Pinchart
2020-10-29 22:36 ` Dan Scally
2020-10-26 16:10 ` Andy Shevchenko
2020-10-29 20:19 ` Laurent Pinchart
2020-10-29 20:26 ` Andy Shevchenko
2020-10-29 21:29 ` Laurent Pinchart
2020-10-29 22:22 ` Andy Shevchenko
2020-10-29 22:51 ` Laurent Pinchart
2020-11-13 10:02 ` Dan Scally
2020-11-13 16:22 ` Laurent Pinchart
2020-11-13 19:45 ` Andy Shevchenko
2020-11-15 8:45 ` Daniel Scally
2020-11-16 8:53 ` Laurent Pinchart
2020-11-16 13:57 ` Andy Shevchenko
2020-11-16 14:10 ` Laurent Pinchart
2020-11-16 14:15 ` Dan Scally
2020-11-16 16:16 ` Andy Shevchenko
2020-11-17 12:01 ` Dan Scally
2020-11-17 16:42 ` Andy Shevchenko
2020-11-17 22:59 ` Dan Scally
2020-10-24 15:11 ` Sakari Ailus
2020-10-24 15:14 ` Sakari Ailus
2020-10-24 20:28 ` Dan Scally
2020-10-25 11:18 ` Sakari Ailus
2020-10-20 9:24 ` [RFC PATCH v3 0/9] Add functionality to ipu3-cio2 driver " Andy Shevchenko
2020-10-20 13:38 ` Rafael J. Wysocki
2020-10-21 20:59 ` Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201024142907.GB26150@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=dan.carpenter@oracle.org \
--cc=davem@davemloft.net \
--cc=djrscally@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kitakar@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux.walleij@linaro.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mchehab@kernel.org \
--cc=pmladek@suse.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).