Linux-Media Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v5 1/2] staging: media: imx: remove commented code
@ 2020-10-16 17:40 Deepak R Varma
  2020-10-16 17:43 ` Steve Longerbeam
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Deepak R Varma @ 2020-10-16 17:40 UTC (permalink / raw)
  To: outreachy-kernel, Steve Longerbeam, Philipp Zabel,
	Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-media
  Cc: mh12gx2825

The virtual channel is always treated as 0 once the stream enters
CSI's. Commented code in the "#if 0" can be safely removed as it will
not serve any purpose in future.  Issue reported by checkpatch script.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
Changes since v4:
   - Rephrase patch description to make it exact and accurate as
     suggested by Julia.
   - Add linux-media to the recipient list. Suggested by Hans.
Changes since v3:
   - Rephrase Patch description
   - Implement feedback from Vaishali & Helen to mention checkpatch in
     the patch description.
Changes since v2:
   - None
Changes since v1:
   - Implement feedback from Julia to be exact with the patch description

 drivers/staging/media/imx/imx-media-csi.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 21ebf7769696..9320e3974d86 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1131,13 +1131,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
 		 * enters the CSI's however, they are treated internally
 		 * in the IPU as virtual channel 0.
 		 */
-#if 0
-		mutex_unlock(&priv->lock);
-		vc_num = imx_media_find_mipi_csi2_channel(&priv->sd.entity);
-		if (vc_num < 0)
-			return vc_num;
-		mutex_lock(&priv->lock);
-#endif
 		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
 					  &priv->format_mbus[CSI_SINK_PAD]);
 	}
-- 
2.25.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 1/2] staging: media: imx: remove commented code
  2020-10-16 17:40 [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
@ 2020-10-16 17:43 ` Steve Longerbeam
  2020-10-16 17:46 ` [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use Deepak R Varma
  2020-10-26  4:00 ` [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
  2 siblings, 0 replies; 9+ messages in thread
From: Steve Longerbeam @ 2020-10-16 17:43 UTC (permalink / raw)
  To: Deepak R Varma, outreachy-kernel, Philipp Zabel,
	Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-media

Hi Deepak,

This is fine with me as long as the comment block just above the #if 0 
code is left intact, which it is.

Acked-by: Steve Longerbeam <slongerbeam@gmail.com>


On 10/16/20 10:40 AM, Deepak R Varma wrote:
> The virtual channel is always treated as 0 once the stream enters
> CSI's. Commented code in the "#if 0" can be safely removed as it will
> not serve any purpose in future.  Issue reported by checkpatch script.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> Changes since v4:
>     - Rephrase patch description to make it exact and accurate as
>       suggested by Julia.
>     - Add linux-media to the recipient list. Suggested by Hans.
> Changes since v3:
>     - Rephrase Patch description
>     - Implement feedback from Vaishali & Helen to mention checkpatch in
>       the patch description.
> Changes since v2:
>     - None
> Changes since v1:
>     - Implement feedback from Julia to be exact with the patch description
>
>   drivers/staging/media/imx/imx-media-csi.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 21ebf7769696..9320e3974d86 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1131,13 +1131,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>   		 * enters the CSI's however, they are treated internally
>   		 * in the IPU as virtual channel 0.
>   		 */
> -#if 0
> -		mutex_unlock(&priv->lock);
> -		vc_num = imx_media_find_mipi_csi2_channel(&priv->sd.entity);
> -		if (vc_num < 0)
> -			return vc_num;
> -		mutex_lock(&priv->lock);
> -#endif
>   		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
>   					  &priv->format_mbus[CSI_SINK_PAD]);
>   	}


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use
  2020-10-16 17:40 [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
  2020-10-16 17:43 ` Steve Longerbeam
@ 2020-10-16 17:46 ` Deepak R Varma
  2020-10-16 17:46   ` Steve Longerbeam
  2020-10-26  4:02   ` Deepak R Varma
  2020-10-26  4:00 ` [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
  2 siblings, 2 replies; 9+ messages in thread
From: Deepak R Varma @ 2020-10-16 17:46 UTC (permalink / raw)
  To: outreachy-kernel, Steve Longerbeam, Philipp Zabel,
	Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-media
  Cc: mh12gx2825

Use of variable vc_num is unnecessary here as it is used only once.
Instead, the value can directly be used in place of the variable.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
Changes since v4:
   - None.
Changes since v3:
   - None.
Changes since v2:
   - Implement feedback from Vaishali to simplify patch log message.
Changes since v1:
   - None.

 drivers/staging/media/imx/imx-media-csi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 9320e3974d86..db77fef07654 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
 	priv->upstream_ep = upstream_ep;
 	is_csi2 = !is_parallel_bus(&upstream_ep);
 	if (is_csi2) {
-		int vc_num = 0;
 		/*
 		 * NOTE! It seems the virtual channels from the mipi csi-2
 		 * receiver are used only for routing by the video mux's,
@@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
 		 * enters the CSI's however, they are treated internally
 		 * in the IPU as virtual channel 0.
 		 */
-		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
+		ipu_csi_set_mipi_datatype(priv->csi, 0,
 					  &priv->format_mbus[CSI_SINK_PAD]);
 	}
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use
  2020-10-16 17:46 ` [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use Deepak R Varma
@ 2020-10-16 17:46   ` Steve Longerbeam
  2020-10-26  4:02   ` Deepak R Varma
  1 sibling, 0 replies; 9+ messages in thread
From: Steve Longerbeam @ 2020-10-16 17:46 UTC (permalink / raw)
  To: Deepak R Varma, outreachy-kernel, Philipp Zabel,
	Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-media

Acked-by: Steve Longerbeam <slongerbeam@gmail.com>

On 10/16/20 10:46 AM, Deepak R Varma wrote:
> Use of variable vc_num is unnecessary here as it is used only once.
> Instead, the value can directly be used in place of the variable.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> Changes since v4:
>     - None.
> Changes since v3:
>     - None.
> Changes since v2:
>     - Implement feedback from Vaishali to simplify patch log message.
> Changes since v1:
>     - None.
>
>   drivers/staging/media/imx/imx-media-csi.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 9320e3974d86..db77fef07654 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>   	priv->upstream_ep = upstream_ep;
>   	is_csi2 = !is_parallel_bus(&upstream_ep);
>   	if (is_csi2) {
> -		int vc_num = 0;
>   		/*
>   		 * NOTE! It seems the virtual channels from the mipi csi-2
>   		 * receiver are used only for routing by the video mux's,
> @@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>   		 * enters the CSI's however, they are treated internally
>   		 * in the IPU as virtual channel 0.
>   		 */
> -		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
> +		ipu_csi_set_mipi_datatype(priv->csi, 0,
>   					  &priv->format_mbus[CSI_SINK_PAD]);
>   	}
>   


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 1/2] staging: media: imx: remove commented code
  2020-10-16 17:40 [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
  2020-10-16 17:43 ` Steve Longerbeam
  2020-10-16 17:46 ` [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use Deepak R Varma
@ 2020-10-26  4:00 ` Deepak R Varma
  2020-10-26  5:56   ` Greg Kroah-Hartman
  2 siblings, 1 reply; 9+ messages in thread
From: Deepak R Varma @ 2020-10-26  4:00 UTC (permalink / raw)
  To: outreachy-kernel, Steve Longerbeam, Philipp Zabel,
	Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-media

On Fri, Oct 16, 2020 at 11:10:33PM +0530, Deepak R Varma wrote:

Hello All,
Request for review / ack of this patch.

Thank you.
Deepak.

> The virtual channel is always treated as 0 once the stream enters
> CSI's. Commented code in the "#if 0" can be safely removed as it will
> not serve any purpose in future.  Issue reported by checkpatch script.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> Changes since v4:
>    - Rephrase patch description to make it exact and accurate as
>      suggested by Julia.
>    - Add linux-media to the recipient list. Suggested by Hans.
> Changes since v3:
>    - Rephrase Patch description
>    - Implement feedback from Vaishali & Helen to mention checkpatch in
>      the patch description.
> Changes since v2:
>    - None
> Changes since v1:
>    - Implement feedback from Julia to be exact with the patch description
> 
>  drivers/staging/media/imx/imx-media-csi.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 21ebf7769696..9320e3974d86 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1131,13 +1131,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>  		 * enters the CSI's however, they are treated internally
>  		 * in the IPU as virtual channel 0.
>  		 */
> -#if 0
> -		mutex_unlock(&priv->lock);
> -		vc_num = imx_media_find_mipi_csi2_channel(&priv->sd.entity);
> -		if (vc_num < 0)
> -			return vc_num;
> -		mutex_lock(&priv->lock);
> -#endif
>  		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
>  					  &priv->format_mbus[CSI_SINK_PAD]);
>  	}
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use
  2020-10-16 17:46 ` [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use Deepak R Varma
  2020-10-16 17:46   ` Steve Longerbeam
@ 2020-10-26  4:02   ` Deepak R Varma
  1 sibling, 0 replies; 9+ messages in thread
From: Deepak R Varma @ 2020-10-26  4:02 UTC (permalink / raw)
  To: outreachy-kernel, Steve Longerbeam, Philipp Zabel,
	Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-media

On Fri, Oct 16, 2020 at 11:16:06PM +0530, Deepak R Varma wrote:

Hello All,
Request for review / ack of this patch.

Thank you.
Deepak.

> Use of variable vc_num is unnecessary here as it is used only once.
> Instead, the value can directly be used in place of the variable.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> Changes since v4:
>    - None.
> Changes since v3:
>    - None.
> Changes since v2:
>    - Implement feedback from Vaishali to simplify patch log message.
> Changes since v1:
>    - None.
> 
>  drivers/staging/media/imx/imx-media-csi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 9320e3974d86..db77fef07654 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1123,7 +1123,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>  	priv->upstream_ep = upstream_ep;
>  	is_csi2 = !is_parallel_bus(&upstream_ep);
>  	if (is_csi2) {
> -		int vc_num = 0;
>  		/*
>  		 * NOTE! It seems the virtual channels from the mipi csi-2
>  		 * receiver are used only for routing by the video mux's,
> @@ -1131,7 +1130,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>  		 * enters the CSI's however, they are treated internally
>  		 * in the IPU as virtual channel 0.
>  		 */
> -		ipu_csi_set_mipi_datatype(priv->csi, vc_num,
> +		ipu_csi_set_mipi_datatype(priv->csi, 0,
>  					  &priv->format_mbus[CSI_SINK_PAD]);
>  	}
>  
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 1/2] staging: media: imx: remove commented code
  2020-10-26  4:00 ` [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
@ 2020-10-26  5:56   ` Greg Kroah-Hartman
  2020-10-26 18:03     ` Deepak R Varma
  2020-10-27  9:43     ` Hans Verkuil
  0 siblings, 2 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2020-10-26  5:56 UTC (permalink / raw)
  To: Deepak R Varma
  Cc: outreachy-kernel, Steve Longerbeam, Philipp Zabel,
	Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	linux-media

On Mon, Oct 26, 2020 at 09:30:17AM +0530, Deepak R Varma wrote:
> On Fri, Oct 16, 2020 at 11:10:33PM +0530, Deepak R Varma wrote:
> 
> Hello All,
> Request for review / ack of this patch.

Please never top-post :(

The merge window only opened up a few hours ago, give maintainers time
to get to patches (like 2 weeks now).  Also remember, for the outreachy
project, drivers/staging/media/ patches are not considered and take much
longer to get reviewed and accepted, as the outreachy documentation
states.

good luck!

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 1/2] staging: media: imx: remove commented code
  2020-10-26  5:56   ` Greg Kroah-Hartman
@ 2020-10-26 18:03     ` Deepak R Varma
  2020-10-27  9:43     ` Hans Verkuil
  1 sibling, 0 replies; 9+ messages in thread
From: Deepak R Varma @ 2020-10-26 18:03 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: outreachy-kernel, Steve Longerbeam, Philipp Zabel,
	Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	linux-media

On Mon, Oct 26, 2020 at 06:56:31AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Oct 26, 2020 at 09:30:17AM +0530, Deepak R Varma wrote:
> > On Fri, Oct 16, 2020 at 11:10:33PM +0530, Deepak R Varma wrote:
> > 
> > Hello All,
> > Request for review / ack of this patch.
> 
> Please never top-post :(

Apologies. Will keep this in mind going forward.

> 
> The merge window only opened up a few hours ago, give maintainers time
> to get to patches (like 2 weeks now).  Also remember, for the outreachy
> project, drivers/staging/media/ patches are not considered and take much
> longer to get reviewed and accepted, as the outreachy documentation
> states.

We had both the patches review acked by Steve L. However, they did not
make it to your list of accepted patches. Hence was checking if there is
anything more needed from me to have the patches get onto your acceptance.

No problem. I will wait for the normal course be followed.

Thank you as always :)
Deepak.

> 
> good luck!
> 
> greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v5 1/2] staging: media: imx: remove commented code
  2020-10-26  5:56   ` Greg Kroah-Hartman
  2020-10-26 18:03     ` Deepak R Varma
@ 2020-10-27  9:43     ` Hans Verkuil
  1 sibling, 0 replies; 9+ messages in thread
From: Hans Verkuil @ 2020-10-27  9:43 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Deepak R Varma
  Cc: outreachy-kernel, Steve Longerbeam, Philipp Zabel,
	Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	linux-media

On 26/10/2020 06:56, Greg Kroah-Hartman wrote:
> On Mon, Oct 26, 2020 at 09:30:17AM +0530, Deepak R Varma wrote:
>> On Fri, Oct 16, 2020 at 11:10:33PM +0530, Deepak R Varma wrote:
>>
>> Hello All,
>> Request for review / ack of this patch.
> 
> Please never top-post :(
> 
> The merge window only opened up a few hours ago, give maintainers time
> to get to patches (like 2 weeks now).  Also remember, for the outreachy
> project, drivers/staging/media/ patches are not considered and take much
> longer to get reviewed and accepted, as the outreachy documentation
> states.

As media reviewer I've been very, very busy with other things for the past 3 weeks.
I plan to use most (all?) of next week to catch up on things.

Regards,

	Hans

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 17:40 [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
2020-10-16 17:43 ` Steve Longerbeam
2020-10-16 17:46 ` [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use Deepak R Varma
2020-10-16 17:46   ` Steve Longerbeam
2020-10-26  4:02   ` Deepak R Varma
2020-10-26  4:00 ` [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
2020-10-26  5:56   ` Greg Kroah-Hartman
2020-10-26 18:03     ` Deepak R Varma
2020-10-27  9:43     ` Hans Verkuil

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git