From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DD0C5519F for ; Fri, 20 Nov 2020 09:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5F0B2222F for ; Fri, 20 Nov 2020 09:31:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727692AbgKTJbV (ORCPT ); Fri, 20 Nov 2020 04:31:21 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:60653 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727566AbgKTJbR (ORCPT ); Fri, 20 Nov 2020 04:31:17 -0500 Received: from uno.localdomain (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id A72F620003C; Fri, 20 Nov 2020 09:31:12 +0000 (UTC) Date: Fri, 20 Nov 2020 10:31:16 +0100 From: Jacopo Mondi To: Rikard Falkeborn Cc: Mauro Carvalho Chehab , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?utf-8?Q?S=C3=B6derlund?= , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: i2c: rdacm20: Constify static structs Message-ID: <20201120093116.x43pqej4lsz5ynmz@uno.localdomain> References: <20201119222248.148845-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201119222248.148845-1-rikard.falkeborn@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Rikard, On Thu, Nov 19, 2020 at 11:22:48PM +0100, Rikard Falkeborn wrote: > The only usage of rdacm20_video_ops is to assign it to the video field > in the v4l2_subdev_ops struct which is a pointer to const, and the only > usage of rdacm20_subdev_ops is to pass its address to > v4l2_i2c_subdev_init() which accepts a pointer to const. Make them const > to allow the compiler to put them in read-only memory. > > Signed-off-by: Rikard Falkeborn Thanks Acked-by: Jacopo Mondi > --- > drivers/media/i2c/rdacm20.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c > index 1ed928c4ca70..ac00a6743623 100644 > --- a/drivers/media/i2c/rdacm20.c > +++ b/drivers/media/i2c/rdacm20.c > @@ -435,7 +435,7 @@ static int rdacm20_get_fmt(struct v4l2_subdev *sd, > return 0; > } > > -static struct v4l2_subdev_video_ops rdacm20_video_ops = { > +static const struct v4l2_subdev_video_ops rdacm20_video_ops = { > .s_stream = rdacm20_s_stream, > }; > > @@ -445,7 +445,7 @@ static const struct v4l2_subdev_pad_ops rdacm20_subdev_pad_ops = { > .set_fmt = rdacm20_get_fmt, > }; > > -static struct v4l2_subdev_ops rdacm20_subdev_ops = { > +static const struct v4l2_subdev_ops rdacm20_subdev_ops = { > .video = &rdacm20_video_ops, > .pad = &rdacm20_subdev_pad_ops, > }; > -- > 2.29.2 >