From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jemma Denson <jdenson@gmail.com>,
Patrick Boettcher <patrick.boettcher@posteo.de>,
Malcolm Priestley <tvboxspy@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 013/141] media: dvb-frontends: Fix fall-through warnings for Clang
Date: Sun, 22 Nov 2020 17:31:16 +0100 [thread overview]
Message-ID: <20201122173116.1eb9f195@coco.lan> (raw)
In-Reply-To: <4e82e61c94f320aae692aaa0e55350049e17168f.1605896059.git.gustavoars@kernel.org>
Em Fri, 20 Nov 2020 12:26:09 -0600
"Gustavo A. R. Silva" <gustavoars@kernel.org> escreveu:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break and a return statements
> instead of just letting the code fall through to the next case.
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/media/dvb-frontends/cx24120.c | 1 +
> drivers/media/dvb-frontends/dib0090.c | 2 ++
> drivers/media/dvb-frontends/drxk_hard.c | 1 +
> drivers/media/dvb-frontends/m88rs2000.c | 1 +
> 4 files changed, 5 insertions(+)
>
> diff --git a/drivers/media/dvb-frontends/cx24120.c b/drivers/media/dvb-frontends/cx24120.c
> index 2464b63fe0cf..d8acd582c711 100644
> --- a/drivers/media/dvb-frontends/cx24120.c
> +++ b/drivers/media/dvb-frontends/cx24120.c
> @@ -363,6 +363,7 @@ static void cx24120_check_cmd(struct cx24120_state *state, u8 id)
> case CMD_DISEQC_BURST:
> cx24120_msg_mpeg_output_global_config(state, 0);
> /* Old driver would do a msleep(100) here */
> + return;
> default:
> return;
> }
> diff --git a/drivers/media/dvb-frontends/dib0090.c b/drivers/media/dvb-frontends/dib0090.c
> index 08a85831e917..903da33642df 100644
> --- a/drivers/media/dvb-frontends/dib0090.c
> +++ b/drivers/media/dvb-frontends/dib0090.c
> @@ -1765,6 +1765,8 @@ static int dib0090_dc_offset_calibration(struct dib0090_state *state, enum front
> dib0090_write_reg(state, 0x1f, 0x7);
> *tune_state = CT_TUNER_START; /* reset done -> real tuning can now begin */
> state->calibrate &= ~DC_CAL;
> + break;
> +
> default:
> break;
> }
> diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c
> index a57470bf71bf..d7fc2595f15b 100644
> --- a/drivers/media/dvb-frontends/drxk_hard.c
> +++ b/drivers/media/dvb-frontends/drxk_hard.c
> @@ -3294,6 +3294,7 @@ static int dvbt_sc_command(struct drxk_state *state,
> case OFDM_SC_RA_RAM_CMD_USER_IO:
> case OFDM_SC_RA_RAM_CMD_GET_OP_PARAM:
> status = read16(state, OFDM_SC_RA_RAM_PARAM0__A, &(param0));
> + break;
> /* All commands yielding 0 results */
> case OFDM_SC_RA_RAM_CMD_SET_ECHO_TIMING:
> case OFDM_SC_RA_RAM_CMD_SET_TIMER:
> diff --git a/drivers/media/dvb-frontends/m88rs2000.c b/drivers/media/dvb-frontends/m88rs2000.c
> index 39cbb3ea1c9d..b294ba87e934 100644
> --- a/drivers/media/dvb-frontends/m88rs2000.c
> +++ b/drivers/media/dvb-frontends/m88rs2000.c
> @@ -390,6 +390,7 @@ static int m88rs2000_tab_set(struct m88rs2000_state *state,
> case 0xff:
> if (tab[i].reg == 0xaa && tab[i].val == 0xff)
> return 0;
> + break;
> case 0x00:
> break;
> default:
Thanks,
Mauro
next prev parent reply other threads:[~2020-11-22 16:31 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 18:21 [PATCH 000/141] Fix fall-through warnings for Clang Gustavo A. R. Silva
2020-11-20 18:26 ` [PATCH 013/141] media: dvb-frontends: " Gustavo A. R. Silva
2020-11-22 16:31 ` Mauro Carvalho Chehab [this message]
2020-11-23 22:44 ` Gustavo A. R. Silva
2020-11-20 18:26 ` [PATCH 014/141] media: usb: dvb-usb-v2: " Gustavo A. R. Silva
2020-11-22 16:31 ` Mauro Carvalho Chehab
2020-11-20 18:28 ` [PATCH 000/141] " Joe Perches
2020-11-20 19:02 ` Gustavo A. R. Silva
2020-11-20 18:36 ` [PATCH 094/141] media: atomisp: " Gustavo A. R. Silva
2020-11-22 16:32 ` Mauro Carvalho Chehab
2020-11-20 18:36 ` [PATCH 095/141] media: dvb_frontend: " Gustavo A. R. Silva
2020-11-22 16:32 ` Mauro Carvalho Chehab
2020-11-20 18:37 ` [PATCH 096/141] media: rcar_jpu: " Gustavo A. R. Silva
2020-11-22 16:33 ` Mauro Carvalho Chehab
2020-11-20 18:37 ` [PATCH 097/141] media: saa7134: " Gustavo A. R. Silva
2020-11-22 16:32 ` Mauro Carvalho Chehab
2020-11-20 18:53 ` [PATCH 000/141] " Jakub Kicinski
2020-11-20 19:04 ` Gustavo A. R. Silva
2020-11-20 19:30 ` Kees Cook
2020-11-20 19:51 ` Jakub Kicinski
2020-11-20 20:48 ` Kees Cook
2020-11-22 16:17 ` Kees Cook
2020-11-22 18:21 ` James Bottomley
2020-11-22 18:25 ` Joe Perches
2020-11-22 19:12 ` James Bottomley
2020-11-22 19:22 ` Joe Perches
2020-11-22 19:53 ` James Bottomley
2020-11-23 13:03 ` [Intel-wired-lan] " Gustavo A. R. Silva
2020-11-23 16:31 ` James Bottomley
2020-11-24 21:32 ` Kees Cook
2020-11-24 22:24 ` Finn Thain
2020-11-24 23:15 ` Miguel Ojeda
2020-11-24 23:53 ` Finn Thain
2020-11-25 1:05 ` Miguel Ojeda
2020-11-25 7:05 ` James Bottomley
2020-11-25 12:24 ` Nick Desaulniers
2020-11-25 21:33 ` Finn Thain
2020-11-25 22:09 ` Nick Desaulniers
2020-11-25 23:21 ` Finn Thain
2020-11-26 0:30 ` Finn Thain
[not found] ` <20201125082405.1d8c23dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2020-11-25 17:04 ` Miguel Ojeda
2020-11-25 22:09 ` Nick Desaulniers
2020-11-25 21:10 ` Kees Cook
2020-11-22 20:35 ` Miguel Ojeda
2020-11-22 22:36 ` James Bottomley
2020-11-23 14:19 ` Miguel Ojeda
2020-11-23 15:58 ` James Bottomley
2020-11-23 16:24 ` Rafael J. Wysocki
2020-11-23 16:32 ` Joe Perches
2020-11-23 18:56 ` Miguel Ojeda
2020-11-23 20:37 ` James Bottomley
2020-11-25 0:32 ` Miguel Ojeda
2020-11-25 22:44 ` Edward Cree
2020-11-26 14:53 ` Miguel Ojeda
2020-11-26 15:28 ` Geert Uytterhoeven
2020-11-26 16:18 ` Karol Herbst
2020-11-26 17:05 ` Miguel Ojeda
2020-11-25 10:38 ` Andy Shevchenko
2020-11-25 9:01 ` Sean Young
2020-11-22 22:54 ` Finn Thain
2020-11-22 23:04 ` James Bottomley
2020-11-23 14:05 ` Miguel Ojeda
2020-11-24 0:58 ` Finn Thain
2020-11-24 1:05 ` Joe Perches
2020-11-24 2:48 ` Finn Thain
2020-11-24 23:46 ` Miguel Ojeda
2020-11-22 22:10 ` Sam Ravnborg
2020-11-24 1:32 ` Nick Desaulniers
2020-11-24 21:25 ` Kees Cook
2020-11-25 23:02 ` Edward Cree
2020-12-01 14:08 ` Dan Carpenter
2020-12-01 14:04 ` Dan Carpenter
2020-11-20 22:21 ` Miguel Ojeda
2020-11-23 20:03 ` Jason Gunthorpe
2020-11-24 14:47 ` Gustavo A. R. Silva
[not found] ` <160616392671.21180.16517492185091399884.b4-ty@kernel.org>
2020-11-24 14:47 ` Gustavo A. R. Silva
2020-12-01 5:52 ` Martin K. Petersen
2020-12-01 8:20 ` Gustavo A. R. Silva
2020-12-08 4:52 ` (subset) " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201122173116.1eb9f195@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=gustavoars@kernel.org \
--cc=jdenson@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=patrick.boettcher@posteo.de \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).