From: Rob Herring <robh@kernel.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: dt-bindings: coda: Add missing 'additionalProperties'
Date: Thu, 3 Dec 2020 08:10:13 -0700 [thread overview]
Message-ID: <20201203151013.GA2644458@robh.at.kernel.org> (raw)
In-Reply-To: <20201117200752.4004368-1-robh@kernel.org>
On Tue, Nov 17, 2020 at 02:07:52PM -0600, Rob Herring wrote:
> 'additionalProperties' is now required by the meta-schema. Add it for
> coda. As a result, 'interrupts', 'interrupt-names' and 'power-domains'
> need to be reworked to be defined at the top level.
>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Ping! In case it wasn't clear, this should go in via the media tree.
> .../devicetree/bindings/media/coda.yaml | 42 +++++++++----------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml
> index 7bac0057faf7..36781ee4617f 100644
> --- a/Documentation/devicetree/bindings/media/coda.yaml
> +++ b/Documentation/devicetree/bindings/media/coda.yaml
> @@ -44,6 +44,21 @@ properties:
> - const: per
> - const: ahb
>
> + interrupts:
> + minItems: 1
> + items:
> + - description: BIT processor interrupt
> + - description: JPEG unit interrupt
> +
> + interrupt-names:
> + minItems: 1
> + items:
> + - const: bit
> + - const: jpeg
> +
> + power-domains:
> + maxItems: 1
> +
> resets:
> maxItems: 1
>
> @@ -59,6 +74,8 @@ required:
> - clocks
> - clock-names
>
> +additionalProperties: false
> +
> allOf:
> - if:
> properties:
> @@ -68,34 +85,17 @@ allOf:
> then:
> properties:
> interrupts:
> - items:
> - - description: BIT processor interrupt
> - - description: JPEG unit interrupt
> + minItems: 2
>
> interrupt-names:
> - items:
> - - const: bit
> - - const: jpeg
> + minItems: 2
> else:
> properties:
> interrupts:
> - items:
> - - description: BIT processor interrupt
> -
> - - if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - fsl,imx6dl-vpu
> - - fsl,imx6q-vpu
> - then:
> - properties:
> - power-domains:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description: phandle pointing to the PU power domain
> maxItems: 1
>
> + power-domains: false
> +
> examples:
> - |
> vpu: video-codec@63ff4000 {
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-12-03 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 20:07 [PATCH v2] media: dt-bindings: coda: Add missing 'additionalProperties' Rob Herring
2020-12-03 15:10 ` Rob Herring [this message]
2020-12-03 15:51 ` Philipp Zabel
2020-12-03 15:57 ` Philipp Zabel
2020-12-18 21:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203151013.GA2644458@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).