From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525B7C433DB for ; Fri, 19 Mar 2021 13:11:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1852364ED7 for ; Fri, 19 Mar 2021 13:11:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbhCSNKs (ORCPT ); Fri, 19 Mar 2021 09:10:48 -0400 Received: from verein.lst.de ([213.95.11.211]:46143 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhCSNKQ (ORCPT ); Fri, 19 Mar 2021 09:10:16 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3E99C68BFE; Fri, 19 Mar 2021 14:10:12 +0100 (CET) Date: Fri, 19 Mar 2021 14:10:11 +0100 From: Christoph Hellwig To: Ricardo Ribalda Cc: Christoph Hellwig , Mauro Carvalho Chehab , Marek Szyprowski , Tomasz Figa , Sergey Senozhatsky , Laurent Pinchart , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Robin Murphy , Linux Kernel Mailing List , Linux Media Mailing List Subject: Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API Message-ID: <20210319131011.GA3372@lst.de> References: <20210312235521.1408503-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Mar 19, 2021 at 02:05:21PM +0100, Ricardo Ribalda wrote: > > + uvc_urb->sgt, > > + uvc_stream_dir(uvc_urb->stream)); > > + return usb_submit_urb(uvc_urb->urb, GFP_KERNEL); > > +} > > We should have mem_flags instead of GFP_KERNEL here > > > Is it too late to fix it in your tree? Do I need to send a patch to fix it? As far as I know we don't have anything that has pulled in the tree yet, so I can just fold the fix in.