From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>
Subject: [PATCH] v4l: Cast timestamp tv_usec to singned
Date: Thu, 25 Mar 2021 12:29:52 +0200 [thread overview]
Message-ID: <20210325102952.1126952-1-stanimir.varbanov@linaro.org> (raw)
Some of the MPEG4 standards allows negative timestamps. Correct
tv_usec cast to s32.
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
include/media/v4l2-common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
index 3eb202259e8c..1ed61416003a 100644
--- a/include/media/v4l2-common.h
+++ b/include/media/v4l2-common.h
@@ -544,11 +544,11 @@ static inline u64 v4l2_buffer_get_timestamp(const struct v4l2_buffer *buf)
{
/*
* When the timestamp comes from 32-bit user space, there may be
- * uninitialized data in tv_usec, so cast it to u32.
+ * uninitialized data in tv_usec, so cast it to s32.
* Otherwise allow invalid input for backwards compatibility.
*/
return buf->timestamp.tv_sec * NSEC_PER_SEC +
- (u32)buf->timestamp.tv_usec * NSEC_PER_USEC;
+ (s32)buf->timestamp.tv_usec * NSEC_PER_USEC;
}
static inline void v4l2_buffer_set_timestamp(struct v4l2_buffer *buf,
--
2.25.1
next reply other threads:[~2021-03-25 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 10:29 Stanimir Varbanov [this message]
2021-03-25 10:51 ` [PATCH] v4l: Cast timestamp tv_usec to singned Arnd Bergmann
2021-03-25 10:55 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325102952.1126952-1-stanimir.varbanov@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=arnd@arndb.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).