From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC0BCC433E0 for ; Fri, 26 Mar 2021 11:42:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9296961A4C for ; Fri, 26 Mar 2021 11:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229589AbhCZLmL convert rfc822-to-8bit (ORCPT ); Fri, 26 Mar 2021 07:42:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:42390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbhCZLmH (ORCPT ); Fri, 26 Mar 2021 07:42:07 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25CBE61A26; Fri, 26 Mar 2021 11:41:57 +0000 (UTC) Date: Fri, 26 Mar 2021 11:42:02 +0000 From: Jonathan Cameron To: Lee Jones Cc: linux-kernel@vger.kernel.org, Alexandre Torgue , Anssi Hannula , Benjamin Tissoires , Bruno =?UTF-8?B?UHI=?= =?UTF-8?B?w6ltb250?= , Christian =?UTF-8?B?S8O2bmln?= , Daniel Drubin , Dario Pagani , dri-devel@lists.freedesktop.org, Henrik Rydberg , Jiri Kosina , Kai-Heng Feng , Kim Kuparinen , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-usb@vger.kernel.org, Lopez Casado , "L. Vinyard, Jr" , Masaki Ota , Maxime Coquelin , message to , Michael Haboustak , Rushikesh S Kadam , Srinivas Pandruvada , Sumit Semwal , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Vojtech Pavlik , Zhang Lixu Subject: Re: [PATCH 00/25] Rid W=1 warnings from HID Message-ID: <20210326114202.3862b8c5@jic23-huawei> In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, 24 Mar 2021 17:33:39 +0000 Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. Lee, it's a bit novel to cc linux-iio on the cover letter but none of the actual patches.. Or least none of them reached me or lore.kernel.org I'm sure they are great :) Jonathan > > Lee Jones (25): > HID: intel-ish-hid: Remove unused variable 'err' > HID: ishtp-hid-client: Move variable to where it's actually used > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > HID: intel-ish: Supply some missing param descriptions > HID: intel-ish: Fix a naming disparity and a formatting error > HID: usbhid: Repair a formatting issue in a struct description > HID: intel-ish-hid: Fix a little doc-rot > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > HID: hid-alps: Correct struct misnaming > HID: intel-ish-hid: Fix potential copy/paste error > HID: hid-core: Fix incorrect function name in header > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > header > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > HID: hid-picolcd_core: Remove unused variable 'ret' > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > abuses > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > HID: hid-uclogic-params: Ensure function names are present and correct > in kernel-doc headers > HID: hid-sensor-custom: Remove unused variable 'ret' > HID: wacom_sys: Demote kernel-doc abuse > HID: hid-sensor-hub: Remove unused struct member 'quirks' > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > definition > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning > > drivers/hid/hid-alps.c | 2 +- > drivers/hid/hid-core.c | 2 +- > drivers/hid/hid-kye.c | 2 +- > drivers/hid/hid-logitech-hidpp.c | 7 +-- > drivers/hid/hid-picolcd_core.c | 5 +-- > drivers/hid/hid-sensor-custom.c | 5 +-- > drivers/hid/hid-sensor-hub.c | 4 +- > drivers/hid/hid-thrustmaster.c | 24 +++++------ > drivers/hid/hid-uclogic-params.c | 8 ++-- > drivers/hid/hid-uclogic-rdesc.c | 2 +- > drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- > drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +- > drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++---------- > drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++-- > drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- > drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +--- > drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++- > drivers/hid/intel-ish-hid/ishtp/client.c | 5 +-- > drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +- > drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +- > drivers/hid/usbhid/hid-pidff.c | 4 +- > drivers/hid/usbhid/usbkbd.c | 2 +- > drivers/hid/wacom_sys.c | 2 +- > include/linux/intel-ish-client-if.h | 8 +++- > 24 files changed, 90 insertions(+), 81 deletions(-) > > Cc: Alexandre Torgue > Cc: Anssi Hannula > Cc: Benjamin Tissoires > Cc: "Bruno Prémont" > Cc: "Christian König" > Cc: Daniel Drubin > Cc: Dario Pagani > Cc: dri-devel@lists.freedesktop.org > Cc: Henrik Rydberg > Cc: Jiri Kosina > Cc: Jonathan Cameron > Cc: Kai-Heng Feng > Cc: Kim Kuparinen > Cc: "Krzysztof Wilczyński" > Cc: Lee Jones > Cc: linaro-mm-sig@lists.linaro.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-iio@vger.kernel.org > Cc: linux-input@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-usb@vger.kernel.org > Cc: Lopez Casado > Cc: "L. Vinyard, Jr" > Cc: Masaki Ota > Cc: Maxime Coquelin > Cc: message to > Cc: Michael Haboustak > Cc: Rushikesh S Kadam > Cc: Srinivas Pandruvada > Cc: Sumit Semwal > Cc: "Uwe Kleine-König" > Cc: Vojtech Pavlik > Cc: Zhang Lixu