From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line
Date: Fri, 16 Apr 2021 11:54:32 +0300 [thread overview]
Message-ID: <20210416085431.GM3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2104161045140.8503@hadrien>
On Fri, Apr 16, 2021 at 10:46:54AM +0200, Julia Lawall wrote:
> > > If you're running into the 80 character limit, then it's fine to use
> > > two tabs. I think we have been rejecting patches that push align the
> > > parameters but push past the 80 character limit. Using one tab is
> > > confusing because it makes the decalarations line up with the code.
> >
> > Interesting. Do you have an example of this? I've thought checkpatch.pl
> > gave a warning if the line ended with an opening parenthesis no matter
> > what.
>
> Checkpatch is a perl script that searches for patterns that often indicate
> code that is hard to understand. It is not a precise definition of what
> is allowed in the Linux kernel. Humans have to amke compromises.
Yeah... but I'd think if this is a preferred style then the warning could
be omitted. It might not be that difficult.
--
Sakari Ailus
next prev parent reply other threads:[~2021-04-16 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 17:08 [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line Aline Santana Cordeiro
2021-04-15 17:14 ` [Outreachy kernel] " Matthew Wilcox
2021-04-15 18:09 ` ascordeiro
2021-04-15 19:49 ` Sakari Ailus
2021-04-15 19:57 ` Matthew Wilcox
2021-04-15 19:59 ` Matthew Wilcox
2021-04-15 21:21 ` Sakari Ailus
2021-04-16 5:49 ` Dan Carpenter
2021-04-16 8:37 ` Sakari Ailus
2021-04-16 8:46 ` Julia Lawall
2021-04-16 8:54 ` Sakari Ailus [this message]
2021-04-16 9:03 ` Julia Lawall
2021-04-16 9:13 ` Dan Carpenter
2021-04-20 12:41 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416085431.GM3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=alinesantanacordeiro@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).