From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: 'Mauro Carvalho Chehab' <mchehab@kernel.org>,
Ashish Kalra <eashishkalra@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: atomisp: silence "dubious: !x | !y" warning
Date: Sun, 18 Apr 2021 23:59:31 +0200 [thread overview]
Message-ID: <20210418215931.kbgme42kgnpqbwn4@mail> (raw)
In-Reply-To: <509f019decae433cab6cb367cdfa6fa9@AcuMS.aculab.com>
On Sat, Apr 17, 2021 at 09:31:32PM +0000, David Laight wrote:
> > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice
> > > for this file. Logical and bitwise OR are basically the same in this
> > > context so it doesn't cause a runtime bug. But let's change it to
> > > logical OR to make it cleaner and silence the Sparse warning.
>
> The old code is very likely to by slightly more efficient.
>
> It may not matter here, but it might in a really hot path.
>
> Since !x | !y and !x || !y always have the same value
> why is sparse complaining at all.
They both will have the same value here and any half-decent
compiler know that and thus generate the same code, so no
worries about efficiency.
Sparse complains because the programmer's intention is not clear.
Was a boolean context or a bitwise context that was meant?
Maybe '||' was meant and the RHS had to be short cut?
Maybe what was meant was '~x | ~y'?
-- Luc
next prev parent reply other threads:[~2021-04-18 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 15:36 [PATCH] media: atomisp: silence "dubious: !x | !y" warning Ashish Kalra
2021-04-17 18:56 ` Mauro Carvalho Chehab
2021-04-17 21:31 ` David Laight
2021-04-18 1:15 ` Ashish Kalra
2021-04-18 21:59 ` Luc Van Oostenryck [this message]
2021-04-20 10:27 ` Dan Carpenter
2021-04-20 10:36 ` David Laight
2021-04-18 1:26 ` Ashish Kalra
2021-04-20 12:04 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418215931.kbgme42kgnpqbwn4@mail \
--to=luc.vanoostenryck@gmail.com \
--cc=David.Laight@aculab.com \
--cc=devel@driverdev.osuosl.org \
--cc=eashishkalra@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).